#1069 search for swedish card #1075

Merged
c24danli merged 1 commit from #1069-search-for-swedish-cards into team_2_week_7 2026-05-22 08:50:02 +00:00
Collaborator

Issue: #1069 being able to search for swedish card translations
Problem: When having swedish translation and searching for cards, nothing would appear since it was based on the english one.
Solution: Added search for localized card titles and added title translation to a few that did not have that yet.

Issue: #1069 being able to search for swedish card translations Problem: When having swedish translation and searching for cards, nothing would appear since it was based on the english one. Solution: Added search for localized card titles and added title translation to a few that did not have that yet.
Added search for swedish and added title translation
Collaborator

Review on #1069

Whats done

Tested on Windows using Firefox

  • App starts
    • No issues found
  • Tested searching for cards in Swedish, works as expected

Inspected following files

  • frontend/src/features/addCardModal/AddCardModal.js
    • Indentation/code styling
      • Indentation is ok
    • Naming convention
      • Follows wiki standard
    • Printed text uses and follows localization standards
      • Follows standard, search now uses translate(view.title) instead of view.value
    • Comments
      • No new comments added, not needed
    • General code quality
      • The search filter changed from view.value to translate(view.title) which makes it search the localized title instead. This fixes the issue.
  • frontend/src/pages/dashboard/Dashboard.js
    • Indentation/code styling
      • Indentation is ok
    • Naming convention
      • Follows wiki standard
    • Printed text uses and follows localization standards
      • Follows wiki standard.
    • Comments
      • Follows wiki standard
    • General code quality
      • No issues found

Conclusion

  • Ready for merge. The fix does what the issue asks for and the translation keys all exist in both language files.
# Review on #1069 ## Whats done ### Tested on Windows using Firefox + App starts + No issues found + Tested searching for cards in Swedish, works as expected ### Inspected following files + frontend/src/features/addCardModal/AddCardModal.js + Indentation/code styling + Indentation is ok + Naming convention + Follows wiki standard + Printed text uses and follows localization standards + Follows standard, search now uses translate(view.title) instead of view.value + Comments + No new comments added, not needed + General code quality + The search filter changed from view.value to translate(view.title) which makes it search the localized title instead. This fixes the issue. + frontend/src/pages/dashboard/Dashboard.js + Indentation/code styling + Indentation is ok + Naming convention + Follows wiki standard + Printed text uses and follows localization standards + Follows wiki standard. + Comments + Follows wiki standard + General code quality + No issues found ## Conclusion + Ready for merge. The fix does what the issue asks for and the translation keys all exist in both language files.
c24carso approved these changes 2026-05-22 08:17:52 +00:00
c24danli merged commit 3b370efb47 into team_2_week_7 2026-05-22 08:50:02 +00:00
c24danli deleted branch #1069-search-for-swedish-cards 2026-05-22 12:32:42 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Andras/BoundlessFlowCampus2K!1075
No description provided.