940-Keys-in-localization-files-should-be-in-alphabetical-order #1101

Merged

a22erigr merged 3 commits from 940-Keys-in-localization-files-should-be-in-alphabetical-order into team_2_week_7

2026-05-22 10:11:35 +00:00

a24vinla commented

2026-05-22 09:03:08 +00:00

Collaborator

What has been done

frontend/src/locales/en.json
- Now ordered in alphabetical order, with the exception of view titles that are ordered numerically
- Changed dashbaord.UI.resetLayout -> dashboard.UI.resetLayout
frontend/src/locales/sv.json
- Now ordered in alphabetical order, with the exception of view titles that are ordered numerically
frontend/src/pages/dashboard.js
- Changed dashbaord.UI.resetLayout -> dashboard.UI.resetLayout on line 449

If this ever has to be done again I have a script that allows us to only order one of the locales. The script uses the ordered locale's ordering to create a new locale with the values of the unordered locale, but the order of the ordered locale, locally. Since it is such a niche use case I will not add it to the project.

## What has been done + frontend/src/locales/en.json + Now ordered in alphabetical order, with the exception of view titles that are ordered numerically + Changed dashbaord.UI.resetLayout -> dashboard.UI.resetLayout + frontend/src/locales/sv.json + Now ordered in alphabetical order, with the exception of view titles that are ordered numerically + frontend/src/pages/dashboard.js + Changed dashbaord.UI.resetLayout -> dashboard.UI.resetLayout on line 449 If this ever has to be done again I have a script that allows us to only order one of the locales. The script uses the ordered locale's ordering to create a new locale with the values of the unordered locale, but the order of the ordered locale, locally. Since it is such a niche use case I will not add it to the project.

a24vinla added the

needs review

label

2026-05-22 09:03:08 +00:00

a24vinla added 3 commits

2026-05-22 09:03:09 +00:00

en.json is now in alphabetical order (with the exception of view titles, that are numerical) 12b07aed5b

Fixed misspelling of key in dashboard.js 7b3874af17

sv.json is now in alphabetical order 221b40fdc3

a24vinla commented

2026-05-22 09:08:44 +00:00

Author

Collaborator

I have also updated the wiki to include that sections with numbered keys (views.id.title as an example) may be ordered numerically:
https://git.webug.se/Andras/BoundlessFlowCampus2K/wiki/Localization

I have also updated the wiki to include that sections with numbered keys (views.id.title as an example) may be ordered numerically: https://git.webug.se/Andras/BoundlessFlowCampus2K/wiki/Localization

c24danli requested review from c24carso

2026-05-22 09:20:59 +00:00

c24carso commented

2026-05-22 09:48:23 +00:00

Collaborator

Review on #940

Whats done

Tested on Windows using Firefox

App starts
- No issues found
Tested that all localized text still displays correctly in both English and Swedish

Inspected following files

frontend/src/locales/en.json
- Indentation/code styling
  - Indentation is ok
- Printed text uses and follows localization standards
  - Keys are now in alphabetical order within groups, with linebreaks between groups. Views section is ordered numerically. Follows the localization standard.
- Comments
  - Not needed
- General code quality
  - No issues. All keys match between en.json and sv.json.
frontend/src/locales/sv.json
- Indentation/code styling
  - Indentation is ok, uses tabs
- Printed text uses and follows localization standards
  - Same as en.json.
- Comments
  - Not needed
- General code quality
  - No issues. All keys match between en.json and sv.json.
frontend/src/pages/dashboard/Dashboard.js
- Indentation/code styling
  - Indentation is ok
- Naming convention
  - Follows wiki standard
- Printed text uses and follows localization standards
  - typo fixed
- Comments
  - Follows wiki standard
- General code quality
  - No issues
Wiki Localization page
- Looks good.

Conclusion

Ready for merge. All keys are alphabetically sorted and a typo is fixed.

# Review on #940 ## Whats done ### Tested on Windows using Firefox + App starts + No issues found + Tested that all localized text still displays correctly in both English and Swedish ### Inspected following files + frontend/src/locales/en.json + Indentation/code styling + Indentation is ok + Printed text uses and follows localization standards + Keys are now in alphabetical order within groups, with linebreaks between groups. Views section is ordered numerically. Follows the localization standard. + Comments + Not needed + General code quality + No issues. All keys match between en.json and sv.json. + frontend/src/locales/sv.json + Indentation/code styling + Indentation is ok, uses tabs + Printed text uses and follows localization standards + Same as en.json. + Comments + Not needed + General code quality + No issues. All keys match between en.json and sv.json. + frontend/src/pages/dashboard/Dashboard.js + Indentation/code styling + Indentation is ok + Naming convention + Follows wiki standard + Printed text uses and follows localization standards + typo fixed + Comments + Follows wiki standard + General code quality + No issues + Wiki Localization page + Looks good. ## Conclusion + Ready for merge. All keys are alphabetically sorted and a typo is fixed.