228-new-frontend-for-parking #1146
No reviewers
Labels
No labels
_CRITICAL_
API
app
backEnd
Blocked, waiting for further changes
bug
cleanup
close
design
duplicate
enhancement
feature request
frontEnd
help wanted
invalid
low priority
needs input
needs review
project documentation
question
research
reviewed
script
security
SQL
style
testing
topLevel
wontfix
No milestone
No project
No assignees
4 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
Andras/BoundlessFlowCampus2K!1146
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "228-new-frontend-for-parking"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
I took the original layout that was already there in parkingLayout.js, and made one for each zone. I know this is horrendous for when you want to change something like size, as all coordinates and viewbox sizing will have to be updated as well. But I thought this could be improved in another issue maybe.
All and all I think it works and showcases things correctly.
Issue: #228
The number for available spots is incorrect, it is one number less than it should be, see picture. And on grus it looks like all parkingspots are free, but it says only 6 are free.
Is the idea to make them look like the parkings that are actually at Högskolan? This was the idea with the issue
@a24julot wrote in #1146 (comment):
Yeah I thought about that but wasn't sure how to be able to do it as I couldn't find good images online of the parking spots. I could try if I got them though.
And for the Grus I think I know how to fix it so I'll do it now.
This is a screenshot from google maps, I think you can get a pretty good picture of the parking spots
Ahh yeah switching to satelite made it work. Just to be clear. Is it these six? (forgot to circle in the grus)
Not the one to the right, that is for science park.
You can just focus on getting the correct layout for one parking zone for now because the merge is tomorrow.
In service/parkingService/parkingService/README.md there is an explanation on which parking is which.
Ah tomorrow merge already? Yeah ok nice that readme will help a lot as I had no idea which one was which. I guess A is for the A house though so I can begin with that.
Started and got a fair way on E, but it was a bit tricky. I won't be able to update it more today but can fix so the parking spots match later in the week after the merge if that's okay.
All layouts have been updated. When doing this, I ordered the spots from left to right and tried to comment what spots are where in the layout. Usually they start from the top left from the pov of a car arriving at the parking. This means I did not take into account the what spots are "special". This may need to be changed in the future (changing what spots are special in mockup generation would be easiest, I think), but since special spots are not used in the frontend at the moment, I think this is fine for now.
The merge conflicts in ParkingView.js are easy to fix. I believe it is only the title that has should be changed to the localization key and that in both_teams branch, the useParking hook has not got the zone parameter yet.
It is too late for me to look at the merge conflicts in theme.css. Good luck with that
(Ps. I'm aware that it would have been easier to change the values of height and width for the rectangles instead of adding angle 90 to (almost) everything in the layouts, but when realizing this, I was already in too deep...)
Also, when looking at A on google maps, I could only identify 21 spots. However, the mockup generates data for 22, so I added 22 spots in the layout. This needs to be investigated further in the future, but it is not something major
What works
Great job everyone involved.
GREAT job!!!