Andras/BoundlessFlowCampus2K

Fork 0

Handling data for sensorRead from a DBS #12

New issue

Closed

opened 2026-03-27 15:30:01 +00:00 by Andras · 4 comments

Andras commented

2026-03-27 15:30:01 +00:00

Owner

sensorRead handles old (historical) data.

Add a function so that we can read in old (historical) data when we are updating (or refreshing the system).

sensorRead handles old (historical) data. Add a function so that we can read in old (historical) data when we are updating (or refreshing the system).

Andras added the

feature request

label

2026-03-27 15:30:01 +00:00

Andras commented

2026-03-27 15:31:15 +00:00

Author

Owner

Parent / related issue: [Additional microservices for monitoring for multiple sensors #7](https://git.webug.se/Andras/BoundlessFlowCampus2K/issues/7)

a24vinla added the

Team 2

label

2026-03-31 10:46:14 +00:00

c24danli was assigned by c24elipe

2026-04-07 11:53:22 +00:00

c24danli commented

2026-04-08 10:39:10 +00:00

Collaborator

I have made a fuction that read the historic data, and added a view just to show it. I took it as this issue was only to create the read part so the view is not as it should be displayed only to show the values and see that it works.

c24danli added the

needs review

label

2026-04-08 10:43:37 +00:00

a22erigr was assigned by c24elipe

2026-04-08 10:52:48 +00:00

c24danli commented

2026-04-08 11:04:37 +00:00

Collaborator

Added parts in the branch:
2 new files under /frontend/src/features/temperature

TemperatureTimeSeriesView.js # a view just to see that it works
useTemperatureTimeSeriesView.js # the actual feature
and in /frontend/src/app/App.js
i have added line 9
<TemperatureTimeSeriesView/>
to call the render on the lokalhost to view

Added parts in the branch: 2 new files under /frontend/src/features/temperature - TemperatureTimeSeriesView.js # a view just to see that it works - useTemperatureTimeSeriesView.js # the actual feature and in /frontend/src/app/App.js i have added line 9 `<TemperatureTimeSeriesView/>` to call the render on the lokalhost to view

a22erigr commented

2026-04-08 12:45:17 +00:00

Collaborator

Whats done

Tested on fedora 43
- Worked without problems
- Used UnixBuild.sh
inspected code in following files
- TemperatureTimeSeriesView.js
- useTemperatureTimeSeriesView.js
- App.js
Tested to run the function useTemperatureTimeSeriesView using a empty array.

const [data, setData] = useState([]);

This worked without problems.
Also tested the code using null instead of an empty array.

const [data, setData]  = useState(null);

This also worked and should be implemented.
- Reason: Breakout of duplicate code in frontend/src/features #159
- By using null it's going to be easier to refactor the code to use the shared useApi function.

Needs to be improved

Comments in TemperatureTimeSeriesView.js and useTemperatureTimeSeriesView.js does not follow the standard for multi line comments in javascript. How to comment .

//This function uses the prebuilt api/temperature/all in middleware/tempService
// if succsessfull it gives back an list of pares timestamp,temperature inside the data varible being returned
// the array in the data varible will hold all recorded pairs in the db so it needs to be filtered if the entirerty is unwanted
//[
//  {Timestamp,temperature}
//  {Timestamp,temperature}
//  {Timestamp,temperature}
//]

Unnecessary change to code.

const [data, setData] = useState([]);

change to.

const [data, setData] = useState(null);

No unit tests for useTemperatureTimeSeriesView
- Unit test for this function is unnecessary be because the refactoring done in Breakout of duplicate code in frontend/src/features #159 The central function useApi already implements a unit test.
- This implies that you don't need to implement a unit test but in future don't forget to write unit tests.

## Whats done + Tested on fedora 43 + Worked without problems + Used **_UnixBuild.sh_** + inspected code in following files + TemperatureTimeSeriesView.js + useTemperatureTimeSeriesView.js + App.js + Tested to run the function _**useTemperatureTimeSeriesView**_ using a empty array. ``` javascript const [data, setData] = useState([]); ``` + This worked without problems. + Also tested the code using null instead of an empty array. ```javascript const [data, setData] = useState(null); ``` + This also worked and should be implemented. + Reason: [Breakout of duplicate code in frontend/src/features #159](https://git.webug.se/Andras/BoundlessFlowCampus2K/issues/159) + By using null it's going to be easier to refactor the code to use the shared _**useApi**_ function. ## Needs to be improved + Comments in TemperatureTimeSeriesView.js and useTemperatureTimeSeriesView.js does not follow the standard for multi line comments in javascript. [How to comment ](https://git.webug.se/Andras/BoundlessFlowCampus2K/wiki/React%2FJavaScript-coding-standards#comments). ``` javascript //This function uses the prebuilt api/temperature/all in middleware/tempService // if succsessfull it gives back an list of pares timestamp,temperature inside the data varible being returned // the array in the data varible will hold all recorded pairs in the db so it needs to be filtered if the entirerty is unwanted //[ // {Timestamp,temperature} // {Timestamp,temperature} // {Timestamp,temperature} //] ``` + Unnecessary change to code. ``` javascript const [data, setData] = useState([]); ``` + change to. ``` javascript const [data, setData] = useState(null); ``` + No unit tests for _**useTemperatureTimeSeriesView**_ + Unit test for this function is unnecessary be because the refactoring done in [Breakout of duplicate code in frontend/src/features #159](https://git.webug.se/Andras/BoundlessFlowCampus2K/issues/159) The central function _**useApi**_ already implements a unit test. + This implies that you don't need to implement a unit test but in future don't forget to write unit tests.

a22erigr added

reviewed

and removed

needs review

labels

2026-04-08 16:29:04 +00:00

c24danli referenced this issue from a commit

2026-04-10 09:20:22 +00:00

Issue with historic data for specific sensor fixed