Andras/BoundlessFlowCampus2K

Fork 0

Testing: create test for tempSensorMockup #157

New issue

Closed

opened 2026-04-07 12:21:13 +00:00 by b24johka · 3 comments

b24johka commented

2026-04-07 12:21:13 +00:00

Collaborator

Create tests for the cs file "Program.cs"

b24erika was assigned by b24johka

2026-04-07 12:21:13 +00:00

a24vinla added the

testing

label

2026-04-07 13:02:48 +00:00

b24johka referenced this issue

2026-04-09 12:06:34 +00:00

Changed all references from MQT version 4.3.1 to 4.3.1.187, also tested so all depencies works. #208

b24johka added reference #157-test-tempSensor

2026-04-09 12:07:46 +00:00

b24erika added the

needs review

label

2026-04-09 13:33:42 +00:00

b24erika commented

2026-04-09 13:35:24 +00:00

Collaborator

Branch (pull-request) is closed and reviewed, should this issue still exist?

f21marfo was assigned by b24johka

2026-04-10 10:15:56 +00:00

f21marfo commented

2026-04-10 11:19:24 +00:00

Collaborator

Attempted to run test but test was unable to connect with the tempSensorMockup for some reason.

Reviewed written tests and code:
There is only one test, and all it does is validate that the data structure actually contains sensorId, timestamp and temperature. However, it does not establish the correctness of the datastructure, as no testing is performed to ensure that there are is extraneous data present, aka tags/data that shouldn't be there.

There also exists no tests to validate the actual data generated by the tempSensorMockup for either correct value types or allowed values and/or characters. I.E if temperature is inserted in place of the timestamp and vice versa, insertion of special characters, etc.

Recommendations:

Flesh out JsonData_TagsCorrect_ReturnTrue() test to ensure ONLY sensorId, timestamp and temperature tags exist.
Write additional tests for data validation.

Attempted to run test but test was unable to connect with the tempSensorMockup for some reason. ![image](/attachments/67e3e738-3117-42b0-9d7f-d8288109cf8d) Reviewed written tests and code: There is only one test, and all it does is validate that the data structure actually _contains_ **sensorId**, **timestamp** and **temperature**. However, it does not establish the correctness of the datastructure, as no testing is performed to ensure that there are is extraneous data present, aka tags/data that shouldn't be there. There also exists no tests to validate the actual data generated by the tempSensorMockup for either correct value types or allowed values and/or characters. I.E if temperature is inserted in place of the timestamp and vice versa, insertion of special characters, etc. Recommendations: - Flesh out JsonData_TagsCorrect_ReturnTrue() test to ensure ONLY **sensorId**, **timestamp** and **temperature** tags exist. - Write additional tests for **data validation**.

image.png

49 KiB

b24johka referenced this issue

2026-04-10 11:59:22 +00:00

Testing: Extend the test scope for tempSensorMockup #234

b24johka commented

2026-04-10 12:02:06 +00:00

Author

Collaborator

This has been merged and a issue to extend the testing scope has been created #234

b24johka closed this issue

2026-04-10 12:02:08 +00:00