Andras/BoundlessFlowCampus2K

Fork 0

#157-test-tempSensor #176

Merged

b24johka merged 9 commits from #157-test-tempSensor into team_1_week_1

2026-04-09 10:53:54 +00:00

b24erika commented

2026-04-08 10:45:03 +00:00

Collaborator

pull-request to merge branch into team 1 branch

b24erika added 7 commits

2026-04-08 10:45:04 +00:00

test file for tempSensor fc60b6a52a

testing so that values are passed.

Coding standards cbb2e52903

Added comments and correct coding standards for C#

Coding standards f85e092b65

Rename & coding standards 7d4c346a40

Added Xunit to project a59fd2be0a

as well as testing for tempSensorMockup

testing with existing xUnit method c6854c35a9

commented out self-made function

Coding standards 67856903a9

Comments and descriptions added.

b24erika added the

needs review

Team 1

testing

labels

2026-04-08 10:47:45 +00:00

a24hirsa was assigned by b24johka

2026-04-08 10:50:34 +00:00

b24johka commented

2026-04-08 10:50:51 +00:00

Collaborator

Assigned a24hirsa to review.

a24hirsa commented

2026-04-08 11:47:57 +00:00

Collaborator

Code looks good and test can run on Linux machines from the test folder with no error, and outside in parent folder with some errors but still succeeding

Make sure to close VScode or your IDE then open it again to update and load in new packages and dependencies needed to run Xunit tests. If this still doesn't work go to the wiki and follow the Add Xunit to project guide here https://git.webug.se/Andras/BoundlessFlowCampus2K/wiki/xUnit

Code looks good and test can run on Linux machines from the test folder with no error, and outside in parent folder with some errors but still succeeding Make sure to close VScode or your IDE then open it again to update and load in new packages and dependencies needed to run Xunit tests. If this still doesn't work go to the wiki and follow the Add Xunit to project guide here https://git.webug.se/Andras/BoundlessFlowCampus2K/wiki/xUnit

b24erika added 1 commit

2026-04-08 12:20:37 +00:00

Delete UnitTest1.cs 85e22b16f6

unnecessary file

b24erika added 1 commit

2026-04-08 13:20:56 +00:00

Code standard 7e3283dd11

rename file to follow new naming convention.

a24noabe commented

2026-04-08 13:35:50 +00:00

Collaborator

Note: I ran the test from a PowerShell instance, if it doesn't work using VSCode then do what Hirad mentions here:
@a24hirsa wrote in #176 (comment):

Code looks good and test can run on Linux machines from the test folder with no error, and outside in parent folder with some errors but still succeeding

Make sure to close VScode or your IDE then open it again to update and load in new packages and dependencies needed to run Xunit tests. If this still doesn't work go to the wiki and follow the Add Xunit to project guide here https://git.webug.se/Andras/BoundlessFlowCampus2K/wiki/xUnit

Code looks good and test runs on a windows machine. I get some warnings regarding the MQTTnet version, but I'm ignoring these since I can't seem to add the right package version even when specifying which version to add. Note: I ran the test from a PowerShell instance, if it doesn't work using VSCode then do what Hirad mentions here: @a24hirsa wrote in https://git.webug.se/Andras/BoundlessFlowCampus2K/pulls/176#issuecomment-1256: > Code looks good and test can run on Linux machines from the test folder with no error, and outside in parent folder with some errors but still succeeding > > Make sure to close VScode or your IDE then open it again to update and load in new packages and dependencies needed to run Xunit tests. If this still doesn't work go to the wiki and follow the Add Xunit to project guide here https://git.webug.se/Andras/BoundlessFlowCampus2K/wiki/xUnit

a24noabe added

reviewed

and removed

needs review

labels

2026-04-08 13:36:19 +00:00

b24johka commented

2026-04-09 10:21:26 +00:00

Collaborator

Because all of the testers have had some issues regarding packages the issue will go through a final test, i will do this review.

b24johka commented

2026-04-09 10:21:46 +00:00

Collaborator

Because all of the testers have had some issues regarding packages the issue will go through a final test, i will do this review.

b24johka commented

2026-04-09 10:46:38 +00:00

Collaborator

After changing the package reference to the version of MQT that is available i got a clean result of the tests.
The tests where conducted with an entirely new clone of the project.
The issue with MQT will be researched, but it is not related to this issue.
Well done!

![image](/attachments/29d9bffa-5070-4173-ac64-d18529954df7) After changing the package reference to the version of MQT that is available i got a clean result of the tests. The tests where conducted with an entirely new clone of the project. The issue with MQT will be researched, but it is not related to this issue. Well done!

image.png

111 KiB