Enforce a styling standard for Views #244
Labels
No labels
_CRITICAL_
API
app
backEnd
Blocked, waiting for further changes
bug
cleanup
close
design
duplicate
enhancement
feature request
frontEnd
help wanted
invalid
low priority
needs input
needs review
project documentation
question
research
reviewed
script
security
SQL
style
testing
topLevel
wontfix
No milestone
No project
No assignees
3 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
Andras/BoundlessFlowCampus2K#244
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Soon, after the weekly merge, the HiS color schemes will be implemented and has been tested on Cards. Views also needs to follow a standard so that the frontend doesn't look weird.
Could you clarify what you mean with the "standard"?
Should there be a fixed mapping of the palette variables?
such as this:
--color1 darkest/strongest fitting for headers?
--color4 lightest /contrast fitting for text?
Or am I completely off target.
As I understand it most cards as of now use the default styling of the Card's CSS module, which will use the standard HiS colors just like we want. But some Views might use special or custom components. I've seen that a custom component in one of the branches is WeatherGraph and has its own CSS module. I haven't really looked at it but such components should follow a standard so that they look like the regular Card, or as "good" as possible.
The standard that I think is need should document how, when creating a new CSS module, it should be made, or at least that it should be included in the review to reject anything that is "out of standard". This is really hard to put into words, but I hope I get my point across.
A very bad example could be our buttons. @b24johka has made a button component that is already styled and can be put anywhere. It uses the color palette that we have and it is all good. But since he is creating that button and CSS from scratch he could technically put any of the 4 colors from the palette. In light mode, he could color the button in the lightest color the palette offers, which would look terrible since the contrast of the colors would be so low that it might look invisible. This is kinda going into #183 as it both has to do with accessibility and the frontend looking good.
That is kinda the summary, a standard for components "looking the same".
Also it is important (and maybe a help) to follow the guidelines the University has on its colors.
Note: if you want to check accessibility, there are built-in solutions in Firefox:

This is where you can check things