useApi now takes dependencies. #253

Merged

c24elipe merged 4 commits from #246-Make-shared-API-to-take-dependencies,-to-make-it-compatible-with-useTemperature into team_2_week_1

2026-04-13 13:16:54 +00:00

a22erigr commented

2026-04-13 09:05:10 +00:00

Collaborator

useTemperatureTimeSeriesView and useTemperature uses the shared api
function useApi
All function that previously used useApi have been modified to also
send dependencies. Send null if no dependencies are needed.

+ useTemperatureTimeSeriesView and useTemperature uses the shared api function useApi + All function that previously used useApi have been modified to also send dependencies. Send null if no dependencies are needed.

a22erigr added 1 commit

2026-04-13 09:05:10 +00:00

useApi now takes dependencies. ae07ac018f

+ useTemperatureTimeSeriesView and useTemperature uses the shared api
function useApi
+ All function that previously used useApi have been modified to also
send dependencies. Send null if no dependencies are needed.

c24elipe

2026-04-13 09:05:41 +00:00

added the
needs review
label
requested review from b24idalu

a22erigr was assigned by c24elipe

2026-04-13 09:18:38 +00:00

b24idalu commented

2026-04-13 09:46:21 +00:00

Collaborator

ScheduleView is giving an error, I assume this is because the API_URL is 'temp'.

Other than that everything is displayed, tested running everything and everything shows and updates as they should. Added the SMHI views and tested them as well, they worked.

Could be a good idea to add a comment stating to send null if no dependencies are needed.

ScheduleView is giving an error, I assume this is because the API_URL is 'temp'. Other than that everything is displayed, tested running everything and everything shows and updates as they should. Added the SMHI views and tested them as well, they worked. Could be a good idea to add a comment stating to send null if no dependencies are needed.

b24idalu requested changes

2026-04-13 09:53:02 +00:00

b24idalu left a comment

Collaborator

See comment in discussion

b24idalu removed the

needs review

label

2026-04-13 10:12:27 +00:00

a22erigr added 1 commit

2026-04-13 12:33:16 +00:00

Addes comment after review 1ce883ce72

c24elipe requested review from c24elipe

2026-04-13 12:34:17 +00:00

a22erigr added 1 commit

2026-04-13 12:47:08 +00:00

removed unused imports a622e7ee8d

c24elipe added 1 commit

2026-04-13 13:13:33 +00:00

Fix some spacing, and reorderd imports 1ea3c9cf43

c24elipe commented

2026-04-13 13:15:50 +00:00

Collaborator

Ran the code, it worked.
Also, the requested comment was added from @b24idalu's review.

Also, after some discussion with @a22erigr, I fixed some issues with importing unused dependencies.

I call it good enough to merge!

Ran the code, it worked. Also, the requested comment was added from @b24idalu's review. Also, after some discussion with @a22erigr, I fixed some issues with importing unused dependencies. I call it good enough to merge!

c24elipe merged commit b52057519c into team_2_week_1

2026-04-13 13:16:54 +00:00

c24elipe deleted branch #246-Make-shared-API-to-take-dependencies,-to-make-it-compatible-with-useTemperature

2026-04-13 13:16:55 +00:00

c24elipe referenced this pull request from a commit

2026-04-13 13:16:55 +00:00

Merge pull request 'useApi now takes dependencies.' (#253) from #246-Make-shared-API-to-take-dependencies,-to-make-it-compatible-with-useTemperature into team_2_week_1