a24vinla commented

Collaborator

To further standardize and simplify the review process we should create a template/check-list that reviewers can follow.

a24vinla added the

project documentation

label

2026-04-15 07:08:43 +00:00

a22erigr was assigned by a24vinla

2026-04-15 07:08:45 +00:00

a24vinla commented

2026-04-15 08:07:55 +00:00

Author

Collaborator

Add this to the wiki-page when reviewed!

Add this to the [wiki-page](https://git.webug.se/Andras/BoundlessFlowCampus2K/wiki/Reviews) when reviewed!

a22erigr commented

2026-04-15 08:15:39 +00:00

Collaborator

Review on #[Number of issue reviewed]

Whats done

[Review following things]

Tested on [Name of OS] using [Name of browser]

[Focus on checking features that the issue intended to solve/implement]
App starts [IF the app starts]
- [Here you write possible issues found e.g " HTTP 404 from TemperatureView", image overflow container "Name" ]
- [You should also write the things you have tested. e.g,Tested login in as user and guest. Checked it worked as intended]

Inspected following files [IMPORTANT!, Don't forget to inspect for unapproved dependencies in package.json ]

[Name of inspected file]
- [Check following things]
- Indentation/code styling [does it follow prettier]
  - [Writes Indentation is ok or problems noted]
- Naming convention [Including filename ]
  - [Here you write if the Naming convention is followed If not write what needs to be fixed ]
- Comments
  - [Follows standard. If the reviewer sees the need for more/less comments]
- General code quality
  - [Any general issues you found in the code i.e unnecessarily complex code, logic flaws and unused imports ]

What needs to be done

[Here you should write the things that needs to be fixed.]

[Location]
- [What needs to be done, e.g Fix the indentation to follow css standard]

Conclusion

[Here you write your conclusion after the review. i.e if the code is ready for merge or needs to be improved]
[Optional, general observation e.g no standard for .....]

# Review on #[Number of issue reviewed] ## Whats done [Review following things] ### Tested on [Name of OS] using [Name of browser] + [Focus on checking features that the issue intended to solve/implement] + App starts [IF the app starts] + [Here you write possible issues found e.g " HTTP 404 from TemperatureView", image overflow container "Name" ] + [You should also write the things you have tested. e.g,Tested login in as user and guest. Checked it worked as intended] ### Inspected following files [IMPORTANT!, Don't forget to inspect for unapproved dependencies in **package.json** ] + [Name of inspected file] + [Check following things] + Indentation/code styling [does it follow prettier] + [Writes Indentation is ok or problems noted] + Naming convention [Including filename ] + [Here you write if the Naming convention is followed If not write what needs to be fixed ] + Comments + [Follows standard. If the reviewer sees the need for more/less comments] + General code quality + [Any general issues you found in the code i.e unnecessarily complex code, logic flaws and unused imports ] ## What needs to be done [Here you should write the things that needs to be fixed.] + [Location] + [What needs to be done, e.g Fix the indentation to follow css standard] ## Conclusion + [Here you write your conclusion after the review. i.e if the code is ready for merge or needs to be improved] + [Optional, general observation e.g no standard for .....]

a22erigr added the

needs review

label

2026-04-15 08:15:47 +00:00

a22erigr commented

2026-04-15 08:16:41 +00:00

Collaborator

Can be found on wiki page https://git.webug.se/Andras/BoundlessFlowCampus2K/wiki/Reviews#template-for-review

b24krila was assigned by b24johka

2026-04-15 14:08:02 +00:00

b24krila commented

2026-04-15 14:23:50 +00:00

Collaborator

The structure of the template is good as it prompts the reviewer to check everything required from the general code quality to the implementation. So the template works well as a support tool to ensure consistency and to make reviews easier to manage and do.

The clear sections for testing, file inspection and required changes make it straightforward to communicate what has been review and what needs attention. Which leads to both developer and Coordinator to quickly understand the outcome of the review without needing additional inputs.

The structure of the template is good as it prompts the reviewer to check everything required from the general code quality to the implementation. So the template works well as a support tool to ensure consistency and to make reviews easier to manage and do. The clear sections for testing, file inspection and required changes make it straightforward to communicate what has been review and what needs attention. Which leads to both developer and Coordinator to quickly understand the outcome of the review without needing additional inputs.

b24krila added

reviewed

and removed

needs review

labels

2026-04-15 14:23:56 +00:00

a24vinla closed this issue

2026-04-15 15:11:13 +00:00