Andras/BoundlessFlowCampus2K
4
7
Fork 0
Code Issues 90 Pull requests 7 Projects Releases Packages Wiki Activity Actions

Script generations to fix #329-fix-env-generation-of-credentials. #336

Merged
c24elipe merged 10 commits from #329-fix-env-generation-of-credentials into team_2_week_2 2026-04-16 09:12:06 +00:00
Conversation 4 Commits 10 Files changed 9 +19 -42
c24elipe commented 2026-04-16 07:25:40 +00:00
Collaborator
Copy link
No description provided. 
Added the randomization to the Windows script
Right thing in right place + cleanup :)
b25marem commented 2026-04-16 08:44:49 +00:00
Collaborator
Copy link

A suggestion is to make the script always start from its own location at the beginningfor example
cd /d "%~dp0"
cd ..

A suggestion is to make the script always start from its own location at the beginningfor example cd /d "%~dp0" cd ..
image.png
32 KiB
image.png
a24timsv commented 2026-04-16 09:05:57 +00:00
Collaborator
Copy link

@b25marem wrote in #336 (comment):

A suggestion is to make the script always start from its own location at the beginningfor example cd /d "%~dp0" cd ..

This is not a bad idea. It would strengthen the script a lot. I would recommend that you create an issue for this and create a branch when this is merged as it is a good addition, but not critical.

@b25marem wrote in https://git.webug.se/Andras/BoundlessFlowCampus2K/pulls/336#issuecomment-3246: > A suggestion is to make the script always start from its own location at the beginningfor example cd /d "%~dp0" cd .. This is not a bad idea. It would strengthen the script a lot. I would recommend that you create an issue for this and create a branch when this is merged as it is a good addition, but not critical.
c24danli commented 2026-04-16 09:10:11 +00:00
Collaborator
Copy link

Review on #[329]

Whats done

[Review following things]

Tested on [Windows] using [Chrome]

  • [Focus on checking features that the issue intended to solve/implement]
  • App starts [Starts on installation not on rebuild]
    • [not working on Rebuild becose "" around the db_user and password, fix alreaddy on the way
"DATABASE_USER=77221270037833057610471" 
"DATABASE_PASSWORD=20062317023060379419210"

]

Inspected following files

  • [WindowsInstallation.bat]
    • [Works on installation]
      +[WindowsRebuild.bat]
    • [dont work issues stated above]
# Review on #[329] ## Whats done [Review following things] ### Tested on [Windows] using [Chrome] + [Focus on checking features that the issue intended to solve/implement] + App starts [Starts on installation not on rebuild] + [not working on Rebuild becose "" around the db_user and password, fix alreaddy on the way ``` "DATABASE_USER=77221270037833057610471" "DATABASE_PASSWORD=20062317023060379419210" ``` ] ### Inspected following files + [WindowsInstallation.bat] + [Works on installation] +[WindowsRebuild.bat] + [dont work issues stated above]
c24elipe merged commit 596766a6a1 into team_2_week_2 2026-04-16 09:12:06 +00:00
c24elipe deleted branch #329-fix-env-generation-of-credentials 2026-04-16 09:12:07 +00:00
b23albst commented 2026-04-16 09:27:16 +00:00
Collaborator
Copy link

Review on #329

Whats done

Tested on ubuntu using firefox

  • Tested that the .env with random unsername and password file is generated when running UnixInstallation.sh
  • App starts

Inspected following files scripts: UnixInstallation.sh

  • UnixInstallation.sh
    • Indentation/code styling ok

Conclusion

  • After running the unix install script, docker and the application can be started
# Review on #329 ## Whats done ### Tested on ubuntu using firefox + Tested that the .env with random unsername and password file is generated when running UnixInstallation.sh + App starts ### Inspected following files scripts: UnixInstallation.sh + UnixInstallation.sh + Indentation/code styling ok ## Conclusion + After running the unix install script, docker and the application can be started
Sign in to join this conversation.
Reviewers
No reviewers
b25marem
c24danli
b23albst
Labels
Clear labels   
_CRITICAL_

Only use this label for critical tasks that are project-scope,and must be addressed ASAP.

  
API

   
app

   
backEnd

   
Blocked, waiting for further changes

   
bug

Something is not working

  
cleanup

Issues to cleanup the codebase (restructure folders, remove deprecated or smelly code)

  
close

Issue to close

  
design

   
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
feature request

   
frontEnd

   
help wanted

Need some help

  
invalid

Something is wrong

  
low priority

   
needs input

Issue needs input from product owner or customer

  
needs review

issue is in need of review

  
project documentation

   
question

More information is needed

  
research

   
reviewed

This Issue has been reviewed

  
script

   
security

use this for security-related issues

  
SQL

  
style

   
testing

   
topLevel

Reserved for top-level, project-wide issues.

  
wontfix

This won't be fixed

No labels
_CRITICAL_
API
app
backEnd
Blocked, waiting for further changes
bug
cleanup
close
design
duplicate
enhancement
feature request
frontEnd
help wanted
invalid
low priority
needs input
needs review
project documentation
question
research
reviewed
script
security
SQL
style
testing
topLevel
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
c24elipe
a24timsv
6 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Andras/BoundlessFlowCampus2K!336
No description provided.