Andras/BoundlessFlowCampus2K

Fork 0

#371 Add URL input to schedule card #422

Merged

c24elipe merged 3 commits from #371-add-schedule-url-to-card into team_2_week_2

2026-04-21 12:22:05 +00:00

c24carso commented

2026-04-17 14:00:50 +00:00

Collaborator

Added a text field for TimeEdit URL with error messages in case of wrong URL. Converts the .html links to .json.

Screenshot 2026-04-17 155926.png

22 KiB

Screenshot 2026-04-17 155945.png

6.8 KiB

c24carso added 1 commit

2026-04-17 14:00:51 +00:00

#371 Add URL input to schedule card ece5d294c5

Added a text field for TimeEdit URL with error messages in case of wrong URL. Converts the html links to json.

c24carso added the

needs review

label

2026-04-17 14:03:40 +00:00

c24elipe requested review from c22abdal

2026-04-20 08:44:47 +00:00

c22abdal commented

2026-04-20 09:07:37 +00:00

Collaborator

Everything is working fine. Great work! There are only some minor details that could be fixed before merging.
in the scheduleView line:
{data.reservations.map((reservations, index) => {
Change (reservations, index) to reservation since you are only using one reservation

In
onChange={(e) => setUrl(e.target.value)}
Avoid the shortened e in OnChange. Personally, I don't see a problem with it, but rules are rules, I guess. So replace it with event or something you find fitting.

Everything is working fine. Great work! There are only some minor details that could be fixed before merging. in the scheduleView line: `{data.reservations.map((reservations, index) => {` Change (**reservations**, index) to **reservation** since you are only using one reservation In `onChange={(e) => setUrl(e.target.value)}` Avoid the shortened **e** in OnChange. Personally, I don't see a problem with it, but rules are rules, I guess. So replace it with **event** or something you find fitting.

c22abdal added

reviewed

and removed

needs review

labels

2026-04-20 09:07:46 +00:00

c24elipe removed the

reviewed

label

2026-04-20 09:22:08 +00:00

c24carso was assigned by c24elipe

2026-04-20 09:23:08 +00:00

c24carso added 1 commit

2026-04-20 14:21:11 +00:00

#371 Fix review feedback: rename map reservations and onChange variable 976d4b84cb

Renamed map callback parameter from reservations to reservation and changed e to event in onChange.

c24carso added the

needs review

label

2026-04-20 14:31:48 +00:00

c22abdal commented

2026-04-21 08:28:33 +00:00

Collaborator

Good work on following the scripting rules. On another note, I just noticed this issue in the card

The URL field is not responsive with the card. If you halve the size of the window, you'll see this issue.
I'm not sure how major this is for this specific task, but the results and code look correct logically.

Good work on following the scripting rules. On another note, I just noticed this issue in the card ![image](/attachments/79a97a5c-cfba-403c-a248-a07d5625c028) The URL field is not responsive with the card. If you halve the size of the window, you'll see this issue. I'm not sure how major this is for this specific task, but the results and code look correct logically.

image.png

4.8 KiB

c22abdal added

reviewed

and removed

needs review

labels

2026-04-21 08:28:52 +00:00