#394-Xunit-tests-for-roomBookingMockup #430

Merged

b24johka merged 3 commits from #394-Xunit-tests-for-roomBookingMockup into team_1_week_2

2026-04-21 08:17:10 +00:00

f21marfo commented

2026-04-20 08:32:38 +00:00

Collaborator

Unit tests have been written for the BookingGenerator class, to the extent that is deemed possible.

f21marfo added the

testing

needs review

labels

2026-04-20 08:32:38 +00:00

f21marfo added 3 commits

2026-04-20 08:32:38 +00:00

Implemented 3 tests for BookingGenerator 9c4d06eec2

Implemented the following tests for the BookingGenerator class.

- GetBookings_NoParameter_NotNull()
- GetBookings_NonZeroParameter_HasExpectedEntryCount()
- GetBookings_NonZeroParameter_EntriesNotNull()

Renamed Class file and added additional unit test b7cf3e6269

- Renamed the UnitTest1 class file to BookingGeneratorTests.cs
- Added unit test to check that a Null value is returned if one accidentally uses a negative value.

Removed un-needed package reference. 8918dbb57b

Removed     <PackageReference Include="Microsoft.AspNetCore.Mvc.Testing" Version="10.0.5" />

as i did not end up using it for now.

f21marfo referenced this pull request

2026-04-20 08:44:09 +00:00

Xunit tests for roomBookingMockup #394

b24johka requested review from a24hirsa

2026-04-21 07:26:21 +00:00

a24hirsa commented

2026-04-21 07:59:00 +00:00

Collaborator

Can't see any max value test, minimum test or above max value test, this is should be added as it is standard unit test practice before being merged in. If these don't exists due to the current code make sure to create a new issue to fix this in the future and then merge in

xUnit test is good and follows the testing guideline for a unit tests for back end data components testing for given sizes and null values and negative values/below minimum value. Code strucutre is good and well commented and tests succed when running on Linux. Can't see any max value test, minimum test or above max value test, this is should be added as it is standard unit test practice before being merged in. If these don't exists due to the current code make sure to create a new issue to fix this in the future and then merge in