Fix double click card enlarge

b24erika commented

2026-04-23 08:32:22 +00:00

Collaborator

This functionallity caused issues and where removed, it is now implemented with some minor flaws. When resizing, the card gets "wrong" size, it also covers other cards on the grid.

The function was added to the file "SaveGrid.js".

This functionallity caused issues and where removed, it is now implemented with some minor flaws. When resizing, the card gets "wrong" size, it also covers other cards on the grid. The function was added to the file "SaveGrid.js".

b24erika added the

bug

frontEnd

Team 1

labels

2026-04-23 08:32:22 +00:00

b24hugst commented

2026-04-23 08:47:21 +00:00

Collaborator

Could I be assigned to this? I created the first version.

b24hugst commented

2026-04-23 08:49:34 +00:00

Collaborator

#488 #489

b24erika commented

2026-04-23 08:49:52 +00:00

Author

Collaborator

@b24hugst I think that they wanted to create the team branches before fixing the function and I am certain that you will be assigned the issue!

👍 1

b24hugst was assigned by b24johka

2026-04-23 09:54:05 +00:00

b24johka added reference team_1_week_3

2026-04-23 09:54:08 +00:00

a24timsv commented

2026-04-23 11:17:03 +00:00

Collaborator

Relevant issue: #270

Be sure to close this once it works as intended.

Relevant issue: #270 Be sure to close this once it works as intended.

b24hugst changed reference from ~~team_1_week_3~~ to #500-fix-card-enlargement

2026-04-23 13:47:37 +00:00

b24hugst commented

2026-04-23 13:56:50 +00:00

Collaborator

I saw after the merge that the vertical compactor got removed. The one that automatically pushes cards up the top when there's space.

How important is it that we have no compactor? Because it becomes much harder to implement this with no compactor because a lot of manual "pushing away" logic must be done to not have any overlap. Unless we could revert back to having vertical again.

If it's very important that we have no compactor I can try to do some manual logic, otherwise the function works again as shown in the video, and it now only works while in edit mode.

Although there is a small problem where when expanding a card that's positioned in the far-right, it will switch one position to the left when shrinking (I show this at the end of the video).

I saw after the merge that the vertical compactor got removed. The one that automatically pushes cards up the top when there's space. How important is it that we have no compactor? Because it becomes much harder to implement this with no compactor because a lot of manual "pushing away" logic must be done to not have any overlap. Unless we could revert back to having vertical again. If it's very important that we have no compactor I can try to do some manual logic, otherwise the function works again as shown in the video, and it now only works while in edit mode. Although there is a small problem where when expanding a card that's positioned in the far-right, it will switch one position to the left when shrinking (I show this at the end of the video).

2026-04-23 15-45-43.mp4

37 MiB

b24hugst referenced this issue

2026-04-24 07:16:08 +00:00

The react grid windows are scalable without edit mode (Minimize/maximize) #489

b24krila referenced this issue

2026-04-27 10:03:46 +00:00

Clean up duty #475

b24johka commented

2026-04-27 12:20:53 +00:00

Collaborator

Since we are not the team that removed vertical compactor i would like to have a discussion with the other team to see how important that feature is, i personally love the double click expansion feature.

a24vinla was assigned by b24johka

2026-04-27 12:21:11 +00:00

a24timsv was assigned by b24johka

2026-04-27 12:21:39 +00:00

a24timsv commented

2026-04-27 12:41:10 +00:00

Collaborator

I think a meeting is for the best. I've seen it removed, added and rebranded. I think it is fine, if it would work as intended, but when I see people interacting with it, it seems to have weird side effects.

I remember a issue that when selecting the URL in the schedule view it would enlarge because when marking the url field in the View one would double click to select all. What I'm getting at is that it sometimes is in the way. I don't really know what a solution to that would be, but maybe it could only be possible to enlarge outside of edit mode? If we have a problem that it behaves weirdly on the right side of the page, maybe we could remember the position of when it is small and revert back to that? Maybe we could make the card take the entire page, kinda like a modal? How often do we think people would enlarge several cards?

I'm just spitballing here but it might be worth to take a step back and reevaluate what we need or want.

I think a meeting is for the best. I've seen it removed, added and rebranded. I think it is fine, if it would work as intended, but when I see people interacting with it, it seems to have weird side effects. I remember a issue that when selecting the URL in the schedule view it would enlarge because when marking the url field in the View one would double click to select all. What I'm getting at is that it sometimes is in the way. I don't really know what a solution to that would be, but maybe it could only be possible to enlarge outside of edit mode? If we have a problem that it behaves weirdly on the right side of the page, maybe we could remember the position of when it is small and revert back to that? Maybe we could make the card take the entire page, kinda like a modal? How often do we think people would enlarge several cards? I'm just spitballing here but it might be worth to take a step back and reevaluate what we need or want.

👍 1

a24vinla commented

2026-04-27 12:42:10 +00:00

Collaborator

I believe that having no compactor is necessary, since the "dashboard" feeling is somewhat lost without it. If we find that we lose a lot of functionality because of this I think it would be fine adding vertical compacting, but not specifically and only to support this.

👍 1

a24vinla commented

2026-04-27 12:43:05 +00:00

Collaborator

I 100% agree with Tim!

b24hugst commented

2026-04-27 13:04:32 +00:00

Collaborator

I like the idea of a card taking up an entire page because I see this feature more as a simple quality-of-life tool used on the spot, rather than something for structuring cards. As the resizing function already handles that purpose much better.

👍 1

b24johka commented

2026-04-27 13:18:28 +00:00

Collaborator

Very good points! if i have interpreted this discussion correctly i would say that we are leaning towards having a pause to this issue, right? We are also figuring out how to grid is going to dynamically change to be responsive towards mobile devices and i feel like that is more in the focus as for now.

a24sakma commented

2026-05-05 12:33:04 +00:00

Collaborator

I can't reproduce the error. I close this issue.

a24sakma closed this issue

2026-05-05 12:33:08 +00:00

Rows
Columns

Fix double click card enlarge #500