Andras/BoundlessFlowCampus2K
4
7
Fork 0
Code Issues 90 Pull requests 7 Projects Releases Packages Wiki Activity Actions

Fix double click card enlarge #500

New issue
Closed
opened 2026-04-23 08:32:22 +00:00 by b24erika · 12 comments
b24erika commented 2026-04-23 08:32:22 +00:00
Collaborator
Copy link

This functionallity caused issues and where removed, it is now implemented with some minor flaws. When resizing, the card gets "wrong" size, it also covers other cards on the grid.

The function was added to the file "SaveGrid.js".

This functionallity caused issues and where removed, it is now implemented with some minor flaws. When resizing, the card gets "wrong" size, it also covers other cards on the grid. The function was added to the file "SaveGrid.js".
b24hugst commented 2026-04-23 08:47:21 +00:00
Collaborator
Copy link

Could I be assigned to this? I created the first version.

Could I be assigned to this? I created the first version.
b24hugst commented 2026-04-23 08:49:34 +00:00
Collaborator
Copy link

#488 #489

#488 #489
b24erika commented 2026-04-23 08:49:52 +00:00
Author
Collaborator
Copy link

@b24hugst I think that they wanted to create the team branches before fixing the function and I am certain that you will be assigned the issue!

@b24hugst I think that they wanted to create the team branches before fixing the function and I am certain that you will be assigned the issue!
👍 1
b24johka added reference team_1_week_3 2026-04-23 09:54:08 +00:00
a24timsv commented 2026-04-23 11:17:03 +00:00
Collaborator
Copy link

Relevant issue: #270

Be sure to close this once it works as intended.

Relevant issue: #270 Be sure to close this once it works as intended.
b24hugst changed reference from team_1_week_3 to #500-fix-card-enlargement 2026-04-23 13:47:37 +00:00
b24hugst commented 2026-04-23 13:56:50 +00:00
Collaborator
Copy link

I saw after the merge that the vertical compactor got removed. The one that automatically pushes cards up the top when there's space.

How important is it that we have no compactor? Because it becomes much harder to implement this with no compactor because a lot of manual "pushing away" logic must be done to not have any overlap. Unless we could revert back to having vertical again.

If it's very important that we have no compactor I can try to do some manual logic, otherwise the function works again as shown in the video, and it now only works while in edit mode.

Although there is a small problem where when expanding a card that's positioned in the far-right, it will switch one position to the left when shrinking (I show this at the end of the video).

I saw after the merge that the vertical compactor got removed. The one that automatically pushes cards up the top when there's space. How important is it that we have no compactor? Because it becomes much harder to implement this with no compactor because a lot of manual "pushing away" logic must be done to not have any overlap. Unless we could revert back to having vertical again. If it's very important that we have no compactor I can try to do some manual logic, otherwise the function works again as shown in the video, and it now only works while in edit mode. Although there is a small problem where when expanding a card that's positioned in the far-right, it will switch one position to the left when shrinking (I show this at the end of the video).
2026-04-23 15-45-43.mp4
37 MiB
b24johka commented 2026-04-27 12:20:53 +00:00
Collaborator
Copy link

Since we are not the team that removed vertical compactor i would like to have a discussion with the other team to see how important that feature is, i personally love the double click expansion feature.

Since we are not the team that removed vertical compactor i would like to have a discussion with the other team to see how important that feature is, i personally love the double click expansion feature.
a24timsv commented 2026-04-27 12:41:10 +00:00
Collaborator
Copy link

I think a meeting is for the best. I've seen it removed, added and rebranded. I think it is fine, if it would work as intended, but when I see people interacting with it, it seems to have weird side effects.

I remember a issue that when selecting the URL in the schedule view it would enlarge because when marking the url field in the View one would double click to select all. What I'm getting at is that it sometimes is in the way. I don't really know what a solution to that would be, but maybe it could only be possible to enlarge outside of edit mode? If we have a problem that it behaves weirdly on the right side of the page, maybe we could remember the position of when it is small and revert back to that? Maybe we could make the card take the entire page, kinda like a modal? How often do we think people would enlarge several cards?

I'm just spitballing here but it might be worth to take a step back and reevaluate what we need or want.

I think a meeting is for the best. I've seen it removed, added and rebranded. I think it is fine, if it would work as intended, but when I see people interacting with it, it seems to have weird side effects. I remember a issue that when selecting the URL in the schedule view it would enlarge because when marking the url field in the View one would double click to select all. What I'm getting at is that it sometimes is in the way. I don't really know what a solution to that would be, but maybe it could only be possible to enlarge outside of edit mode? If we have a problem that it behaves weirdly on the right side of the page, maybe we could remember the position of when it is small and revert back to that? Maybe we could make the card take the entire page, kinda like a modal? How often do we think people would enlarge several cards? I'm just spitballing here but it might be worth to take a step back and reevaluate what we need or want.
👍 1
a24vinla commented 2026-04-27 12:42:10 +00:00
Collaborator
Copy link

I believe that having no compactor is necessary, since the "dashboard" feeling is somewhat lost without it. If we find that we lose a lot of functionality because of this I think it would be fine adding vertical compacting, but not specifically and only to support this.

I believe that having no compactor is necessary, since the "dashboard" feeling is somewhat lost without it. If we find that we lose a lot of functionality because of this I think it would be fine adding vertical compacting, but not specifically and only to support this.
👍 1
a24vinla commented 2026-04-27 12:43:05 +00:00
Collaborator
Copy link

I 100% agree with Tim!

I 100% agree with Tim!
b24hugst commented 2026-04-27 13:04:32 +00:00
Collaborator
Copy link

I like the idea of a card taking up an entire page because I see this feature more as a simple quality-of-life tool used on the spot, rather than something for structuring cards. As the resizing function already handles that purpose much better.

I like the idea of a card taking up an entire page because I see this feature more as a simple quality-of-life tool used on the spot, rather than something for structuring cards. As the resizing function already handles that purpose much better.
👍 1
b24johka commented 2026-04-27 13:18:28 +00:00
Collaborator
Copy link

Very good points! if i have interpreted this discussion correctly i would say that we are leaning towards having a pause to this issue, right? We are also figuring out how to grid is going to dynamically change to be responsive towards mobile devices and i feel like that is more in the focus as for now.

Very good points! if i have interpreted this discussion correctly i would say that we are leaning towards having a pause to this issue, right? We are also figuring out how to grid is going to dynamically change to be responsive towards mobile devices and i feel like that is more in the focus as for now.
a24sakma commented 2026-05-05 12:33:04 +00:00
Collaborator
Copy link

I can't reproduce the error. I close this issue.

I can't reproduce the error. I close this issue.
Sign in to join this conversation.
#500-fix-card-enlargement
Branches Tags
Clear current reference
main
#1236-edit-mode-txt
#1229-generic-themed-buttons
Add-an-option-to-set-no-image-to-image-view-1227
#1242-prog-bar-colors-fix
#1239-Remove-Vertical-Scroll
Image-view-error-1230
Make-the-card-title-and-header-of-card-uniform-1233
both_teams_week_8
team_2_week_7
team_1_week_7
temp_branch_week_7
team_2_week_6
team_1_week_6
team_2_week_5
team_1_week_5
temp_branch_week_5
team_2_week_4
team_1_week_4
week_4_temp_branch
temp-branch-week-3
team_2_week_3
team_1_week_3
team_2_week_2
team_1_week_2
temp-week-2-merge-branch
team_2_week_1
team_1_week_1
Clear current reference
No results found.
Labels
Clear labels   
_CRITICAL_

Only use this label for critical tasks that are project-scope,and must be addressed ASAP.

  
API

   
app

   
backEnd

   
Blocked, waiting for further changes

   
bug

Something is not working

  
cleanup

Issues to cleanup the codebase (restructure folders, remove deprecated or smelly code)

  
close

Issue to close

  
design

   
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
feature request

   
frontEnd

   
help wanted

Need some help

  
invalid

Something is wrong

  
low priority

   
needs input

Issue needs input from product owner or customer

  
needs review

issue is in need of review

  
project documentation

   
question

More information is needed

  
research

   
reviewed

This Issue has been reviewed

  
script

   
security

use this for security-related issues

  
SQL

  
style

   
testing

   
topLevel

Reserved for top-level, project-wide issues.

  
wontfix

This won't be fixed

No labels
_CRITICAL_
API
app
backEnd
Blocked, waiting for further changes
bug
cleanup
close
design
duplicate
enhancement
feature request
frontEnd
help wanted
invalid
low priority
needs input
needs review
project documentation
question
research
reviewed
script
security
SQL
style
testing
topLevel
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
b24hugst
a24vinla
a24timsv
6 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Andras/BoundlessFlowCampus2K#500
No description provided.