Andras/BoundlessFlowCampus2K
3
6
Fork 0
Code Issues 143 Pull requests 14 Projects Releases Packages Wiki Activity Actions 2

#661-remove-header-phone #666

Merged
a22erigr merged 2 commits from #661-remove-header-zoomed-in-phone into team_2_week_4 2026-05-04 10:46:40 +00:00
Conversation 3 Commits 2 Files changed 1 +12 -1
j21marbr commented 2026-04-30 10:11:00 +00:00
Collaborator
Copy link

Changes:

  • Updated navbar for smaller screens by hiding the center logo and increasing the size of B icon.

Tested on:
Chrome (mobile view)

Changes: - Updated navbar for smaller screens by hiding the center logo and increasing the size of B icon. Tested on: Chrome (mobile view)
j21marbr commented 2026-04-30 10:16:24 +00:00
Author
Collaborator
Copy link
No description provided.
img__.png
72 KiB
img__.png
a24vinla commented 2026-04-30 10:24:14 +00:00
Collaborator
Copy link

We have a different fix for this on other weekly branch, show both solutions to customer

We have a different fix for this on other weekly branch, show both solutions to customer
c24carso commented 2026-04-30 10:43:59 +00:00
Collaborator
Copy link

Review on #661

Whats done

Tested on Windows using Firefox (device mode and normal)

  • Tested resizing the browser window
  • App starts
    • Center logo hides correctly
    • Icon increases in size on small screens

Inspected following files

  • Navbar.module.css
    • Indentation/code styling
      • Follows wiki standards
    • Naming convention
      • Follows wiki standards
    • Comments
      • Looks good
    • General code quality
      • Declarations in .logo are not alphabetically ordered
      • No other issues

What needs to be done

  • Navbar.module.css
    • Order declarations alphabetically in .logo (height before width)

Conclusion

  • Works as intended. One minor CSS fix needed.
# Review on #661 ## Whats done ### Tested on Windows using Firefox (device mode and normal) + Tested resizing the browser window + App starts + Center logo hides correctly + Icon increases in size on small screens ### Inspected following files + Navbar.module.css + Indentation/code styling + Follows wiki standards + Naming convention + Follows wiki standards + Comments + Looks good + General code quality + Declarations in .logo are not alphabetically ordered + No other issues ## What needs to be done + Navbar.module.css + Order declarations alphabetically in .logo (height before width) ## Conclusion + Works as intended. One minor CSS fix needed.
a22erigr merged commit dded8e4d63 into team_2_week_4 2026-05-04 10:46:40 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
c24carso
Labels
Clear labels   
_CRITICAL_

Only use this label for critical tasks that are project-scope,and must be addressed ASAP.

  
API

   
app

   
backEnd

   
Blocked-waiting-for-further-changes

   
bug

Something is not working

  
bug-only-on-server-for-mobile-not-webpage

   
Bug-Report-After-Merge

   
cleanup

Issues to cleanup the codebase (restructure folders, remove deprecated or smelly code)

  
close

Issue to close

  
design

   
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
feature request

   
frontEnd

   
further-changes-needed

   
future-problem-not-fixint-this-period

   
help wanted

Need some help

  
invalid

Something is wrong

  
last-week-issue-to-fix

   
library

   
low-priority

   
needs input

Issue needs input from product owner or customer

  
needs review

issue is in need of review

  
not-implemented.

   
project documentation

   
question

More information is needed

  
research

   
reviewed

This Issue has been reviewed

  
Script

   
security

use this for security-related issues

  
SQL

  
style

   
Team 1

Team 1 is responsible for this issue

  
Team 2

Team 2 is responsible for this issue

  
team leaders

   
test-creation

   
testing

   
topLevel

Reserved for top-level, project-wide issues.

  
unassigned

   
Under-review

   
wontfix

This won't be fixed

No labels
_CRITICAL_
API
app
backEnd
Blocked-waiting-for-further-changes
bug
bug-only-on-server-for-mobile-not-webpage
Bug-Report-After-Merge
cleanup
close
design
duplicate
enhancement
feature request
frontEnd
further-changes-needed
future-problem-not-fixint-this-period
help wanted
invalid
last-week-issue-to-fix
library
low-priority
needs input
needs review
not-implemented.
project documentation
question
research
reviewed
Script
security
SQL
style
Team 1
Team 2
team leaders
test-creation
testing
topLevel
unassigned
Under-review
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
j21marbr
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Andras/BoundlessFlowCampus2K!666
No description provided.