Andras/BoundlessFlowCampus2K
3
6
Fork 0
Code Issues 143 Pull requests 14 Projects Releases Packages Wiki Activity Actions 2

Logo changes from small/big depending on screen size. Works on mobile #683

Merged
b24johka merged 2 commits from #664-Logo-change-depending-on-device into team_1_week_4 2026-04-30 13:08:59 +00:00
Conversation 3 Commits 2 Files changed 5 +24 -27
e24aleli commented 2026-04-30 12:38:46 +00:00
Collaborator
Copy link

Changes

  • Resized the PNG for the logo with text due to taking up alot of unnecessary pixel space causing the navbar to get big.
  • Changed CSS so it correct hides one of the logo depending on screen size.
  • Moved both logos to the same div in navbar

Tested on

Iphone 16
Firefox

# Changes - - - - Resized the PNG for the logo with text due to taking up alot of unnecessary pixel space causing the navbar to get big. - Changed CSS so it correct hides one of the logo depending on screen size. - Moved both logos to the same div in navbar ## Tested on Iphone 16 Firefox
b24johka commented 2026-04-30 12:58:09 +00:00
Collaborator
Copy link

Review

Interaction

  • Looks really good on both desktop and phone
  • Transition at common breakpoint 768px

File changes

  • the SVG has been changed to a PNG, i think we should keep the SVG for now
# Review ## Interaction - Looks really good on both desktop and phone - Transition at common breakpoint 768px ## File changes - the SVG has been changed to a PNG, i think we should keep the SVG for now
b24johka commented 2026-04-30 13:02:50 +00:00
Collaborator
Copy link

For elaboration on the above review, keep the PNG for the navbar.. but dont delete the SVG file because it might be needed later

For elaboration on the above review, keep the PNG for the navbar.. but dont delete the SVG file because it might be needed later
b24johka merged commit aaa8356bc5 into team_1_week_4 2026-04-30 13:08:59 +00:00
e24aleli commented 2026-04-30 13:38:34 +00:00
Author
Collaborator
Copy link

Yea, i dont know what happened to the SVG! I had like 20 different version trying to find the right size didnt notice it was gone lol

Yea, i dont know what happened to the SVG! I had like 20 different version trying to find the right size didnt notice it was gone lol
👍 1
Sign in to join this conversation.
Reviewers
No reviewers
b24johka
Labels
Clear labels   
_CRITICAL_

Only use this label for critical tasks that are project-scope,and must be addressed ASAP.

  
API

   
app

   
backEnd

   
Blocked-waiting-for-further-changes

   
bug

Something is not working

  
bug-only-on-server-for-mobile-not-webpage

   
Bug-Report-After-Merge

   
cleanup

Issues to cleanup the codebase (restructure folders, remove deprecated or smelly code)

  
close

Issue to close

  
design

   
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
feature request

   
frontEnd

   
further-changes-needed

   
future-problem-not-fixint-this-period

   
help wanted

Need some help

  
invalid

Something is wrong

  
last-week-issue-to-fix

   
library

   
low-priority

   
needs input

Issue needs input from product owner or customer

  
needs review

issue is in need of review

  
not-implemented.

   
project documentation

   
question

More information is needed

  
research

   
reviewed

This Issue has been reviewed

  
Script

   
security

use this for security-related issues

  
SQL

  
style

   
Team 1

Team 1 is responsible for this issue

  
Team 2

Team 2 is responsible for this issue

  
team leaders

   
test-creation

   
testing

   
topLevel

Reserved for top-level, project-wide issues.

  
unassigned

   
Under-review

   
wontfix

This won't be fixed

No labels
_CRITICAL_
API
app
backEnd
Blocked-waiting-for-further-changes
bug
bug-only-on-server-for-mobile-not-webpage
Bug-Report-After-Merge
cleanup
close
design
duplicate
enhancement
feature request
frontEnd
further-changes-needed
future-problem-not-fixint-this-period
help wanted
invalid
last-week-issue-to-fix
library
low-priority
needs input
needs review
not-implemented.
project documentation
question
research
reviewed
Script
security
SQL
style
Team 1
Team 2
team leaders
test-creation
testing
topLevel
unassigned
Under-review
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Andras/BoundlessFlowCampus2K!683
No description provided.