create activity diagram for electricity

a24sakma commented

2026-05-04 10:44:19 +00:00

Collaborator

As part of the project documentation it will nice to have an activity diagram for electricity mockup

a24sakma added the

project documentation

label

2026-05-04 10:44:19 +00:00

a24sakma referenced this issue

2026-05-04 10:46:23 +00:00

Activity Diagrams #84

a24julot added the

help wanted

label

2026-05-04 12:32:56 +00:00

a24sakma was assigned by a24julot

2026-05-05 06:55:01 +00:00

a24sakma commented

2026-05-05 08:53:23 +00:00

Author

Collaborator

The diagram as png
what is left

review
adding the image in wiki

The diagram as png what is left 1. review 2. adding the image in wiki

activity-diagram-energy-data.drawio.png

69 KiB

a24sakma added

needs review

and removed

help wanted

labels

2026-05-05 08:53:40 +00:00

f21marfo commented

2026-05-05 09:56:03 +00:00

Collaborator

I've reviewed the diagram and considered it thorughly.

This diagram comes across as some kind of hybrid between an activity and sequence diagram, not a true activity diagram.

A sequence diagram is meant to illustrate how the user and different components/processes interact with each other, whereas an activity diagram is meant to illustrate the dynamic flow of activities from one into the next, like a flowchart. An activity diagram shoulve have a single initial/start node and generally a single final/end node., unless branching leads to different outcomes.

As it reads now, the implication is that the customers request to "Get Energy data", directly triggers backend activity and ends there without ever actually returning the data to the customer (neither of which holds true, in reality).

There is also no clear indication of activity flow as no decision and/or merge nodes exist, nor are there any fork and/or join nodes(if applicable) to indicate concurrent activites/execution. This makes the diagram as a whole extremely ambigous.

Example: "Get energy data" should not have multiple arrows flowing off it. A single arrow should flow to a decision node(diamond) and from there branch out to getTotalEnergy, getAllEnergy and getTotalForAllEnergy.

Recommendation: Decide on whether an activity diagram is actually suitable here or if a sequence diagram may be more apropriate, and rework the diagram accordingly.

Here's a link that quickly explains what sets the two diagram types apart.
https://www.geeksforgeeks.org/system-design/difference-between-sequence-diagram-and-activity-diagram/

It may also be helpful to review Chapter 5: System Modeling course material(slides, book) from Software Engineering.

I've reviewed the diagram and considered it thorughly. This diagram comes across as some kind of hybrid between an activity and sequence diagram, not a true activity diagram. A sequence diagram is meant to illustrate how the user and different components/processes interact with each other, whereas an activity diagram is meant to illustrate the dynamic flow of activities from one into the next, like a flowchart. An activity diagram shoulve have a single initial/start node and generally a single final/end node., unless branching leads to different outcomes. As it reads now, the implication is that the customers request to "Get Energy data", directly triggers backend activity and ends there without ever actually returning the data to the customer (neither of which holds true, in reality). There is also no clear indication of activity flow as no decision and/or merge nodes exist, nor are there any fork and/or join nodes(if applicable) to indicate concurrent activites/execution. This makes the diagram as a whole extremely ambigous. - Example: "Get energy data" should not have multiple arrows flowing off it. A single arrow should flow to a decision node(diamond) and from there branch out to getTotalEnergy, getAllEnergy and getTotalForAllEnergy. **Recommendation:** Decide on whether an activity diagram is actually suitable here or if a sequence diagram may be more apropriate, and rework the diagram accordingly. Here's a link that quickly explains what sets the two diagram types apart. https://www.geeksforgeeks.org/system-design/difference-between-sequence-diagram-and-activity-diagram/ It may also be helpful to review Chapter 5: System Modeling course material(slides, book) from Software Engineering.

f21marfo added

reviewed

and removed

needs review

labels

2026-05-05 09:56:15 +00:00

a24sakma commented

2026-05-05 10:07:13 +00:00

Author

Collaborator

Thanks for the review.

First of all the issue is about activity diagram we have already a sequence diagram for the services.
An activity diagram is high abstractions which means it indicates which activity is involved in the process rather than exact steps.

You are referering to a sequence diagram that shows exact back and fourth interaction which is not in this case relevant

Thanks for the review. 1. First of all the issue is about activity diagram we have already a sequence diagram for the services. 2. An activity diagram is high abstractions which means it indicates which activity is involved in the process rather than exact steps. You are referering to a sequence diagram that shows exact back and fourth interaction which is not in this case relevant

a24sakma commented

2026-05-05 11:47:57 +00:00

Author

Collaborator

THe diagram is added to wiki. I close this issue.

a24sakma closed this issue

2026-05-05 11:48:07 +00:00

f21marfo commented

2026-05-05 11:56:35 +00:00

Collaborator

I think there is a bit of miscommunication. I wasn't suggesting that it should back and forth interaction, but rather that it's not a clean activity diagram, and contains elements of both(IMHO), making it confusing to read. It's a diagram with an identity crisis. 😊

My comments and suggestions are based on the assumption that this was intended to be an activity diagram. The lack of nodes is a real problem, because it doesn't illustrate if activities are happening selectively or concurrently. I:E Is the customer choosing "one" of the three options, or do all of them happen concurrently?(likely not). This is something that an activity diagram should illustrate.

The multiple end nodes are also a problem, because they either are not reachable or alternatively are lacking a corresponding start node.

I think there is a bit of miscommunication. I wasn't suggesting that it should back and forth interaction, but rather that it's not a clean activity diagram, and contains elements of both(IMHO), making it confusing to read. It's a diagram with an identity crisis. 😊 My comments and suggestions are based on the assumption that this was intended to be an activity diagram. The lack of nodes is a real problem, because it doesn't illustrate if activities are happening selectively or concurrently. I:E Is the customer choosing "one" of the three options, or do all of them happen concurrently?(likely not). This is something that an activity diagram should illustrate. The multiple end nodes are also a problem, because they either are not reachable or alternatively are lacking a corresponding start node.

a24sakma commented

2026-05-05 12:03:33 +00:00

Author

Collaborator

The multiple nodes indicates that it is the end meaning the application is only accessible by the customer lane only. I used the standards that were available in draw.io which used in software engineering :) .

Rows
Columns

create activity diagram for electricity #699