Andras/BoundlessFlowCampus2K
3
6
Fork 0
Code Issues 143 Pull requests 14 Projects Releases Packages Wiki Activity Actions 2

#697-remove-mqtt-from-roombooking #711

Merged
a24julot merged 4 commits from #697-remove-mqtt-from-roombooking into team_1_week_4 2026-05-05 08:16:56 +00:00
Conversation 3 Commits 4 Files changed 4 +84 -162
a24antej commented 2026-05-04 12:58:32 +00:00
Collaborator
Copy link

changed the internal logic of the db handler to send sql queries instead of sending to the mqtt broker.
Have not moved all database logic to the db handler yet as i will already do it in another issue.

changed the internal logic of the db handler to send sql queries instead of sending to the mqtt broker. Have not moved all database logic to the db handler yet as i will already do it in another issue. 
changed the internal logic of the db handler to send sql queries instead of sending to the mqtt broker
a24antej changed title from converted from mqtt calls to sql calls to #697-remove-mqtt-from-roombooking 2026-05-04 12:59:19 +00:00
a24antej commented 2026-05-04 12:59:59 +00:00
Author
Collaborator
Copy link

related to #697

related to #697
b24hugst commented 2026-05-05 07:53:17 +00:00
Collaborator
Copy link

Review on #697

Whats done

Looked over code and ran branch.

Tested on Windows 11 using Chrome

  • App starts
    • Booking view outputs data

Inspected following files

  • Booking.cs
  • BookingDBHandler.cs
  • BookingGenerator.cs
  • Program.cs
    • Indentation/code styling is followed
    • Naming convention is followed, but a bit weird naming on these two, not a problem though:
      • image
      • image
    • Comments are good
    • General code quality is good

What needs to be done

Nothing

Conclusion

  • Looks correct and outputs data with no branch conflict so it's ready to merge.
# Review on #697 ## Whats done Looked over code and ran branch. ### Tested on Windows 11 using Chrome + App starts + Booking view outputs data ### Inspected following files + Booking.cs + BookingDBHandler.cs + BookingGenerator.cs + Program.cs + Indentation/code styling is followed + Naming convention is followed, but a bit weird naming on these two, not a problem though: + ![image](/attachments/19839e04-01f2-415d-bae8-89eb77416489) + ![image](/attachments/7d19dc7b-d0e0-4a8a-900a-8acc270dbf0b) + Comments are good + General code quality is good ## What needs to be done Nothing ## Conclusion + Looks correct and outputs data with no branch conflict so it's ready to merge.
image.png
2.5 KiB
image.png
2.5 KiB
a24julot requested changes 2026-05-05 07:55:30 +00:00
a24julot left a comment
Collaborator
Copy link

Check review.

Check review.
UpdatetData -> UpdateData
DeletetData -> DeleteData
a24julot merged commit 8e52d177bb into team_1_week_4 2026-05-05 08:16:56 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
b24hugst
a24julot
Labels
Clear labels   
_CRITICAL_

Only use this label for critical tasks that are project-scope,and must be addressed ASAP.

  
API

   
app

   
backEnd

   
Blocked-waiting-for-further-changes

   
bug

Something is not working

  
bug-only-on-server-for-mobile-not-webpage

   
Bug-Report-After-Merge

   
cleanup

Issues to cleanup the codebase (restructure folders, remove deprecated or smelly code)

  
close

Issue to close

  
design

   
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
feature request

   
frontEnd

   
further-changes-needed

   
future-problem-not-fixint-this-period

   
help wanted

Need some help

  
invalid

Something is wrong

  
last-week-issue-to-fix

   
library

   
low-priority

   
needs input

Issue needs input from product owner or customer

  
needs review

issue is in need of review

  
not-implemented.

   
project documentation

   
question

More information is needed

  
research

   
reviewed

This Issue has been reviewed

  
Script

   
security

use this for security-related issues

  
SQL

  
style

   
Team 1

Team 1 is responsible for this issue

  
Team 2

Team 2 is responsible for this issue

  
team leaders

   
test-creation

   
testing

   
topLevel

Reserved for top-level, project-wide issues.

  
unassigned

   
Under-review

   
wontfix

This won't be fixed

No labels
_CRITICAL_
API
app
backEnd
Blocked-waiting-for-further-changes
bug
bug-only-on-server-for-mobile-not-webpage
Bug-Report-After-Merge
cleanup
close
design
duplicate
enhancement
feature request
frontEnd
further-changes-needed
future-problem-not-fixint-this-period
help wanted
invalid
last-week-issue-to-fix
library
low-priority
needs input
needs review
not-implemented.
project documentation
question
research
reviewed
Script
security
SQL
style
Team 1
Team 2
team leaders
test-creation
testing
topLevel
unassigned
Under-review
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Andras/BoundlessFlowCampus2K!711
No description provided.