#723-clcok-view #744

Merged

a22erigr merged 2 commits from #723-clcok-view into team_2_week_4

2026-05-06 07:42:32 +00:00

c22abdal commented

2026-05-05 10:07:48 +00:00

Collaborator

Created a new Clock view that displays the current time, with a toggle to switch between 24 and 12 hour format. The view configs were added to the corresponding files as well as added as an option in the dashboard. The time text is responsive and scales with the card size. ![image](/attachments/ed75c841-1ad7-4933-82b1-d559d1c32c58) ![image](/attachments/1f656bc9-d206-4543-8809-66ef58fd33d4)

image.png

5.4 KiB

image.png

14 KiB

c22abdal added the

needs review

label

2026-05-05 10:07:48 +00:00

c22abdal added 2 commits

2026-05-05 10:07:48 +00:00

Created ClockView 97c752dec8

Update clock.module.css 7044f7ec75

c22abdal referenced this pull request

2026-05-05 10:09:24 +00:00

Make a clock view #723

a22erigr

2026-05-05 13:26:15 +00:00

added the
Team 2

Under-review
labels
requested review from a24timsv

a24timsv approved these changes

2026-05-06 07:40:37 +00:00

a24timsv left a comment

Collaborator

More options could be added, I might be old school but an analog clock could also be of interest. (We need concepts)
The colors are fine, the contrast is good enough for all the themes but as we talked about during Monday's seminar it might be a bit to much color. Not really this PR's problem, but just putting it down here.
The original issue doesn't feature any concepts of the customer to look at.
It's good that the clock ticks up on its own, but there is room for some animations, especially if other clocks are introduced.
Are the options for the current data desirable?
Lastly, the options (like the 12 vs 24 hour toggle) should not be visible outside of edit mode.

Please omit anything above (except the last one) if not desirable, they are mostly just suggestions/thought-starters.

The PR can be merged but the whole idea should be expanded upon.

Looks good. Good usage of already existing components (toggle button), and the inclusion of 12 to 24 hours selection. Overall it's a good base, and it can be merged as a base. But personally I would like to see some extensions on this. - More options could be added, I might be old school but an analog clock could also be of interest. (We need concepts) - The colors are fine, the contrast is good enough for all the themes but as we talked about during Monday's seminar it might be a bit to much color. Not really this PR's problem, but just putting it down here. - The original issue doesn't feature any concepts of the customer to look at. - It's good that the clock ticks up on its own, but there is room for some animations, especially if other clocks are introduced. - Are the options for the current data desirable? - Lastly, the options (like the 12 vs 24 hour toggle) should not be visible outside of edit mode. Please omit anything above (except the last one) if not desirable, they are mostly just suggestions/thought-starters. The PR can be merged but the whole idea should be expanded upon.

a22erigr merged commit 96c9e6f886 into team_2_week_4

2026-05-06 07:42:32 +00:00

a22erigr referenced this pull request from a commit

2026-05-06 07:42:34 +00:00

Merge pull request '#723-clcok-view' (#744) from #723-clcok-view into team_2_week_4