Andras/BoundlessFlowCampus2K

Fork 0

#709-unit-tests-for-layoutService #757

Merged

a22erigr merged 18 commits from #709-unit-tests-for-layoutService into team_2_week_4

2026-05-06 07:31:57 +00:00

c24elipe commented

2026-05-05 13:07:16 +00:00

Collaborator

Implementation of tests in layoutService

On what device?

This has been developed on an Arch-based Linux distro and tested using dotnet tests.

What has been done?

I removed "service/layoutService/layoutService/Models/Response/LayoutResponseList.cs" and "service/layoutService/layoutService.Test/UnitTest1.cs" since they weren't being used.
Restructured "service/layoutService/layoutService/Endpoints/LayoutEndpoints.cs" to be easier to test.
Created the file "service/layoutService/layoutService.Tests/Endpoints/LayoutEndpointsTests.cs". It contains tests for the endpoints. It could probably be broken out like the tests for LayoutService.
I created the folder "layoutService.Tests/Services/LayoutService". In it are 5 files, one per method in the "LayoutService" service. The general structure of the tests is first the happy path (when a good input is given and nothing throws an error), then a general "bad path" (where something goes wrong).

Issue:

#709

# Implementation of tests in layoutService ## On what device? This has been developed on an Arch-based Linux distro and tested using dotnet tests. ## What has been done? * I removed "**service/layoutService/layoutService/Models/Response/LayoutResponseList.cs**" and "**service/layoutService/layoutService.Test/UnitTest1.cs**" since they weren't being used. * Restructured "**service/layoutService/layoutService/Endpoints/LayoutEndpoints.cs**" to be easier to test. * Created the file "**service/layoutService/layoutService.Tests/Endpoints/LayoutEndpointsTests.cs**". It contains tests for the endpoints. It could probably be broken out like the tests for LayoutService. * I created the folder "**layoutService.Tests/Services/LayoutService**". In it are 5 files, one per method in the "LayoutService" service. The general structure of the tests is first the happy path (when a good input is given and nothing throws an error), then a general "bad path" (where something goes wrong). ## Issue: #709

c24elipe added the

needs review

label

2026-05-05 13:07:16 +00:00

c24elipe added 18 commits

2026-05-05 13:07:17 +00:00

Fixed reference error in test project file 65f8a8dac9

Changed argument DatabaseQueries name to databaseQueries 502a7a8000

Removed defult test and added Moq 473dec9ebf

Cleaned up the service file 43f07b11c2

Added cleanup to Endpoints... 845faa01e6

Sorry, meant to add it to the last commit xD

Added happy path fro LayoutService b610d5f9fd

Made LayoutEndpoints static for fun :) 7fe6b0d533

Added file for endpoint testing 12e3eb52ff

Added LayoutTest-test 6e8bab260f

Possible new endpoint file structure. df91c74ba0

Fixed formatting f44a512e0a

Created some maybe bad tests... db87e99e4c

Removed unused Modal d4b9e39f35

Added the tests b2b8c79d33

Added comments to follow Conventions fb938846d4

Fixed spelling mistake 3fc9a0fc70

Fixed some errors c3c4b0c847

Improved file names 52f06f9803

a22erigr added the

Team 2

label

2026-05-05 13:25:32 +00:00

a22erigr requested review from a24vinla

2026-05-06 06:39:37 +00:00

a24vinla added the

Under-review

label

2026-05-06 06:46:38 +00:00

a24vinla commented

2026-05-06 07:28:03 +00:00

Collaborator

Review on #709

Tested on Windows 11 using dot.net

App starts using rebuild script
- All 6 new tests ran

Inspected following files

service/layoutService/layoutService.Test/UnitTest1.cs (Removed)
- Valid reason for removal
service/layoutService/layoutService/Models/Response/LayoutResponseList.cs (Removed)
- Valid reason for removal
service/layoutService/layoutService/Endpoints/LayoutEndpoints.cs
- Indentation/code styling
  - Follows all standards set for C#
- Naming convention
  - Follows naming conventions and names are clear
- Comments
  - Well commented
- General code quality
  - Good Quality. Makes the code more readable and cleaner
service/layoutService/layoutService.Tests/Endpoints/LayoutEndpointsTests.cs
- Indentation/code styling
  - Follows all standards set for C#/testing
- Naming convention
  - Follows naming conventions and names are clear
- Comments
  - Well commented
- General code quality
  - Good Quality.
service/layoutService/layoutService.Tests/Services/LayoutService.tests/*
- All tests have the same structure/content (excepts paths/names) and will be reviewed together
- Indentation/code styling
  - Follows all standards set for C#/testing
- Naming convention
  - Follows naming conventions and names are clear
- Comments
  - Well commented
- General code quality
  - Good Quality.

What needs to be done

Nothing!

Conclusion

Good restructure of LayoutEndpoints.cs
I agree that the Endpoint tests could be broken out, but definitely not necessary.

# Review on #709 ### Tested on Windows 11 using dot.net + App starts using rebuild script + All 6 new tests ran ### Inspected following files + service/layoutService/layoutService.Test/UnitTest1.cs (Removed) + Valid reason for removal + service/layoutService/layoutService/Models/Response/LayoutResponseList.cs (Removed) + Valid reason for removal + service/layoutService/layoutService/Endpoints/LayoutEndpoints.cs + Indentation/code styling + Follows all standards set for C# + Naming convention + Follows naming conventions and names are clear + Comments + Well commented + General code quality + Good Quality. Makes the code more readable and cleaner + service/layoutService/layoutService.Tests/Endpoints/LayoutEndpointsTests.cs + Indentation/code styling + Follows all standards set for C#/testing + Naming convention + Follows naming conventions and names are clear + Comments + Well commented + General code quality + Good Quality. + service/layoutService/layoutService.Tests/Services/LayoutService.tests/* + All tests have the same structure/content (excepts paths/names) and will be reviewed together + Indentation/code styling + Follows all standards set for C#/testing + Naming convention + Follows naming conventions and names are clear + Comments + Well commented + General code quality + Good Quality. ## What needs to be done + Nothing! ## Conclusion + Good restructure of LayoutEndpoints.cs + I agree that the Endpoint tests could be broken out, but definitely not necessary.

a24vinla added

reviewed

and removed

needs review

Under-review

labels

2026-05-06 07:28:30 +00:00

a24vinla approved these changes

2026-05-06 07:28:44 +00:00

a22erigr merged commit 7d1b5830bf into team_2_week_4

2026-05-06 07:31:57 +00:00

a22erigr referenced this pull request from a commit