Andras/BoundlessFlowCampus2K
3
6
Fork 0
Code Issues 143 Pull requests 14 Projects Releases Packages Wiki Activity Actions 2

#733 Fix SMHIForecastView design and bug #758

Merged
a22erigr merged 1 commit from #733-smhi-forecast-design into team_2_week_4 2026-05-05 14:56:16 +00:00
Conversation 1 Commits 1 Files changed 2 +7 -7
c24carso commented 2026-05-05 13:16:22 +00:00
Collaborator
Copy link

Days now start as collapsed instead of expanded. Changed Swedish to English.
Before
Screenshot 2026-05-05 151358 Screenshot 2026-05-05 151409
After
Screenshot 2026-05-05 150225 Screenshot 2026-05-05 150243

Days now start as collapsed instead of expanded. Changed Swedish to English. Before ![Screenshot 2026-05-05 151358](/attachments/bffc2c31-cd6d-48af-966e-d650cb3553ae) ![Screenshot 2026-05-05 151409](/attachments/2fac2c5c-507e-4a8c-87dd-3cc32f970644) After ![Screenshot 2026-05-05 150225](/attachments/70921de7-8766-4d88-b626-2a32861582c7) ![Screenshot 2026-05-05 150243](/attachments/97e6b29a-1d5c-4933-a49c-42f2f30ad00d)
Screenshot 2026-05-05 150225.png
28 KiB
Screenshot 2026-05-05 150243.png
32 KiB
Screenshot 2026-05-05 151358.png
30 KiB
Screenshot 2026-05-05 151409.png
27 KiB 
Days now start collapsed instead of expanded. Changed Swedish to English.
a22erigr 2026-05-05 13:25:25 +00:00
b24idalu approved these changes 2026-05-05 14:44:48 +00:00
b24idalu left a comment
Collaborator
Copy link

Review on #[Number of issue reviewed]

Whats done

  • Make timestamps collapsed instead of expanded at start
  • Change swedish to english
  • Space out columns
  • Change typo SE --> SE

Tested on Windows using Chrome

  • Intended features are added.
  • App starts
    • Intended features are added and working, fields are collapsed at start, time/dates are correct, spacing has been applied.
    • Tested expanding the card, it worked and columns still apply
    • If page is reloaded while date is expanded, it will return to collapsed state.

Inspected following files [IMPORTANT!, Don't forget to inspect for unapproved dependencies in package.json ]

  • features/smhi/SMHIForecastView.js & SMHIForecastView.module.css
    • Indentation/code styling
      • Follows prettier, looks good.
    • Naming convention
      • No naming conventions has been changed.
    • Comments
      • Since the changes are small changes like language, no comments are needed.
    • General code quality
      • Looks good.

What needs to be done

  • Nothing, looks good.

Conclusion

  • The green text color that says "Forcast created" becomes unclear with some styles, for example emerald. Could be worth changing
  • If page is reloaded while date is expanded, it will return to collapsed state. Could be something to add, so that it stays expanded.
  • Otherwise looks good and ready to merge!
# Review on #[Number of issue reviewed] ## Whats done - Make timestamps collapsed instead of expanded at start - Change swedish to english - Space out columns - Change typo SE --> SE ### Tested on Windows using Chrome + Intended features are added. + App starts + Intended features are added and working, fields are collapsed at start, time/dates are correct, spacing has been applied. + Tested expanding the card, it worked and columns still apply + If page is reloaded while date is expanded, it will return to collapsed state. ### Inspected following files [IMPORTANT!, Don't forget to inspect for unapproved dependencies in **package.json** ] + features/smhi/SMHIForecastView.js & SMHIForecastView.module.css + Indentation/code styling + Follows prettier, looks good. + Naming convention + No naming conventions has been changed. + Comments + Since the changes are small changes like language, no comments are needed. + General code quality + Looks good. ## What needs to be done + Nothing, looks good. ## Conclusion + The green text color that says "Forcast created" becomes unclear with some styles, for example emerald. Could be worth changing + If page is reloaded while date is expanded, it will return to collapsed state. Could be something to add, so that it stays expanded. + Otherwise looks good and ready to merge!
a22erigr merged commit 3d49478055 into team_2_week_4 2026-05-05 14:56:16 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
b24idalu
Labels
Clear labels   
_CRITICAL_

Only use this label for critical tasks that are project-scope,and must be addressed ASAP.

  
API

   
app

   
backEnd

   
Blocked-waiting-for-further-changes

   
bug

Something is not working

  
bug-only-on-server-for-mobile-not-webpage

   
Bug-Report-After-Merge

   
cleanup

Issues to cleanup the codebase (restructure folders, remove deprecated or smelly code)

  
close

Issue to close

  
design

   
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
feature request

   
frontEnd

   
further-changes-needed

   
future-problem-not-fixint-this-period

   
help wanted

Need some help

  
invalid

Something is wrong

  
last-week-issue-to-fix

   
library

   
low-priority

   
needs input

Issue needs input from product owner or customer

  
needs review

issue is in need of review

  
not-implemented.

   
project documentation

   
question

More information is needed

  
research

   
reviewed

This Issue has been reviewed

  
Script

   
security

use this for security-related issues

  
SQL

  
style

   
Team 1

Team 1 is responsible for this issue

  
Team 2

Team 2 is responsible for this issue

  
team leaders

   
test-creation

   
testing

   
topLevel

Reserved for top-level, project-wide issues.

  
unassigned

   
Under-review

   
wontfix

This won't be fixed

No labels
_CRITICAL_
API
app
backEnd
Blocked-waiting-for-further-changes
bug
bug-only-on-server-for-mobile-not-webpage
Bug-Report-After-Merge
cleanup
close
design
duplicate
enhancement
feature request
frontEnd
further-changes-needed
future-problem-not-fixint-this-period
help wanted
invalid
last-week-issue-to-fix
library
low-priority
needs input
needs review
not-implemented.
project documentation
question
research
reviewed
Script
security
SQL
style
Team 1
Team 2
team leaders
test-creation
testing
topLevel
unassigned
Under-review
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Andras/BoundlessFlowCampus2K!758
No description provided.