#769-add-energy-view #773

Merged
a24julot merged 2 commits from #769-add-energy-view into team_1_week_5 2026-05-06 11:15:19 +00:00
Collaborator

Now energyView can be added without errors.

Now energyView can be added without errors.
Some code was nestled, seperated clock, energy and energyall.
Added comment
a24julot 2026-05-06 10:57:03 +00:00
Collaborator

Review on #769

Whats done

Tested on Windows 11 using Chrome

  • App starts
    • works well, was a small chage
    • Tested the effected views, both energy views and clock which works well

Inspected following files [IMPORTANT!, Don't forget to inspect for unapproved dependencies in package.json ]

  • frontend/src/configs/tooltipConfig.js
    • Indentation/code styling [does it follow prettier]
      • ok
    • Naming convention
      • ok
    • Comments
      • no need for comments as the code is understandeble
    • General code quality
      • ok

Conclusion

  • Ready for merge
# Review on #769 ## Whats done ### Tested on Windows 11 using Chrome + App starts + works well, was a small chage + Tested the effected views, both energy views and clock which works well ### Inspected following files [IMPORTANT!, Don't forget to inspect for unapproved dependencies in **package.json** ] + frontend/src/configs/tooltipConfig.js + Indentation/code styling [does it follow prettier] + ok + Naming convention + ok + Comments + no need for comments as the code is understandeble + General code quality + ok ## Conclusion + Ready for merge
c24danli approved these changes 2026-05-06 11:12:45 +00:00
a24julot merged commit b7acfec68e into team_1_week_5 2026-05-06 11:15:19 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Andras/BoundlessFlowCampus2K!773
No description provided.