643-Create-titles-for-all-cards #795

Merged

a22erigr merged 1 commit from 643-Create-titles-for-all-cards into team_2_week_5

2026-05-07 09:31:33 +00:00

a24vinla commented

2026-05-07 07:15:35 +00:00

Collaborator

On what device?

Windows 11 and Chrome v. 147

What has been done?

Added title field to view object in /frontend/src/pages/dashboard/dashboard.js, based on comments in issue #643 by @b24krila
Also changed structure of view object to be easier to read

Changed from view.value to view.title in /frontend/src/features/addCardModal/addCardModal.js

Issue:

#643

Other Comments

In issue #643 I wrote some thoughts about how we might change want to break out view configs

# Adding titles to cards and adding them to Add Card Modal ## On what device? Windows 11 and Chrome v. 147 ## What has been done? Added title field to view object in /frontend/src/pages/dashboard/dashboard.js, based on comments in issue #643 by @b24krila Also changed structure of view object to be easier to read Changed from view.value to view.title in /frontend/src/features/addCardModal/addCardModal.js ## Issue: #643 ## Other Comments In issue #643 I wrote some thoughts about how we might change want to break out view configs

a24vinla added the

needs review

label

2026-05-07 07:15:35 +00:00

a24vinla added 1 commit

2026-05-07 07:15:36 +00:00

Add Titles to views and to add card modal 467f2a4445

Based on b24krila's comments in issue #643, as well as some of my own thoughts

a22erigr requested review from c24carso

2026-05-07 07:41:57 +00:00

c24carso commented

2026-05-07 08:38:58 +00:00

Collaborator

Review on #643

Whats done

Tested on Windows using Firefox

App starts
- Add Card modal shows titles instead of view names
- Adding cards from the modal works as expected

Inspected following files

package.json
- No new dependencies
Dashboard.js
- Indentation/code styling
  - Follows prettier
- Naming convention
  - Follows wiki standards
- Comments
  - Existing comments still present
- General code quality
  - Looks good
AddCardModal.js
- Indentation/code styling
  - Follows prettier
- Naming convention
  - Follows wiki standards
- Comments
  - No changes needed
- General code quality
  - Change from view.value to view.title is clean

What needs to be done

Nothing

Conclusion

Works as intended, ready for merge.

# Review on #643 ## Whats done ### Tested on Windows using Firefox + App starts + Add Card modal shows titles instead of view names + Adding cards from the modal works as expected ### Inspected following files + package.json + No new dependencies + Dashboard.js + Indentation/code styling + Follows prettier + Naming convention + Follows wiki standards + Comments + Existing comments still present + General code quality + Looks good + AddCardModal.js + Indentation/code styling + Follows prettier + Naming convention + Follows wiki standards + Comments + No changes needed + General code quality + Change from view.value to view.title is clean ## What needs to be done + Nothing ## Conclusion + Works as intended, ready for merge.