#787 Updated tempSensorMockup unit tests #801

Merged

a24julot merged 1 commit from #787-tempSesnorMockupTests-outdated-unit-tests into team_1_week_5

2026-05-08 09:13:15 +00:00

f21marfo commented

2026-05-07 08:23:26 +00:00

Collaborator

Updated:

Updated TagsCorrect test to account for the new properties: id and sql_datatypes.
Updated sensorIdValueIsValid test with a new regex pattern.

Added:

Added proper XML descriptions to all methods.
New unit test to validate the sql_datatypes property.

Updated: - Updated TagsCorrect test to account for the new properties: id and sql_datatypes. - Updated sensorIdValueIsValid test with a new regex pattern. Added: - Added proper XML descriptions to all methods. - New unit test to validate the sql_datatypes property.

f21marfo added the

testing

backEnd

needs review

labels

2026-05-07 08:23:26 +00:00

f21marfo added 1 commit

2026-05-07 08:23:27 +00:00

Updated tempSensorMockup unit tests 1d4ee785d5

Updated:
- Updated TagsCorrect test to account for the new properties: id and sql_datatypes.
- Updated sensorIdValueIsValid test with a new regex pattern.

Added:
- Added proper XML descriptions to all methods.
- New unit test to validate the sql_datatypes property.

a22erigr referenced this pull request

2026-05-07 10:28:54 +00:00

tempSensorMockup.Tests xUnit tests are out-of-date and and fail. This should #787

a24julot

2026-05-07 13:24:49 +00:00

added
Under-review
and removed
needs review
labels
requested review from b24hugst

b24hugst commented

2026-05-07 14:16:41 +00:00

Collaborator

Review on #787

Whats done

Checked code and executed the test file

Tested on Windows 11 using Chrome

App starts
- Nothing broke
Test is runnable and gives output

Inspected following files

JsonData.test.cs
- Indentation/code styling is correct
- Naming convention is correct
- Comments are very good
- General code quality is very good

What needs to be done

Nothing

Conclusion

Everything looks good so it's ready to be merged.

# Review on #787 ## Whats done Checked code and executed the test file ### Tested on Windows 11 using Chrome + App starts + Nothing broke + Test is runnable and gives output + ![image](/attachments/4d6825d0-1141-4314-bc0e-29f764b94aa5) ### Inspected following files + JsonData.test.cs + Indentation/code styling is correct + Naming convention is correct + Comments are very good + General code quality is very good ## What needs to be done Nothing ## Conclusion + Everything looks good so it's ready to be merged.

image.png

36 KiB