#659 Make grid cells square #823

Merged

a22erigr merged 1 commit from #659-grid-cell-dimensions into team_2_week_5

2026-05-08 07:57:28 +00:00

c24carso commented

2026-05-07 16:38:47 +00:00

Collaborator

Make grid cells square at all zoom levels

c24carso added the

needs review

label

2026-05-07 16:38:47 +00:00

c24carso added 1 commit

2026-05-07 16:38:48 +00:00

#659 Make grid cells square 2e400d688f

Make grid cells square at all zoom levels

c24carso referenced this pull request

2026-05-07 16:39:06 +00:00

Grid cells should have the same dimensions when zooming in/out #659

a22erigr

2026-05-08 07:27:03 +00:00

added the
Under-review
label
requested review from b25marem

b25marem commented

2026-05-08 07:42:05 +00:00

Collaborator

Review on #659

Whats done

Tested on Windows using Chrome

Tested zooming in and out on the dashboard grid
Verified that grid cells keep a more square shape across different zoom levels
App starts
- No layout issues noticed during testing
- Tested different screen sizes and browser zoom levels

Inspected following files

frontend/src/pages/dashboard/Dashboard.js
- Indentation/code styling
  - Indentation and formatting follow the project style
- Naming convention
  - Naming convention follows the project standard
- Comments
  - No issues found. The implementation is simple and readable without requiring additional comments
- General code quality
  - The dynamic row height calculation simplifies the previous hardcoded rowHeight values
  - Logic is cleaner and easier to maintain

What needs to be done

No issues found during review

Conclusion

The implementation works as intended and improves grid consistency during zooming
Code quality looks good and the PR is ready to merge

# Review on #659 ## Whats done ### Tested on Windows using Chrome * Tested zooming in and out on the dashboard grid * Verified that grid cells keep a more square shape across different zoom levels * App starts * No layout issues noticed during testing * Tested different screen sizes and browser zoom levels ### Inspected following files * frontend/src/pages/dashboard/Dashboard.js * Indentation/code styling * Indentation and formatting follow the project style * Naming convention * Naming convention follows the project standard * Comments * No issues found. The implementation is simple and readable without requiring additional comments * General code quality * The dynamic row height calculation simplifies the previous hardcoded rowHeight values * Logic is cleaner and easier to maintain ## What needs to be done * No issues found during review ## Conclusion * The implementation works as intended and improves grid consistency during zooming * Code quality looks good and the PR is ready to merge

image.png

21 KiB