Themes refactor Examples and research #829
Labels
No labels
_CRITICAL_
API
app
backEnd
Blocked, waiting for further changes
bug
cleanup
close
design
duplicate
enhancement
feature request
frontEnd
help wanted
invalid
low priority
needs input
needs review
project documentation
question
research
reviewed
script
security
SQL
style
testing
topLevel
wontfix
No milestone
No project
No assignees
3 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
Andras/BoundlessFlowCampus2K#829
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
In preperation for refactoring the theme, we have this issue as research and to test diffrent implimentations
I have made an example on this branch.
Here are the things I think we need to do:
1. Refactor the theme.css file.
It has never had a clear purpose, and thus there is a lot of random stuff in it. The root class should preferably contain things that are static across all themes. In the example branch. I've gone quite far with adding things that could be the same if we want a uniform website. The bare minimum I think are variables for neutral backgrounds, variables for text colors and the typography.
The only things that would change with the themes are the variables for primary and secondary color, and things like their hover colors.
Since the old variables are frequently used, almost all of the components' css would need to be somewhat changed.
2. Have a concrete guide for how primary and secondary colors are to be used.
We need to decide what component/type of components should use primary and secondary color, as well as whatever variables end up in the root class.
We should also decide what the secondary color is. In the examples @a22erigr sent, there is no clear secondary color. If we want to have maximum contrast, the secondary should be a complementary color to the first one. However, I think this looks bad in a lot of cases. In the test branch, I've just used hues of the primary colors as secondary.
Conclusion
The example branch is quite ambitious, and I do not think we necessarily have to go that far. I think the bare minimum is:
A decition about this has been made. There by the issue can be closed