Andras/BoundlessFlowCampus2K
4
7
Fork 0
Code Issues 90 Pull requests 7 Projects Releases Packages Wiki Activity Actions

#861 First batch of localizations. #914

Merged
a22erigr merged 5 commits from #861-Localization-change-all-printed-text into team_2_week_5 2026-05-12 11:32:08 +00:00
Conversation 8 Commits 5 Files changed 10 +341 -110
f21marfo commented 2026-05-12 10:19:48 +00:00
Collaborator
Copy link

Here comes the first major pull-request for site-wide localization.

Localized pages:

  • Settings
  • About
  • Legal
  • Support
  • Dashboard

Localized components & features.

  • Add Card Modal
  • Danger Modal

Notes:

  • The locales JSON files contain no comments because the format does not support them.
  • No design, structural changes or reorganization has been made as this work has focused exclusively on 1:1 replacement of text with the translate() function and their corresponding dictionary keys.
  • the views[] array in Dashboard.js was updated to contain locales key-references directly, as it is not possible to assign the values to a constant, using the translate() function call. As such the AddCardModal itself calls the translate() function-call and uses the array category and title variables as keys.
  • Requires THOROUGH testing!
Here comes the first major pull-request for site-wide localization. **Localized pages:** - Settings - About - Legal - Support - Dashboard **Localized components & features.** - Add Card Modal - Danger Modal **Notes:** - The locales JSON files contain no comments because the format does not support them. - No design, structural changes or reorganization has been made as this work has focused exclusively on 1:1 replacement of text with the translate() function and their corresponding dictionary keys. - the views[] array in Dashboard.js was updated to contain locales key-references directly, as it is not possible to assign the values to a constant, using the translate() function call. As such the AddCardModal itself calls the translate() function-call and uses the array category and title variables as keys. - Requires THOROUGH testing!
- Updated Settings.js to accept localization.
- Updated the localization files with new key-string pairs for the settings page.
- Replaced all titles and descriptors on the settings page with the new translate function.
- Finished localizing UI buttons on settings page.
- Localized the "about us" page.
- Fully localized the Support page.
- Added localization to the Dashboard.
- Added localization to the Add Card Modal.
- Added localization to the Danger Modal.
- Added localization to the legal page.
c24danli 2026-05-12 10:44:22 +00:00
a24vinla reviewed 2026-05-12 10:51:31 +00:00
frontend/src/locales/en.json Outdated
@ -3,0 +43,4 @@
"support.UI.go": "Go",
"about.title": "About us",
"about.content": "BoundlessFlowCampus2K is a digital twin campus sensor monitoring system built by us students at Högskolan i Skövde.",
a24vinla commented 2026-05-12 10:51:31 +00:00
Collaborator
Copy link

Maybe it should be University of Skövde, as that is the English name?

Maybe it should be University of Skövde, as that is the English name?
f21marfo commented 2026-05-12 11:01:05 +00:00
Author
Collaborator
Copy link

You're probably right, i just copy and pasted/transcribed the original text strings, as they were. It's what we have on the server now. http://193.93.250.90/app/about

You're probably right, i just copy and pasted/transcribed the original text strings, as they were. It's what we have on the server now. http://193.93.250.90/app/about
a24vinla reviewed 2026-05-12 10:53:51 +00:00
frontend/src/locales/sv.json Outdated
@ -3,0 +6,4 @@
"settings.account.password": "Lösenord",
"settings.preferences.preferencesTitle": "Preferenser",
"settings.preferences.language": "Språk",
"settings.preferences.notifications": "Avisering",
a24vinla commented 2026-05-12 10:53:51 +00:00
Collaborator
Copy link

Should be Aviseringar

Should be Aviseringar
a24vinla reviewed 2026-05-12 10:56:10 +00:00
frontend/src/locales/sv.json Outdated
@ -3,0 +33,4 @@
"support.contact.title": "Kontakta Support",
"support.contact.email": "Skicka e-post till Support",
"support.contact.report": "Rapportera ett problem",
"support.contact.featureRequest": "Begär en funktion",
a24vinla commented 2026-05-12 10:56:10 +00:00
Collaborator
Copy link

Should maybe be less forceful language, like efterfråga, fråga? Not very important

Should maybe be less forceful language, like efterfråga, fråga? Not very important
a24vinla reviewed 2026-05-12 10:57:20 +00:00
frontend/src/locales/sv.json Outdated
@ -3,0 +58,4 @@
"addCardModal.title": "Nytt Kort",
"addCardModal.preview": "Förhandsgranskning",
"addCardModal.noViewError": "Ingen vald vy",
a24vinla commented 2026-05-12 10:57:20 +00:00
Collaborator
Copy link

Should this maybe be "Ingen vy vald"?

Should this maybe be "Ingen vy vald"?
a24vinla reviewed 2026-05-12 10:58:19 +00:00
frontend/src/locales/sv.json Outdated
@ -3,0 +90,4 @@
"UI.change": "Ändra",
"UI.delete": "Ta bort",
"UI.manage": "Hantera",
"UI.setup": "konfigurera",
a24vinla commented 2026-05-12 10:58:19 +00:00
Collaborator
Copy link

Capitalize "k"

Capitalize "k"
a24vinla commented 2026-05-12 11:07:33 +00:00
Collaborator
Copy link

Review on #861

Tested on Windows 11 using Chrome

  • App starts!

Inspected following files

  • frontend/src/locales/en.json
    • Line 46: Maybe it should be University of Skövde, as that is the English name?
    • Everything else looks good!
  • frontend/src/locales/sv.json
    • Line 9: Since the English translation is notifications this should be Aviseringar
    • Line 35: Maybe something less forceful than "begär"? This works as is
    • Line 61: Should probably be "Ingen vy vald"
    • Line 93: Capitalize the letter "k"
    • Everything else looks good!
  • frontend/src/pages/dashboard/Dashboard.js
    • Changes to views const all look correct
  • All other files
    • Since all other files only contain the implementation of localization I will keep it short: looks good!

What needs to be done

Small changes to localization files. If any of my proposed changes seem wrong to you, feel free to stick to original translations.

Conclusion

  • Well done!
# Review on #861 ### Tested on Windows 11 using Chrome + App starts! ### Inspected following files + frontend/src/locales/en.json + Line 46: Maybe it should be University of Skövde, as that is the English name? + Everything else looks good! + frontend/src/locales/sv.json + Line 9: Since the English translation is notifications this should be Aviseringar + Line 35: Maybe something less forceful than "begär"? This works as is + Line 61: Should probably be "Ingen vy vald" + Line 93: Capitalize the letter "k" + Everything else looks good! + frontend/src/pages/dashboard/Dashboard.js + Changes to views const all look correct + All other files + Since all other files only contain the implementation of localization I will keep it short: looks good! ## What needs to be done Small changes to localization files. If any of my proposed changes seem wrong to you, feel free to stick to original translations. ## Conclusion + Well done!
Made changes locales strings based on feedback.
f21marfo commented 2026-05-12 11:23:58 +00:00
Author
Collaborator
Copy link

Updated localization files based on review feedback.

Updated localization files based on review feedback.
a22erigr commented 2026-05-12 11:32:00 +00:00
Collaborator
Copy link

Have looked at
Text changes 108e59e05b

Have looked at Text changes 108e59e05b
a22erigr merged commit 2ef537f28b into team_2_week_5 2026-05-12 11:32:08 +00:00
c24danli deleted branch #861-Localization-change-all-printed-text 2026-05-21 12:53:14 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
a24vinla
Labels
Clear labels   
_CRITICAL_

Only use this label for critical tasks that are project-scope,and must be addressed ASAP.

  
API

   
app

   
backEnd

   
Blocked, waiting for further changes

   
bug

Something is not working

  
cleanup

Issues to cleanup the codebase (restructure folders, remove deprecated or smelly code)

  
close

Issue to close

  
design

   
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
feature request

   
frontEnd

   
help wanted

Need some help

  
invalid

Something is wrong

  
low priority

   
needs input

Issue needs input from product owner or customer

  
needs review

issue is in need of review

  
project documentation

   
question

More information is needed

  
research

   
reviewed

This Issue has been reviewed

  
script

   
security

use this for security-related issues

  
SQL

  
style

   
testing

   
topLevel

Reserved for top-level, project-wide issues.

  
wontfix

This won't be fixed

No labels
_CRITICAL_
API
app
backEnd
Blocked, waiting for further changes
bug
cleanup
close
design
duplicate
enhancement
feature request
frontEnd
help wanted
invalid
low priority
needs input
needs review
project documentation
question
research
reviewed
script
security
SQL
style
testing
topLevel
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Andras/BoundlessFlowCampus2K!914
No description provided.