Andras/BoundlessFlowCampus2K
3
6
Fork 0
Code Issues 143 Pull requests 14 Projects Releases Packages Wiki Activity Actions 2

Remove-sudo-from-MD-installation-#877 #917

Merged
a24julot merged 3 commits from Remove-sudo-from-MD-installation-#877 into team_1_week_5 2026-05-12 13:20:28 +00:00
Conversation 4 Commits 3 Files changed 1 +4 -1
b24johka commented 2026-05-12 11:03:34 +00:00
Collaborator
Copy link

The usage of sudo in the installation made the NPM (node modules) to not have the suitable privileges to create directories.

The usage of sudo in the installation made the NPM (node modules) to not have the suitable privileges to create directories.
The usage of sudo in the installation made the NPM (node modules) to not have the suitable privileges to create directories.
b24johka commented 2026-05-12 11:05:54 +00:00
Author
Collaborator
Copy link

This is the parent to this issue: #791

This is the parent to this issue: https://git.webug.se/Andras/BoundlessFlowCampus2K/issues/791
a22erigr 2026-05-12 11:28:21 +00:00
b24idalu requested changes 2026-05-12 13:09:46 +00:00
Dismissed
b24idalu left a comment
Collaborator
Copy link

Review on #877

Whats done

Removed sudo from MD installation

Inspected following files

  • scripts/README.md
    • Indentation/code styling
      • No changes made, looks good.
    • Naming convention
      • No changes made, looks good.
    • Comments
      • No changes made, looks good.
    • General code quality
      • No changes made, looks good.

What needs to be done

  • scripts/README.md
    • In the parent issue, there was another suggestion about documenting the problem in the readme which might be good to add.

Conclusion

  • Solution is good, could just add a comment about the error sudo can give if not used everywhere.
# Review on #877 ## Whats done Removed sudo from MD installation ### Inspected following files + scripts/README.md + Indentation/code styling + No changes made, looks good. + Naming convention + No changes made, looks good. + Comments + No changes made, looks good. + General code quality + No changes made, looks good. ## What needs to be done + scripts/README.md + In the parent issue, there was another suggestion about documenting the problem in the readme which might be good to add. ## Conclusion + Solution is good, could just add a comment about the error sudo can give if not used everywhere.
👍 1
b24johka commented 2026-05-12 13:14:40 +00:00
Author
Collaborator
Copy link

Really good note! i will do that change right away.

Really good note! i will do that change right away.
Added comment explaining the change
b24idalu approved these changes 2026-05-12 13:18:08 +00:00
b24idalu left a comment
Collaborator
Copy link

Looks ready for merge!

Looks ready for merge!
👍 1
a24julot merged commit 2ea5bc8965 into team_1_week_5 2026-05-12 13:20:28 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
b24idalu
Labels
Clear labels   
_CRITICAL_

Only use this label for critical tasks that are project-scope,and must be addressed ASAP.

  
API

   
app

   
backEnd

   
Blocked-waiting-for-further-changes

   
bug

Something is not working

  
bug-only-on-server-for-mobile-not-webpage

   
Bug-Report-After-Merge

   
cleanup

Issues to cleanup the codebase (restructure folders, remove deprecated or smelly code)

  
close

Issue to close

  
design

   
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
feature request

   
frontEnd

   
further-changes-needed

   
future-problem-not-fixint-this-period

   
help wanted

Need some help

  
invalid

Something is wrong

  
last-week-issue-to-fix

   
library

   
low-priority

   
needs input

Issue needs input from product owner or customer

  
needs review

issue is in need of review

  
not-implemented.

   
project documentation

   
question

More information is needed

  
research

   
reviewed

This Issue has been reviewed

  
Script

   
security

use this for security-related issues

  
SQL

  
style

   
Team 1

Team 1 is responsible for this issue

  
Team 2

Team 2 is responsible for this issue

  
team leaders

   
test-creation

   
testing

   
topLevel

Reserved for top-level, project-wide issues.

  
unassigned

   
Under-review

   
wontfix

This won't be fixed

No labels
_CRITICAL_
API
app
backEnd
Blocked-waiting-for-further-changes
bug
bug-only-on-server-for-mobile-not-webpage
Bug-Report-After-Merge
cleanup
close
design
duplicate
enhancement
feature request
frontEnd
further-changes-needed
future-problem-not-fixint-this-period
help wanted
invalid
last-week-issue-to-fix
library
low-priority
needs input
needs review
not-implemented.
project documentation
question
research
reviewed
Script
security
SQL
style
Team 1
Team 2
team leaders
test-creation
testing
topLevel
unassigned
Under-review
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Andras/BoundlessFlowCampus2K!917
No description provided.