Andras/BoundlessFlowCampus2K
3
6
Fork 0
Code Issues 143 Pull requests 14 Projects Releases Packages Wiki Activity Actions 2

#921 Add login/logout to settings #930

Merged
a22erigr merged 4 commits from #921-login-logout-in-settings into team_2_week_5 2026-05-13 08:00:28 +00:00
Conversation 2 Commits 4 Files changed 5 +85
b24idalu commented 2026-05-12 17:10:58 +00:00
Collaborator
Copy link

Regarding issue #921: Add login/logout to settings.

Problems: 1. Add login/logout to settings without functionality.

Solution: 1. Added a login view based on example, switches when the login/logout button is pressed. Unsure what to display when logged out, so a simple "Offline" is written to make user know they are not logged in.

Regarding issue [#921](https://git.webug.se/Andras/BoundlessFlowCampus2K/issues/921): Add login/logout to settings. Problems: 1. Add login/logout to settings without functionality. Solution: 1. Added a login view based on example, switches when the login/logout button is pressed. Unsure what to display when logged out, so a simple "Offline" is written to make user know they are not logged in. 
Added a layout for login/logout in settings, and language support
Fixed convention
a24vinla commented 2026-05-13 07:28:19 +00:00
Collaborator
Copy link

Review on #921

Whats done

Tested on Windows using Chrome

  • App starts!
    • Login and logout functionality works
    • Localization works!

Inspected following files

  • frontend/src/features/login/LoginLogout.js
    • Indentation/code styling
      • Indentation looks good!
    • CSS standard
      • Line 15 contains inline css
      • Otherwise no inline css and follows kebab-case
    • Naming convention
      • Follows naming convention
    • Comments
      • Not needed
    • General code quality
      • Good quality!
  • frontend/src/features/login/LoginLogout.module.css
    • Indentation/code styling
      • Indentation looks good!
    • CSS standard
      • Follows set standard
    • Naming convention
      • Follows naming convention
    • Comments
      • Good comments, clearly describes what each class does!
    • General code quality
      • Good quality!
  • Localization files
    • Should probably be put in alphabetical order in relation to other settings.account, but this is a separate issue
  • frontend/src/pages/Settings.js
    • A little annoying that elements get pushed down/up when clicking login (since "offline" takes up less space than picture)
    • Looks good and works otherwise!

What needs to be done

  • Move inline css to css file on line 15 in frontend/src/features/login/LoginLogout.js

Conclusion

  • Small things that require separate issues
# Review on #921 ## Whats done ### Tested on Windows using Chrome + App starts! + Login and logout functionality works + Localization works! ### Inspected following files + frontend/src/features/login/LoginLogout.js + Indentation/code styling + Indentation looks good! + CSS standard + Line 15 contains inline css + Otherwise no inline css and follows kebab-case + Naming convention + Follows naming convention + Comments + Not needed + General code quality + Good quality! + frontend/src/features/login/LoginLogout.module.css + Indentation/code styling + Indentation looks good! + CSS standard + Follows set standard + Naming convention + Follows naming convention + Comments + Good comments, clearly describes what each class does! + General code quality + Good quality! + Localization files + Should probably be put in alphabetical order in relation to other settings.account, but this is a separate issue + frontend/src/pages/Settings.js + A little annoying that elements get pushed down/up when clicking login (since "offline" takes up less space than picture) + Looks good and works otherwise! ## What needs to be done + Move inline css to css file on line 15 in frontend/src/features/login/LoginLogout.js ## Conclusion + Small things that require separate issues
Sorted localies alphabetical and fixed inline css to separate file
Fixed height issue
a24vinla approved these changes 2026-05-13 07:58:47 +00:00
a24vinla left a comment
Collaborator
Copy link

Issues have been fixed!

Issues have been fixed!
👍 1
a22erigr merged commit 08a0afa279 into team_2_week_5 2026-05-13 08:00:28 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
a24vinla
Labels
Clear labels   
_CRITICAL_

Only use this label for critical tasks that are project-scope,and must be addressed ASAP.

  
API

   
app

   
backEnd

   
Blocked-waiting-for-further-changes

   
bug

Something is not working

  
bug-only-on-server-for-mobile-not-webpage

   
Bug-Report-After-Merge

   
cleanup

Issues to cleanup the codebase (restructure folders, remove deprecated or smelly code)

  
close

Issue to close

  
design

   
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
feature request

   
frontEnd

   
further-changes-needed

   
future-problem-not-fixint-this-period

   
help wanted

Need some help

  
invalid

Something is wrong

  
last-week-issue-to-fix

   
library

   
low-priority

   
needs input

Issue needs input from product owner or customer

  
needs review

issue is in need of review

  
not-implemented.

   
project documentation

   
question

More information is needed

  
research

   
reviewed

This Issue has been reviewed

  
Script

   
security

use this for security-related issues

  
SQL

  
style

   
Team 1

Team 1 is responsible for this issue

  
Team 2

Team 2 is responsible for this issue

  
team leaders

   
test-creation

   
testing

   
topLevel

Reserved for top-level, project-wide issues.

  
unassigned

   
Under-review

   
wontfix

This won't be fixed

No labels
_CRITICAL_
API
app
backEnd
Blocked-waiting-for-further-changes
bug
bug-only-on-server-for-mobile-not-webpage
Bug-Report-After-Merge
cleanup
close
design
duplicate
enhancement
feature request
frontEnd
further-changes-needed
future-problem-not-fixint-this-period
help wanted
invalid
last-week-issue-to-fix
library
low-priority
needs input
needs review
not-implemented.
project documentation
question
research
reviewed
Script
security
SQL
style
Team 1
Team 2
team leaders
test-creation
testing
topLevel
unassigned
Under-review
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
b24idalu
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Andras/BoundlessFlowCampus2K!930
No description provided.