Andras/BoundlessFlowCampus2K
3
6
Fork 0
Code Issues 143 Pull requests 14 Projects Releases Packages Wiki Activity Actions 2

#873-implement-logger-for-tempservice #931

Merged
a22erigr merged 3 commits from 873-implement-logger-for-tempservice into team_2_week_5 2026-05-13 07:52:30 +00:00
Conversation 6 Commits 3 Files changed 3 +96 -39
a24nedka commented 2026-05-13 06:06:36 +00:00
Collaborator
Copy link

Replaced Console.WriteLine with ILogger in tempService.

Added structured logging for:
-endpoints
-service layer
-database queries

Replaced Console.WriteLine with ILogger in tempService. Added structured logging for: -endpoints -service layer -database queries
implemented logger instead of console.writeline
Replaced Console.WriteLine with ILogger in tempService.
a24nedka changed title from #873implement-logger-for-tempservice to #873-implement-logger-for-tempservice 2026-05-13 06:07:45 +00:00
a22erigr 2026-05-13 06:37:09 +00:00
a24sakma reviewed 2026-05-13 07:31:01 +00:00
a24sakma left a comment
Collaborator
Copy link

It looks good good.

What needs to be done

Just remove the redundant imports.

It looks good good. # What needs to be done Just remove the redundant imports.
service/tempService/tempService/DatabaseLogic/DatabaseQueries.cs Outdated
@ -1,11 +1,16 @@
using Dapper;
using Npgsql;
using tempService.Models;
using Microsoft.Extensions.Logging;
a24sakma commented 2026-05-13 07:26:59 +00:00
Collaborator
Copy link

You don't need to import logging. It is inbuilt it dotnet

You don't need to import logging. It is inbuilt it dotnet
a24sakma marked this conversation as resolved
service/tempService/tempService/Endpoints/TempEndpoints.cs Outdated
@ -1,6 +1,7 @@
using Microsoft.Extensions.Caching.Memory;
using tempService.Services;
using tempService.Models;
using Microsoft.Extensions.Logging;
a24sakma commented 2026-05-13 07:27:13 +00:00
Collaborator
Copy link

same here

same here
a24sakma marked this conversation as resolved
service/tempService/tempService/Services/TempService.cs
@ -1,10 +1,14 @@
using tempService.Models;
using tempService.DatabaseLogic;
using Microsoft.Extensions.Caching.Memory;
using Microsoft.Extensions.Logging;
a24sakma commented 2026-05-13 07:27:23 +00:00
Collaborator
Copy link

here too

here too
a24sakma marked this conversation as resolved
a24sakma requested changes 2026-05-13 07:31:25 +00:00
Dismissed
a24sakma left a comment
Collaborator
Copy link

check the above comments

check the above comments
Removed imports
a24nedka commented 2026-05-13 07:47:21 +00:00
Author
Collaborator
Copy link

@a22erigr @a24sakma Removed the imports as suggested in the review

@a22erigr @a24sakma Removed the imports as suggested in the review
👍 1
a22erigr commented 2026-05-13 07:50:28 +00:00
Collaborator
Copy link

Have you run the code and verified it works?

Have you run the code and verified it works?
a24sakma approved these changes 2026-05-13 07:52:19 +00:00
a22erigr merged commit 1ac1bc3ce4 into team_2_week_5 2026-05-13 07:52:30 +00:00
a24nedka commented 2026-05-13 07:55:31 +00:00
Author
Collaborator
Copy link

@a22erigr Yes, tested and it still works after removing the import

@a22erigr Yes, tested and it still works after removing the import
👍 1
Sign in to join this conversation.
Reviewers
No reviewers
a24sakma
Labels
Clear labels   
_CRITICAL_

Only use this label for critical tasks that are project-scope,and must be addressed ASAP.

  
API

   
app

   
backEnd

   
Blocked-waiting-for-further-changes

   
bug

Something is not working

  
bug-only-on-server-for-mobile-not-webpage

   
Bug-Report-After-Merge

   
cleanup

Issues to cleanup the codebase (restructure folders, remove deprecated or smelly code)

  
close

Issue to close

  
design

   
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
feature request

   
frontEnd

   
further-changes-needed

   
future-problem-not-fixint-this-period

   
help wanted

Need some help

  
invalid

Something is wrong

  
last-week-issue-to-fix

   
library

   
low-priority

   
needs input

Issue needs input from product owner or customer

  
needs review

issue is in need of review

  
not-implemented.

   
project documentation

   
question

More information is needed

  
research

   
reviewed

This Issue has been reviewed

  
Script

   
security

use this for security-related issues

  
SQL

  
style

   
Team 1

Team 1 is responsible for this issue

  
Team 2

Team 2 is responsible for this issue

  
team leaders

   
test-creation

   
testing

   
topLevel

Reserved for top-level, project-wide issues.

  
unassigned

   
Under-review

   
wontfix

This won't be fixed

No labels
_CRITICAL_
API
app
backEnd
Blocked-waiting-for-further-changes
bug
bug-only-on-server-for-mobile-not-webpage
Bug-Report-After-Merge
cleanup
close
design
duplicate
enhancement
feature request
frontEnd
further-changes-needed
future-problem-not-fixint-this-period
help wanted
invalid
last-week-issue-to-fix
library
low-priority
needs input
needs review
not-implemented.
project documentation
question
research
reviewed
Script
security
SQL
style
Team 1
Team 2
team leaders
test-creation
testing
topLevel
unassigned
Under-review
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Andras/BoundlessFlowCampus2K!931
No description provided.