Andras/BoundlessFlowCampus2K
4
7
Fork 0
Code Issues 90 Pull requests 7 Projects Releases Packages Wiki Activity Actions

#1033 fix-translate-view-button #1054

Merged
a22erigr merged 2 commits from #1033-fix-button-translate-view into team_2_week_7 2026-05-21 13:09:57 +00:00
Conversation 3 Commits 2 Files changed 2 +17 -3
j21marbr commented 2026-05-20 13:44:35 +00:00
Collaborator
Copy link
No description provided.
j21marbr commented 2026-05-20 13:46:10 +00:00
Author
Collaborator
Copy link
No description provided.
bild1.png
92 KiB
bild2.png
66 KiB
bild1.png bild2.png
a24danwe commented 2026-05-21 09:04:42 +00:00
Collaborator
Copy link

Review on #1054

Whats done

Replaced colors on the translation "look up" button with colors from theme.css

Tested on Windows using Chrome

  • App starts
    • Checked the TranslationView card, all looks good

Inspected following files

  • frontend/src/features/translator/TranslatorView.js
    • Looks good!
  • frontend/src/features/translator/translator.module.css
    • Small comment error. Word " look up" should be "lookup"

What needs to be done

  • Fix typo

Conclusion

  • Small typo should be fixed, after fixing typo it is ready to be merged
# Review on #1054 ## Whats done Replaced colors on the translation "look up" button with colors from theme.css ### Tested on Windows using Chrome + App starts + Checked the TranslationView card, all looks good ### Inspected following files - frontend/src/features/translator/TranslatorView.js - Looks good! - frontend/src/features/translator/translator.module.css - Small comment error. Word " look up" should be "lookup" ## What needs to be done + Fix typo ## Conclusion + Small typo should be fixed, after fixing typo it is ready to be merged
a24danwe commented 2026-05-21 09:12:28 +00:00
Collaborator
Copy link

Ready for merge!

Ready for merge!
a22erigr merged commit b8846ce80f into team_2_week_7 2026-05-21 13:09:57 +00:00
a22erigr deleted branch #1033-fix-button-translate-view 2026-05-21 13:10:08 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
a24danwe
Labels
Clear labels   
_CRITICAL_

Only use this label for critical tasks that are project-scope,and must be addressed ASAP.

  
API

   
app

   
backEnd

   
Blocked, waiting for further changes

   
bug

Something is not working

  
cleanup

Issues to cleanup the codebase (restructure folders, remove deprecated or smelly code)

  
close

Issue to close

  
design

   
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
feature request

   
frontEnd

   
help wanted

Need some help

  
invalid

Something is wrong

  
low priority

   
needs input

Issue needs input from product owner or customer

  
needs review

issue is in need of review

  
project documentation

   
question

More information is needed

  
research

   
reviewed

This Issue has been reviewed

  
script

   
security

use this for security-related issues

  
SQL

  
style

   
testing

   
topLevel

Reserved for top-level, project-wide issues.

  
wontfix

This won't be fixed

No labels
_CRITICAL_
API
app
backEnd
Blocked, waiting for further changes
bug
cleanup
close
design
duplicate
enhancement
feature request
frontEnd
help wanted
invalid
low priority
needs input
needs review
project documentation
question
research
reviewed
script
security
SQL
style
testing
topLevel
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Andras/BoundlessFlowCampus2K!1054
No description provided.