#1033 fix-translate-view-button #1054

Open
j21marbr wants to merge 2 commits from #1033-fix-button-translate-view into team_2_week_7
Collaborator
No description provided.
Author
Collaborator
No description provided.
a22erigr 2026-05-21 07:56:37 +00:00
Collaborator

Review on #1054

Whats done

Replaced colors on the translation "look up" button with colors from theme.css

Tested on Windows using Chrome

  • App starts
    • Checked the TranslationView card, all looks good

Inspected following files

  • frontend/src/features/translator/TranslatorView.js
    • Looks good!
  • frontend/src/features/translator/translator.module.css
    • Small comment error. Word " look up" should be "lookup"

What needs to be done

  • Fix typo

Conclusion

  • Small typo should be fixed, after fixing typo it is ready to be merged
# Review on #1054 ## Whats done Replaced colors on the translation "look up" button with colors from theme.css ### Tested on Windows using Chrome + App starts + Checked the TranslationView card, all looks good ### Inspected following files - frontend/src/features/translator/TranslatorView.js - Looks good! - frontend/src/features/translator/translator.module.css - Small comment error. Word " look up" should be "lookup" ## What needs to be done + Fix typo ## Conclusion + Small typo should be fixed, after fixing typo it is ready to be merged
Collaborator

Ready for merge!

Ready for merge!
This pull request can be merged automatically.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin #1033-fix-button-translate-view:#1033-fix-button-translate-view
git switch #1033-fix-button-translate-view

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch team_2_week_7
git merge --no-ff #1033-fix-button-translate-view
git switch #1033-fix-button-translate-view
git rebase team_2_week_7
git switch team_2_week_7
git merge --ff-only #1033-fix-button-translate-view
git switch #1033-fix-button-translate-view
git rebase team_2_week_7
git switch team_2_week_7
git merge --no-ff #1033-fix-button-translate-view
git switch team_2_week_7
git merge --squash #1033-fix-button-translate-view
git switch team_2_week_7
git merge --ff-only #1033-fix-button-translate-view
git switch team_2_week_7
git merge #1033-fix-button-translate-view
git push origin team_2_week_7
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Andras/BoundlessFlowCampus2K!1054
No description provided.