Andras/BoundlessFlowCampus2K

Fork 0

Add Vasttrafik widget with translations and styling #1065

Open

b25marem wants to merge 1 commit from vasttrafik-clean into team_2_week_7

b25marem commented

2026-05-21 07:58:32 +00:00

Collaborator

Vasttrafik Card Implementation

This PR adds a new Vasttrafik dashboard card with support for displaying departures and arrivals from Skövde Resecentrum.

Added

Vasttrafik frontend widget/card
Vasttrafik backend service and API integration
Dashboard integration
Tooltip support
Swedish and English translations
Styling improvements to better match existing dashboard cards

## Vasttrafik Card Implementation This PR adds a new Vasttrafik dashboard card with support for displaying departures and arrivals from Skövde Resecentrum. ### Added * Vasttrafik frontend widget/card * Vasttrafik backend service and API integration * Dashboard integration * Tooltip support * Swedish and English translations * Styling improvements to better match existing dashboard cards

b25marem added the

needs review

label

2026-05-21 07:58:32 +00:00

b25marem added 1 commit

2026-05-21 07:58:33 +00:00

Add Vasttrafik widget with translations and styling 8fdab1a8da

b24idalu commented

2026-05-21 08:03:42 +00:00

Collaborator

Can review this, assign me

👍 1

a22erigr

2026-05-21 08:19:28 +00:00

added the
Under-review
label
requested review from b24idalu

b24idalu requested changes

2026-05-21 08:41:54 +00:00

b24idalu left a comment

Collaborator

Review on #1065

Whats been done

Implemented västtrafikview

Tested on Windows using Chrome & Firefox

App starts
- Card is appearing in addcard modal
- Translation works
- Getting a 404 error on departure and arrivals.

Inspected following files

Per prior review (#958), code looks good and is up to standard.

What needs to be done

The styling does not match how the other cards look, they have a title and under that a line which is not presented in the västtrafik card.
The Docker is not building since it is not added to the rebuild script, causing the 404 error.
Could add an icon for the view in the addcardmodal.
Buttons are not matching the theme/mode. They also "disappear" when they are not selected (become white with white text in darkmode)
"Skövde resecentrum" disappears in darkmode because the text is too dark.

Conclusion

Is not ready for merge yet
Should parking be changed to travel?

# Review on #1065 ## Whats been done Implemented västtrafikview ### Tested on Windows using Chrome & Firefox + App starts + Card is appearing in addcard modal + Translation works + Getting a 404 error on departure and arrivals. ### Inspected following files + Per prior review (#958), code looks good and is up to standard. ## What needs to be done - The styling does not match how the other cards look, they have a title and under that a line which is not presented in the västtrafik card.![image](/attachments/8cf46738-ed20-49d1-9db8-e862e237280c) - The Docker is not building since it is not added to the rebuild script, causing the 404 error. - Could add an icon for the view in the addcardmodal. - Buttons are not matching the theme/mode. They also "disappear" when they are not selected (become white with white text in darkmode) - "Skövde resecentrum" disappears in darkmode because the text is too dark. ## Conclusion + Is not ready for merge yet + Should parking be changed to travel?

image.png

17 KiB

This pull request has changes conflicting with the target branch.

frontend/src/configs/tooltipConfig.js

View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u origin vasttrafik-clean:vasttrafik-clean

git switch vasttrafik-clean

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch team_2_week_7

git merge --no-ff vasttrafik-clean

git switch vasttrafik-clean

git rebase team_2_week_7

git switch team_2_week_7

git merge --ff-only vasttrafik-clean

git switch vasttrafik-clean

git rebase team_2_week_7

git switch team_2_week_7

git merge --no-ff vasttrafik-clean

git switch team_2_week_7

git merge --squash vasttrafik-clean