Andras/BoundlessFlowCampus2K
4
7
Fork 0
Code Issues 90 Pull requests 7 Projects Releases Packages Wiki Activity Actions

Add Vasttrafik widget with translations and styling #1065

Merged
a22erigr merged 7 commits from vasttrafik-clean into team_2_week_7 2026-05-25 13:48:17 +00:00
Conversation 10 Commits 7 Files changed 20 +1140 -20
b25marem commented 2026-05-21 07:58:32 +00:00
Collaborator
Copy link

Vasttrafik Card Implementation

This PR adds a new Vasttrafik dashboard card with support for displaying departures and arrivals from Skövde Resecentrum.

Added

  • Vasttrafik frontend widget/card
  • Vasttrafik backend service and API integration
  • Dashboard integration
  • Tooltip support
  • Swedish and English translations
  • Styling improvements to better match existing dashboard cards
## Vasttrafik Card Implementation This PR adds a new Vasttrafik dashboard card with support for displaying departures and arrivals from Skövde Resecentrum. ### Added * Vasttrafik frontend widget/card * Vasttrafik backend service and API integration * Dashboard integration * Tooltip support * Swedish and English translations * Styling improvements to better match existing dashboard cards
b24idalu commented 2026-05-21 08:03:42 +00:00
Collaborator
Copy link

Can review this, assign me

Can review this, assign me
👍 1
b24idalu requested changes 2026-05-21 08:41:54 +00:00
Dismissed
b24idalu left a comment
Collaborator
Copy link

Review on #1065

Whats been done

Implemented västtrafikview

Tested on Windows using Chrome & Firefox

  • App starts
    • Card is appearing in addcard modal
    • Translation works
    • Getting a 404 error on departure and arrivals.

Inspected following files

  • Per prior review (#958), code looks good and is up to standard.

What needs to be done

  • The styling does not match how the other cards look, they have a title and under that a line which is not presented in the västtrafik card.image
  • The Docker is not building since it is not added to the rebuild script, causing the 404 error.
  • Could add an icon for the view in the addcardmodal.
  • Buttons are not matching the theme/mode. They also "disappear" when they are not selected (become white with white text in darkmode)
  • "Skövde resecentrum" disappears in darkmode because the text is too dark.

Conclusion

  • Is not ready for merge yet
  • Should parking be changed to travel?
# Review on #1065 ## Whats been done Implemented västtrafikview ### Tested on Windows using Chrome & Firefox + App starts + Card is appearing in addcard modal + Translation works + Getting a 404 error on departure and arrivals. ### Inspected following files + Per prior review (#958), code looks good and is up to standard. ## What needs to be done - The styling does not match how the other cards look, they have a title and under that a line which is not presented in the västtrafik card.![image](/attachments/8cf46738-ed20-49d1-9db8-e862e237280c) - The Docker is not building since it is not added to the rebuild script, causing the 404 error. - Could add an icon for the view in the addcardmodal. - Buttons are not matching the theme/mode. They also "disappear" when they are not selected (become white with white text in darkmode) - "Skövde resecentrum" disappears in darkmode because the text is too dark. ## Conclusion + Is not ready for merge yet + Should parking be changed to travel?
image.png
17 KiB
b24idalu requested changes 2026-05-22 06:48:36 +00:00
Dismissed
b24idalu left a comment
Collaborator
Copy link

Review on #1065

Whats been done

Made västtraffik card work

Tested on Windows using Chrome & Firefox

  • App starts
    • Data is being displayed and everything is looking nice

Inspected following files

  • All files follow code standard and are well commented

What needs to be done

  • Card is a bit too small, it does not show all departures/arrivals in its original state
  • The buttons for departures/arrivals clash with darkmode, recommended to use theme colors to make them stand out in every theme

Conclusion

  • Almost ready to merge, just the card size and button colors left to fix
# Review on #1065 ## Whats been done Made västtraffik card work ### Tested on Windows using Chrome & Firefox + App starts + Data is being displayed and everything is looking nice ### Inspected following files + All files follow code standard and are well commented ## What needs to be done + Card is a bit too small, it does not show all departures/arrivals in its original state + The buttons for departures/arrivals clash with darkmode, recommended to use theme colors to make them stand out in every theme ## Conclusion + Almost ready to merge, just the card size and button colors left to fix
👍 1
b25marem commented 2026-05-22 06:52:39 +00:00
Author
Collaborator
Copy link

Thanks for the review! I’ll fix those issues right away.

Thanks for the review! I’ll fix those issues right away.
b25marem commented 2026-05-25 10:28:38 +00:00
Author
Collaborator
Copy link

Jag ska bara fixa konflikten

Jag ska bara fixa konflikten
a22erigr force-pushed vasttrafik-clean from af897b1201 to 3bcce53f81 2026-05-25 12:13:45 +00:00 Compare
a22erigr commented 2026-05-25 12:28:46 +00:00
Collaborator
Copy link

bild

![bild](/attachments/331a262e-6d7e-40ff-a1fb-d5417366ed8c)
bild.png
26 KiB
b24idalu approved these changes 2026-05-25 12:45:45 +00:00
Dismissed
b24idalu left a comment
Collaborator
Copy link

Looks good, everything compiles and displays. Is ready to merge!
Note that it may be good to change the card size at some point to the size of for example schedule, so that all information can be displayed immediately.

Looks good, everything compiles and displays. Is ready to merge! Note that it may be good to change the card size at some point to the size of for example schedule, so that all information can be displayed immediately.
b24idalu requested changes 2026-05-25 12:56:02 +00:00
Dismissed
b24idalu left a comment
Collaborator
Copy link

One missing feature noted, waiting on a new commit

One missing feature noted, waiting on a new commit
b24idalu approved these changes 2026-05-25 13:43:32 +00:00
b24idalu left a comment
Collaborator
Copy link

Extra features did not get managed to get pushed, but solution works and looks good.

Extra features included:

  • Displaying buses departures/arrivals.
  • Different card size since current one does not display all information without one having to scroll
  • Button color change since current blends in in darkmode
Extra features did not get managed to get pushed, but solution works and looks good. Extra features included: - Displaying buses departures/arrivals. - Different card size since current one does not display all information without one having to scroll - Button color change since current blends in in darkmode
a22erigr commented 2026-05-25 13:48:11 +00:00
Collaborator
Copy link

A new issue will be crated to revolve the missing features

A new issue will be crated to revolve the missing features
a22erigr merged commit 323168d445 into team_2_week_7 2026-05-25 13:48:17 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
b24idalu
Labels
Clear labels   
_CRITICAL_

Only use this label for critical tasks that are project-scope,and must be addressed ASAP.

  
API

   
app

   
backEnd

   
Blocked, waiting for further changes

   
bug

Something is not working

  
cleanup

Issues to cleanup the codebase (restructure folders, remove deprecated or smelly code)

  
close

Issue to close

  
design

   
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
feature request

   
frontEnd

   
help wanted

Need some help

  
invalid

Something is wrong

  
low priority

   
needs input

Issue needs input from product owner or customer

  
needs review

issue is in need of review

  
project documentation

   
question

More information is needed

  
research

   
reviewed

This Issue has been reviewed

  
script

   
security

use this for security-related issues

  
SQL

  
style

   
testing

   
topLevel

Reserved for top-level, project-wide issues.

  
wontfix

This won't be fixed

No labels
_CRITICAL_
API
app
backEnd
Blocked, waiting for further changes
bug
cleanup
close
design
duplicate
enhancement
feature request
frontEnd
help wanted
invalid
low priority
needs input
needs review
project documentation
question
research
reviewed
script
security
SQL
style
testing
topLevel
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Andras/BoundlessFlowCampus2K!1065
No description provided.