Andras/BoundlessFlowCampus2K

Fork 0

765-fix-visible-rows-edit-mode #1067

Merged

a24julot merged 2 commits from 765-fix-visible-rows-edit-mode into team_1_week_7

2026-05-21 09:57:04 +00:00

b24erika commented

2026-05-21 08:07:50 +00:00

Collaborator

What has changed

Now when adding a card the amount of emptycell rows will stay the same, added an observer to body so that when an user "zoom in" in the browser it re-calculate the grid to fit more rows/columns instead of being empty.

## What has changed Now when adding a card the amount of emptycell rows will stay the same, added an observer to body so that when an user "zoom in" in the browser it re-calculate the grid to fit more rows/columns instead of being empty.

b24erika added the

frontEnd

Team 1

needs review

labels

2026-05-21 08:07:50 +00:00

b24erika self-assigned this

2026-05-21 08:07:50 +00:00

b24erika added 2 commits

2026-05-21 08:07:51 +00:00

updated css, add resizeobserver 2969f0a9bb

observer on body so if a user zoom in the browser, more empty cells will be added

comment for function ac07efe850

b24erika referenced this pull request

2026-05-21 08:13:09 +00:00

Add rows in edit mode to show that cards can be moved down #765

a24julot

2026-05-21 08:27:10 +00:00

added
Under-review
and removed
needs review
labels
requested review from b24jonel

b24jonel commented

2026-05-21 09:32:54 +00:00

Collaborator

Review on #1067

Whats done

Tested on Windows 11 using [Name of Google Chrome

The empty cards do scale and rescale when "zooming in" on the browser and stay the same number.
App starts.
- Tested different zoom in "sizes" and it worked on all the ones tested.

Inspected following files App.js, Dashboard.js and Dashboard.module.css

App.js
- Only changed a single value.
Dashboard.js
- Indentation is correct.
- Naming conventions are being followed.
- Printed text uses and follows localization standards
  - Localization works.
- Comments follow the standard.
Dashboard.module.css
- CSS standard
  - Only two values are changed.

What needs to be done

Change the name of the pull request to "#765 fix visible rows edit mode" so it links back to the original issue.

Conclusion

The code can be merged.

# Review on #1067 ## Whats done ### Tested on Windows 11 using [Name of Google Chrome + The empty cards do scale and rescale when "zooming in" on the browser and stay the same number. + App starts. + Tested different zoom in "sizes" and it worked on all the ones tested. ### Inspected following files App.js, Dashboard.js and Dashboard.module.css + App.js + Only changed a single value. + Dashboard.js + Indentation is correct. + Naming conventions are being followed. + Printed text uses and follows localization standards + Localization works. + Comments follow the standard. + Dashboard.module.css + CSS standard + Only two values are changed. ## What needs to be done + Change the name of the pull request to "#765 fix visible rows edit mode" so it links back to the original issue. ## Conclusion The code can be merged.

b24erika commented

2026-05-21 09:41:22 +00:00

Author

Collaborator

Thanks for the review @b24jonel!

Some time ago they talked about not naming pull-request with a "#" since I believe it caused headaches for some users (linux) to fetch the branches, if this has change or is not a problem anymore perhaps any of the current leaders have the answer @a22erigr @a24julot @c24danli @a24sakma.

Thanks for the review @b24jonel! Some time ago they talked about not naming pull-request with a "#" since I believe it caused headaches for some users (linux) to fetch the branches, if this has change or is not a problem anymore perhaps any of the current leaders have the answer @a22erigr @a24julot @c24danli @a24sakma.

c24danli commented

2026-05-21 09:45:54 +00:00

Collaborator

I dont have linux so i haven't experienced the problem but the wiki say

What should the name of the branch be?
The branch should start with the issue number, no hashtag.

so no hashtag in the beginning. I now we are often bad at following this standard but no # is the standard.

I dont have linux so i haven't experienced the problem but the wiki say What should the name of the branch be? The branch should start with the issue number, no hashtag. so no hashtag in the beginning. I now we are often bad at following this standard but no # is the standard.

a22erigr commented

2026-05-21 09:46:43 +00:00

Collaborator

I am on linux and have not noticed this problem. I can fetch the branches and change to them. I am switching using the cmd. But when a hastag exists in the beginning i need to add \ in the beginning ex. \#765-fix-visible-rows-edit-mode

a24julot commented

2026-05-21 09:56:58 +00:00

Collaborator

The problem for linux user was the one mentioned by @a22erigr with the "". This is not an issue that needs to be fixed so I will merge this.

The problem for linux user was the one mentioned by @a22erigr with the "\". This is not an issue that needs to be fixed so I will merge this.

a24julot merged commit 65142b1be5 into team_1_week_7

2026-05-21 09:57:04 +00:00

a24julot referenced this pull request from a commit

2026-05-21 09:57:05 +00:00

Merge pull request '765-fix-visible-rows-edit-mode' (#1067) from 765-fix-visible-rows-edit-mode into team_1_week_7

b24erika commented

2026-05-21 10:00:42 +00:00

Author

Collaborator

@c24danli wrote in #1067 (comment):

I dont have linux so i haven't experienced the problem but the wiki say

What should the name of the branch be? The branch should start with the issue number, no hashtag.

so no hashtag in the beginning. I now we are often bad at following this standard but no # is the standard.

That's true and was changed since someone had an issue with it. Since it was only for branch and not the actual pull-request name which I could change to a "#", but there is no standard for that.

@c24danli wrote in https://git.webug.se/Andras/BoundlessFlowCampus2K/pulls/1067#issuecomment-12577: > I dont have linux so i haven't experienced the problem but the wiki say > > What should the name of the branch be? The branch should start with the issue number, no hashtag. > > so no hashtag in the beginning. I now we are often bad at following this standard but no # is the standard. That's true and was changed since someone had an issue with it. Since it was only for branch and not the actual pull-request name which I could change to a "#", but there is no standard for that.