Andras/BoundlessFlowCampus2K
4
7
Fork 0
Code Issues 90 Pull requests 7 Projects Releases Packages Wiki Activity Actions

Small refactor in loginService #1089

New issue
Closed
opened 2026-05-21 13:33:19 +00:00 by a22erigr · 1 comment
a22erigr commented 2026-05-21 13:33:19 +00:00
Collaborator
Copy link

Description

At the moment the separation of business logic and endpoints are mixed up.
bild
The endpoint should look more like this
bild

All logic (most) should be places in the AuthService file. By placing all logic in the same file debugging becomes easier

What should be done

  • Refactor the code without breaking it so that most of the logic is placed in AuthService
## Description At the moment the separation of business logic and endpoints are mixed up. ![bild](/attachments/6da50093-4d76-4993-a47a-9b54005067a2) The endpoint should look more like this ![bild](/attachments/0904d3cd-570b-4d43-b5e4-fab0900595cf) All logic (most) should be places in the AuthService file. By placing all logic in the same file debugging becomes easier ## What should be done + [ ] Refactor the code without breaking it so that most of the logic is placed in AuthService
bild.png
523 KiB
bild.png
375 KiB
c24danli commented 2026-05-25 11:21:27 +00:00
Collaborator
Copy link

PR: #1109 merged, will close this issue

PR: #1109 merged, will close this issue
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
#1236-edit-mode-txt
#1229-generic-themed-buttons
Add-an-option-to-set-no-image-to-image-view-1227
#1242-prog-bar-colors-fix
#1239-Remove-Vertical-Scroll
Image-view-error-1230
Make-the-card-title-and-header-of-card-uniform-1233
both_teams_week_8
team_2_week_7
team_1_week_7
temp_branch_week_7
team_2_week_6
team_1_week_6
team_2_week_5
team_1_week_5
temp_branch_week_5
team_2_week_4
team_1_week_4
week_4_temp_branch
temp-branch-week-3
team_2_week_3
team_1_week_3
team_2_week_2
team_1_week_2
temp-week-2-merge-branch
team_2_week_1
team_1_week_1
No results found.
Labels
Clear labels   
_CRITICAL_

Only use this label for critical tasks that are project-scope,and must be addressed ASAP.

  
API

   
app

   
backEnd

   
Blocked, waiting for further changes

   
bug

Something is not working

  
cleanup

Issues to cleanup the codebase (restructure folders, remove deprecated or smelly code)

  
close

Issue to close

  
design

   
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
feature request

   
frontEnd

   
help wanted

Need some help

  
invalid

Something is wrong

  
low priority

   
needs input

Issue needs input from product owner or customer

  
needs review

issue is in need of review

  
project documentation

   
question

More information is needed

  
research

   
reviewed

This Issue has been reviewed

  
script

   
security

use this for security-related issues

  
SQL

  
style

   
testing

   
topLevel

Reserved for top-level, project-wide issues.

  
wontfix

This won't be fixed

No labels
_CRITICAL_
API
app
backEnd
Blocked, waiting for further changes
bug
cleanup
close
design
duplicate
enhancement
feature request
frontEnd
help wanted
invalid
low priority
needs input
needs review
project documentation
question
research
reviewed
script
security
SQL
style
testing
topLevel
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
c22abdal
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Andras/BoundlessFlowCampus2K#1089
No description provided.