Andras/BoundlessFlowCampus2K
4
7
Fork 0
Code Issues 90 Pull requests 7 Projects Releases Packages Wiki Activity Actions

Added the service from endpoints to service #1109

Merged
a22erigr merged 1 commit from #1089-Small-LoginService-Refactor into team_2_week_7 2026-05-22 12:39:56 +00:00
Conversation 1 Commits 1 Files changed 2 +25 -8
c22abdal commented 2026-05-22 09:56:33 +00:00
Collaborator
Copy link

What has been done

Refactored the authentication endpoint structure by moving cookie configuration logic into AuthService.cs to improve the separation.
Endpoints are now focused on handling HTTP requests/responses. And AuthService manages authentication configuration and business logic.
Making debugging and maintenance easier

## What has been done Refactored the authentication endpoint structure by moving cookie configuration logic into AuthService.cs to improve the separation. Endpoints are now focused on handling HTTP requests/responses. And AuthService manages authentication configuration and business logic. Making debugging and maintenance easier
b24idalu approved these changes 2026-05-22 11:59:52 +00:00
b24idalu left a comment
Collaborator
Copy link

Review on #1109

Whats done

Refactor AuthEndpoints

Tested on Windows using Chrome

  • App starts
    • No problems

Inspected following files

Both files look good and up to standard.

What needs to be done

Nothing to be done

Conclusion

  • Ready for merge
# Review on #1109 ## Whats done Refactor AuthEndpoints ### Tested on Windows using Chrome + App starts + No problems ### Inspected following files Both files look good and up to standard. ## What needs to be done Nothing to be done ## Conclusion + Ready for merge
a22erigr merged commit 7d75263d30 into team_2_week_7 2026-05-22 12:39:56 +00:00
a22erigr deleted branch #1089-Small-LoginService-Refactor 2026-05-22 12:39:59 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
b24idalu
Labels
Clear labels   
_CRITICAL_

Only use this label for critical tasks that are project-scope,and must be addressed ASAP.

  
API

   
app

   
backEnd

   
Blocked, waiting for further changes

   
bug

Something is not working

  
cleanup

Issues to cleanup the codebase (restructure folders, remove deprecated or smelly code)

  
close

Issue to close

  
design

   
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
feature request

   
frontEnd

   
help wanted

Need some help

  
invalid

Something is wrong

  
low priority

   
needs input

Issue needs input from product owner or customer

  
needs review

issue is in need of review

  
project documentation

   
question

More information is needed

  
research

   
reviewed

This Issue has been reviewed

  
script

   
security

use this for security-related issues

  
SQL

  
style

   
testing

   
topLevel

Reserved for top-level, project-wide issues.

  
wontfix

This won't be fixed

No labels
_CRITICAL_
API
app
backEnd
Blocked, waiting for further changes
bug
cleanup
close
design
duplicate
enhancement
feature request
frontEnd
help wanted
invalid
low priority
needs input
needs review
project documentation
question
research
reviewed
script
security
SQL
style
testing
topLevel
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Andras/BoundlessFlowCampus2K!1109
No description provided.