Andras/BoundlessFlowCampus2K

Fork 0

1044 & 987 Create script expansion #1106

Merged

a24julot merged 7 commits from 1044-&-987-Create-script-expansion into team_1_week_7

2026-05-26 07:34:55 +00:00

a24timsv commented

2026-05-22 09:43:10 +00:00

Collaborator

Additions to the Create scripts, hopefully it works for the Unix system.

What the following scripts should do:
CreateService:

Create the folder structure for a service, according to the model
Create test folder and links it to the service
Add a stacks folder and file (the file is empty as it is very case specific)
Echoes the lines that should be pasted into nginx.conf

CreateMockup:

Create the folder structure for generate mockup
Create test folder and links it to the generate mockup
Create the folder structure for read mockup
Create test folder and links it to the read mockup

The service has to be created first, as the mockup script checks if an existing service exist before proceeding.

Additions to the Create scripts, hopefully it works for the Unix system. What the following scripts should do: CreateService: - Create the folder structure for a service, according to the model - Create test folder and links it to the service - Add a stacks folder and file (the file is empty as it is very case specific) - Echoes the lines that should be pasted into nginx.conf CreateMockup: - Create the folder structure for generate mockup - Create test folder and links it to the generate mockup - Create the folder structure for read mockup - Create test folder and links it to the read mockup The service has to be created first, as the mockup script checks if an existing service exist before proceeding.

a24timsv added the

needs review

script

labels

2026-05-22 09:43:10 +00:00

a24timsv added 4 commits

2026-05-22 09:43:10 +00:00

Re-branch e543c898f6

Added Unix variant 1cbfac650f

Added the Unix variant of create mockup and readMockup. Also some small fixes in the Windows variants.

Both versions need some error handling so that a mockup is related to  a service.

Added error handling to script 11eea5515e

Added an error handling so that a Mockup can't be created if the Service is missing

Name fixes a027d9a218

Fixed connectionString in Service/Program.cs to connect to service specific database

a24julot

2026-05-22 11:01:07 +00:00

removed the
needs review
label
requested review from a24hamrh

a24julot requested review from a24sakma

2026-05-25 10:44:40 +00:00

a24hamrh approved these changes

2026-05-25 11:14:13 +00:00

a24hamrh left a comment

Collaborator

Review on #1106

Whats done

Tested on Windows 11 using Firefox

App starts
- The app starts and works.

Inspected following files: UnixCreateMockup.sh, UnixCreateService.sh, WindowsCreateMockup.bat, WindowsCreateService.bat

all inspected files
- Indentation/code styling
  - Indentation is ok
- Naming convention
  - Naming convention is followed
- Comments
  - Follows standard and is in good amount
- General code quality
  - The general code quality is good

Conclusion

The scripts runs and seems to work fine on windows

# Review on #1106 ## Whats done ### Tested on Windows 11 using Firefox + App starts + The app starts and works. ### Inspected following files: UnixCreateMockup.sh, UnixCreateService.sh, WindowsCreateMockup.bat, WindowsCreateService.bat + all inspected files + Indentation/code styling + Indentation is ok + Naming convention + Naming convention is followed + Comments + Follows standard and is in good amount + General code quality + The general code quality is good ## Conclusion + The scripts runs and seems to work fine on windows

a24hamrh added the

reviewed

label

2026-05-25 11:14:22 +00:00

a24sakma reviewed

2026-05-25 11:27:16 +00:00

a24sakma left a comment

Collaborator

What have been reviewed:

the scripts seems to be running without error and it works

What can be improved

Update of read and wiki

information on how and which order the scripts shall be run and
also add to not using sh when running the script in linux
add that the script file needs to be executable but by running chmod command if does not have x in the right section for linux users

# What have been reviewed: 1. the scripts seems to be running without error and it works # What can be improved Update of read and wiki 1. information on how and which order the scripts shall be run and 2. also add to not using `sh` when running the script in linux 3. add that the script file needs to be executable but by running chmod command if does not have x in the right section for linux users

a24sakma removed the

reviewed

label

2026-05-25 11:28:03 +00:00

a22erigr added 1 commit

2026-05-26 06:52:31 +00:00

Added x to script 70883f0151

a24timsv added 1 commit

2026-05-26 07:22:47 +00:00

Updated README 484fed752d

Added some information about what the scripts do and the chmod changes. It also links to the Wiki page that talks about implementing new Services and Mockups.

a24timsv added the

needs review

label

2026-05-26 07:23:24 +00:00

a22erigr requested review from a22erigr

2026-05-26 07:29:55 +00:00

a24julot added

reviewed

and removed

needs review

labels

2026-05-26 07:30:33 +00:00

a22erigr approved these changes

2026-05-26 07:32:26 +00:00

a22erigr left a comment

Collaborator

Review

This review only looked at README. All other have already been approved.

The text is clear and easy to read. All the necessary information about the scripts can be found.

## Review This review only looked at README. All other have already been approved. + The text is clear and easy to read. All the necessary information about the scripts can be found.

a24julot added 1 commit

2026-05-26 07:34:45 +00:00