Andras/BoundlessFlowCampus2K

Fork 0

1104-Middleware-restructure/cleanup #1130

Merged

a22erigr merged 5 commits from 1104-Middleware-restructure/cleanup into team_2_week_7

2026-05-26 06:49:49 +00:00

a24vinla commented

2026-05-25 08:56:21 +00:00

Collaborator

What has been done

Some general clean up and small restructuring in:

middleware/middleware/Program.cs
- Removed unnecessary imports
- Changed how we split topic, I think this is easier to understand, but feel free to disagree!
- Changed some comments to be more explicit
- Fixed camelCase on some variables
- Switched places of InsertMessage and Sanitize methods
- Removed switch case with only one case

I had conversation about the CreateTable methods and the necessity of it, where it was decided that we probably will move creation of table to init sql-files, instead of going through the method each time we want to insert a value, which is quite ineffective. I have therefore not made any meaningful changes to that method

## What has been done Some general clean up and small restructuring in: + middleware/middleware/Program.cs + Removed unnecessary imports + Changed how we split topic, I think this is easier to understand, but feel free to disagree! + Changed some comments to be more explicit + Fixed camelCase on some variables + Switched places of InsertMessage and Sanitize methods + Removed switch case with only one case I had conversation about the CreateTable methods and the necessity of it, where it was decided that we probably will move creation of table to init sql-files, instead of going through the method each time we want to insert a value, which is quite ineffective. I have therefore not made any meaningful changes to that method

a24vinla added the

needs review

label

2026-05-25 08:56:21 +00:00

a24vinla added 2 commits

2026-05-25 08:56:21 +00:00

Clean up of middleware 6106ebf960

Removed switch/case 92072c6acd

a22erigr requested review from c24elipe

2026-05-25 09:21:19 +00:00

c24elipe added 1 commit

2026-05-25 09:50:51 +00:00

Small formatting fix 144376bdbf

c24elipe added 1 commit

2026-05-25 10:05:44 +00:00

Fixed small comment error. 2aac752e66

c24elipe added 1 commit

2026-05-25 10:06:44 +00:00

Fixed missing dots 0eabff21fa

c24elipe commented

2026-05-25 10:08:18 +00:00

Collaborator

Review on Pr #1130, Issue #1104

Reviewed the code and the logs from running it in a Docker container.

Tested on Arch Linux using Librewolf (a Firefox browser)

The app starts.

Inspected the following file

middleware/middleware/Program.cs
- Indentation/code styling
  - It's okay 👍
- Naming convention
  - I also took the liberty of renaming dbPassword and dbUser to DbUser and DbPassword, since we count readonly as constant values.
- Comments
  * Are mostly good, except that the line "; // <-- topic # is a wildcard for all topics" should instead be placed on its own line. And each comment needs to start with a capital letter.
- General code quality
  - Several non-critical issues were found, like the missing namespace in the file. I took the liberty of fixing them since it was 1 key press, and it is still the same code, more or less at the end.

What needs to be done

Fix the comment, and make sure that each two or more line comment uses /* */ style comments instead of //.

Conclusion

The small fixes should be looked over, and the comments should be fixed.

# Review on Pr #1130, Issue #1104 Reviewed the code and the logs from running it in a Docker container. ## Tested on **Arch** Linux using **Librewolf** (a Firefox browser) * The app starts. ## Inspected the following file * **middleware/middleware/Program.cs** * **Indentation/code styling** * It's okay 👍 * **Naming convention** * I also took the liberty of renaming dbPassword and dbUser to DbUser and DbPassword, since we count readonly as constant values. * **Comments** * Are mostly good, except that the line "; // <-- topic # is a wildcard for all topics" should instead be placed on its own line. And each comment needs to start with a capital letter. * **General code quality** * Several non-critical issues were found, like the missing namespace in the file. I took the liberty of fixing them since it was 1 key press, and it is still the same code, more or less at the end. ## What needs to be done Fix the comment, and make sure that each two or more line comment uses ``/* */`` style comments instead of ``//``. ## Conclusion The small fixes should be looked over, and the comments should be fixed.

c24elipe requested changes

2026-05-25 10:08:51 +00:00

c24elipe left a comment

Collaborator

See review for comment