Add API documentation about sudoku API in wiki #1145
Labels
No labels
_CRITICAL_
API
app
backEnd
Blocked, waiting for further changes
bug
cleanup
close
design
duplicate
enhancement
feature request
frontEnd
help wanted
invalid
low priority
needs input
needs review
project documentation
question
research
reviewed
script
security
SQL
style
testing
topLevel
wontfix
No milestone
No project
No assignees
5 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
Andras/BoundlessFlowCampus2K#1145
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Reserch in: Implement Sudoku view #377
Dosuku used
For easy access Wiki page:
Would like a review to check if everythings correct and if the issue is complete or if there's more to add.
Requesting review from @a24timsv
I can't speak of the content since I wasn't the one implementing it, if not too much of a hassle, I would request a review from @b24idalu regarding the content alone.
But I can speak about the structure of the page. I feel as like the page is not divided in a similarly to the other API documentations. Using smaller headers inside other headers to show relation to other headings, for example. Code blocks should also have a language related to them so they get color. Unnecessary use of lists. Stuff like that.
Ok, will work on the structure then.
Content seems good, but maybe a bit excessive about the functions that the view has since it is supposed to be about the api. Do not know if it is worth adding, but there can be alternative options in the dosuku fetch. For example amount of boards retrieved, if it should include text about which difficulty it is or if it should supply a solution (but some games have multiple solutions).
@b24idalu wrote in #1145 (comment):
Currently from my understanding the view uses a single randomized board without difficulty or data solution so i was/am unsure if i should include unused API features. So my question is should i write about the different APIs:
@b24krila wrote in #1145 (comment):
You can simply document the one we are using, but you can mention that there are other options as well, but you do not have to go into detail on the things we are not using.
@a24julot wrote in #1145 (comment):
yepp i have added a part where i list the one we are using but i could add a short section at the bottom where i can list the rest nad basically just say what uses they have "basically i take what the site has written"
That sounds good @b24krila !
The wiki is done. @a24timsv has reviewed the structure and edited some parts. Would be good to have a content review by @b24idalu before saying that the wiki is done.
Looks good!
As we are satisfied i will now close the issue