#1119-update-the-legal-page #1153

Merged

a22erigr merged 3 commits from #1119-update-the-legal-page into team_2_week_7

2026-05-26 07:54:25 +00:00

j21marbr commented

2026-05-26 06:59:08 +00:00

Collaborator

Added:

Updated the legal page with information about the project, privacy and APIs
License and attribution for SMHI, Västtrafik, Sudoku and FreeDictionary API
Localization support for both en and sv
Button links to official API pages
Removed placeholder text from footer legal link
Moved legal page files to a folder

Added: - Updated the legal page with information about the project, privacy and APIs - License and attribution for SMHI, Västtrafik, Sudoku and FreeDictionary API - Localization support for both en and sv - Button links to official API pages - Removed placeholder text from footer legal link - Moved legal page files to a folder

j21marbr added 3 commits

2026-05-26 06:59:09 +00:00

Update legal page translations and footer text 36b788f029

Create legal page with API and license information 45243f395f

Move legal files to folder 4b9b41c249

j21marbr added the

needs review

label

2026-05-26 07:00:00 +00:00

a22erigr requested review from b25marem

2026-05-26 07:03:13 +00:00

a24julot removed the

needs review

label

2026-05-26 07:08:17 +00:00

b25marem commented

2026-05-26 07:51:01 +00:00

Collaborator

Review on #1119

Whats done

Updated the legal page with project information, API usage, licenses, privacy information, localization support, and footer legal links.

Tested on Windows using Chrome

App starts successfully.
Tested /app/legal route.
- Legal page renders correctly after latest pull/update.
- Tested both English and Swedish localization.
- Tested dark theme and light theme rendering.
- Tested API sections and external “Open” buttons.
- Footer legal link is now connected correctly.
Checked that localization changes appear correctly in the UI.
Checked that the layout remains responsive and visually consistent.

Inspected following files

frontend/src/locales/en.json
- Indentation/code styling
  - Formatting is mostly correct.
- Naming convention
  - Translation keys follow existing naming conventions.
- Printed text uses and follows localization standards
  - English translations are implemented correctly.
- Comments
  - No comments needed.
- General code quality
  - Good organization of legal translations.
frontend/src/locales/sv.json
- Indentation/code styling
  - Formatting is mostly correct.
- Naming convention
  - Translation keys follow project conventions.
- Printed text uses and follows localization standards
  - Swedish localization works correctly in UI testing.
- Comments
  - No comments needed.
- General code quality
  - Good localization support implementation.
frontend/src/pages/index.js
- Indentation/code styling
  - Formatting follows project style.
- Naming convention
  - Export naming follows PascalCase convention.
- General code quality
  - Legal page export structure is clear.
frontend/src/pages/legal/Legal.js
- Indentation/code styling
  - Code formatting is readable and mostly consistent.
- Naming convention
  - Component naming follows PascalCase convention.
  - Folder naming follows lowercase/camelCase convention.
- Printed text uses and follows localization standards
  - Visible UI text uses localization correctly.
  - Technology names such as React and ASP.NET are acceptable as hardcoded names.
- Comments
  - Comments are understandable and descriptive.
- General code quality
  - Structure is clean and easy to follow.
  - External links correctly use target='_blank' and rel='noopener noreferrer'.
  - API/license information is organized well.
frontend/src/pages/legal/Legal.module.css
- Indentation/code styling
  - CSS formatting is readable.
- CSS standard
  - CSS Modules are used correctly.
  - Class names follow kebab-case convention.
  - Bracket notation usage is correct.
  - Theme support works correctly in testing.
  - Some CSS comments could use spacing cleanup to fully match CSS standards.
- Naming convention
  - Naming follows project standards.
- Comments
  - Comments are descriptive.
- General code quality
  - Styling is modular and visually consistent.
package.json
- No unapproved dependency changes were found in this PR

Conclusion

Legal page works correctly after latest updates.
English and Swedish localization work as intended.
Footer legal link is connected correctly.
API/license/project information is displayed properly.
Dark/light theme support works correctly.
No major blocking issues were found during testing.
PR is ready for merge

# Review on #1119 ## Whats done Updated the legal page with project information, API usage, licenses, privacy information, localization support, and footer legal links. ### Tested on Windows using Chrome + App starts successfully. + Tested `/app/legal` route. + Legal page renders correctly after latest pull/update. + Tested both English and Swedish localization. + Tested dark theme and light theme rendering. + Tested API sections and external “Open” buttons. + Footer legal link is now connected correctly. + Checked that localization changes appear correctly in the UI. + Checked that the layout remains responsive and visually consistent. ### Inspected following files + `frontend/src/locales/en.json` + Indentation/code styling + Formatting is mostly correct. + Naming convention + Translation keys follow existing naming conventions. + Printed text uses and follows localization standards + English translations are implemented correctly. + Comments + No comments needed. + General code quality + Good organization of legal translations. + `frontend/src/locales/sv.json` + Indentation/code styling + Formatting is mostly correct. + Naming convention + Translation keys follow project conventions. + Printed text uses and follows localization standards + Swedish localization works correctly in UI testing. + Comments + No comments needed. + General code quality + Good localization support implementation. + `frontend/src/pages/index.js` + Indentation/code styling + Formatting follows project style. + Naming convention + Export naming follows PascalCase convention. + General code quality + Legal page export structure is clear. + `frontend/src/pages/legal/Legal.js` + Indentation/code styling + Code formatting is readable and mostly consistent. + Naming convention + Component naming follows PascalCase convention. + Folder naming follows lowercase/camelCase convention. + Printed text uses and follows localization standards + Visible UI text uses localization correctly. + Technology names such as React and ASP.NET are acceptable as hardcoded names. + Comments + Comments are understandable and descriptive. + General code quality + Structure is clean and easy to follow. + External links correctly use `target='_blank'` and `rel='noopener noreferrer'`. + API/license information is organized well. + `frontend/src/pages/legal/Legal.module.css` + Indentation/code styling + CSS formatting is readable. + CSS standard + CSS Modules are used correctly. + Class names follow kebab-case convention. + Bracket notation usage is correct. + Theme support works correctly in testing. + Some CSS comments could use spacing cleanup to fully match CSS standards. + Naming convention + Naming follows project standards. + Comments + Comments are descriptive. + General code quality + Styling is modular and visually consistent. + `package.json` + No unapproved dependency changes were found in this PR ## Conclusion + Legal page works correctly after latest updates. + English and Swedish localization work as intended. + Footer legal link is connected correctly. + API/license/project information is displayed properly. + Dark/light theme support works correctly. + No major blocking issues were found during testing. + PR is ready for merge