Andras/BoundlessFlowCampus2K
4
7
Fork 0
Code Issues 90 Pull requests 7 Projects Releases Packages Wiki Activity Actions

#1119-update-the-legal-page #1193

Merged
a24julot merged 4 commits from #1119-update-the-legal-page into both_teams_week_8 2026-05-27 11:37:08 +00:00
Conversation 1 Commits 4 Files changed 6 +303 -19
j21marbr commented 2026-05-27 09:26:06 +00:00
Collaborator
Copy link

Recreated PR after the previous one went missing.
Related PR: #1153

Recreated PR after the previous one went missing. Related PR: #1153
a24julot 2026-05-27 10:15:34 +00:00
a24hirsa commented 2026-05-27 11:35:20 +00:00
Collaborator
Copy link

Review on issue #1119, PR #1193

Whats done

Review following things

  • code standards
  • Spelling and naming conventions
  • app page

Tested on Linux and Windows using Firefox and Chrome

  • App starts after running Installation then building

Inspected following files, Legal.js, en.json, sv.json

  • Legal.js
    • Code Standard
    • Indentation/code styling
    • CSS standard in Legal.module.css
  • en.json and sv.json
    • Indentation/code styling
    • spelling

What needs to be done

  • nothing

Conclusion

  • Legal pages works after running a installation and building
  • code and naming looks good and no spelling errors were spotted
  • this is ready to be merged
# Review on issue #1119, PR #1193 ## Whats done Review following things + code standards + Spelling and naming conventions + app page ### Tested on Linux and Windows using Firefox and Chrome + App starts after running Installation then building ### Inspected following files, Legal.js, en.json, sv.json + Legal.js + Code Standard + Indentation/code styling + CSS standard in Legal.module.css + en.json and sv.json + Indentation/code styling + spelling ## What needs to be done + nothing ## Conclusion + Legal pages works after running a installation and building + code and naming looks good and no spelling errors were spotted + this is ready to be merged
a24julot merged commit b02b0f6967 into both_teams_week_8 2026-05-27 11:37:08 +00:00
c24danli deleted branch #1119-update-the-legal-page 2026-05-28 08:23:17 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
a24hirsa
Labels
Clear labels   
_CRITICAL_

Only use this label for critical tasks that are project-scope,and must be addressed ASAP.

  
API

   
app

   
backEnd

   
Blocked, waiting for further changes

   
bug

Something is not working

  
cleanup

Issues to cleanup the codebase (restructure folders, remove deprecated or smelly code)

  
close

Issue to close

  
design

   
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
feature request

   
frontEnd

   
help wanted

Need some help

  
invalid

Something is wrong

  
low priority

   
needs input

Issue needs input from product owner or customer

  
needs review

issue is in need of review

  
project documentation

   
question

More information is needed

  
research

   
reviewed

This Issue has been reviewed

  
script

   
security

use this for security-related issues

  
SQL

  
style

   
testing

   
topLevel

Reserved for top-level, project-wide issues.

  
wontfix

This won't be fixed

No labels
_CRITICAL_
API
app
backEnd
Blocked, waiting for further changes
bug
cleanup
close
design
duplicate
enhancement
feature request
frontEnd
help wanted
invalid
low priority
needs input
needs review
project documentation
question
research
reviewed
script
security
SQL
style
testing
topLevel
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
a24hirsa
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Andras/BoundlessFlowCampus2K!1193
No description provided.