changed so user can select NO IMAGE #1252

Open
e24aleli wants to merge 1 commit from Add-an-option-to-set-no-image-to-image-view-1227 into both_teams_week_8
Collaborator

Removed the "hidden" from null value

Removed the "hidden" from null value
Author
Collaborator

Review on #1252

Whats done

Tested on Windows 11 Using Helium

  • App starts - OK
  • Tested by adding an image view and changed images, the displayed image in the add card modal depends on previous used.

Inspected following files

  • useImage.js
    • Indentation/code styling - OK
    • Naming convention - OK
    • Printed text uses and follows localization standards- OK
    • General code quality - OK

Conclusion

The PR is ready for merge, user can now select an "empty" image view at any time.

# Review on #1252 ## Whats done ### Tested on Windows 11 Using Helium + App starts - OK + Tested by adding an image view and changed images, the displayed image in the add card modal depends on previous used. ### Inspected following files + useImage.js + Indentation/code styling - OK + Naming convention - OK + Printed text uses and follows localization standards- OK + General code quality - OK ## Conclusion The PR is ready for merge, user can now select an "empty" image view at any time.
This pull request can be merged automatically.
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin Add-an-option-to-set-no-image-to-image-view-1227:Add-an-option-to-set-no-image-to-image-view-1227
git switch Add-an-option-to-set-no-image-to-image-view-1227

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch both_teams_week_8
git merge --no-ff Add-an-option-to-set-no-image-to-image-view-1227
git switch Add-an-option-to-set-no-image-to-image-view-1227
git rebase both_teams_week_8
git switch both_teams_week_8
git merge --ff-only Add-an-option-to-set-no-image-to-image-view-1227
git switch Add-an-option-to-set-no-image-to-image-view-1227
git rebase both_teams_week_8
git switch both_teams_week_8
git merge --no-ff Add-an-option-to-set-no-image-to-image-view-1227
git switch both_teams_week_8
git merge --squash Add-an-option-to-set-no-image-to-image-view-1227
git switch both_teams_week_8
git merge --ff-only Add-an-option-to-set-no-image-to-image-view-1227
git switch both_teams_week_8
git merge Add-an-option-to-set-no-image-to-image-view-1227
git push origin both_teams_week_8
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Andras/BoundlessFlowCampus2K!1252
No description provided.