Andras/BoundlessFlowCampus2K

Fork 0

#31-support-for-different-styles #196

Merged

c24elipe merged 10 commits from #31-support-for-different-styles into team_2_week_1

2026-04-14 13:47:09 +00:00

b23albst commented

2026-04-09 08:47:51 +00:00

Collaborator

Here are the things remaining to be done:

Full implementation of style select component (look at #223 before merging this pull request)
Adding a variable to the style dataset for the logo
Use the right fonts for the styles
Make the cards look "good" with the different styles. Right now the styles are implemented for cards, but I lack an eye for esthetics
Add the styles for the seasons

For the reviewer, read the Wiki page to understand the thought behind it.

Also, is the file useStyle.js in the right location?

This is not a full solution to the issue. What this branch does is implement a standard to be followed for using styles, as well as dark and light mode. It also implements a hook used for changing styles and light/dark mode (issues #17 and #18) and a "skeleton" for the style select component that utilizes this hook. Here are the things remaining to be done: - Full implementation of style select component (look at #223 before merging this pull request) - Adding a variable to the style dataset for the logo - Use the right fonts for the styles - Make the cards look "good" with the different styles. Right now the styles are implemented for cards, but I lack an eye for esthetics - Add the styles for the seasons For the reviewer, read the [Wiki page](https://git.webug.se/Andras/BoundlessFlowCampus2K/wiki/Implementing-different-Styles) to understand the thought behind it. Also, is the file useStyle.js in the right location?

b23albst added 4 commits

2026-04-09 08:47:52 +00:00

Added hook for changing styles to features. Also added test style dark to theme.css and a button for testing in App.js efefc53213

Added several new variables to theme.css and changed the card css file to use variables instead of hard coded colors 5db5dc8503

changed theme.css to utilize css light-dark and removed dark style. Added rubine style as an example and button for light-dark 5ac6ea9a62

Changed useStyle to also include function for light/dark mode. Created test version of StyleSelect component. Cleaned up App.js from test 67f23153e6

c24elipe added 2 commits

2026-04-09 10:22:57 +00:00

Added the his default styles data attributes 8538bde4b2

Merge pull request 'Added the his default styles data attributes' (#201 ) from #32-#34-adding-different-his-default-styles into #31-support-for-different-styles eb72f92b6c

Reviewed-on: #201

b23albst referenced this pull request

2026-04-09 10:28:19 +00:00

[Style] Default HiS "purple style" #34

b23albst referenced this pull request

2026-04-09 10:28:39 +00:00

[Style] Default HiS "blue" style #33

b23albst referenced this pull request

2026-04-09 10:28:48 +00:00

[Style] Default HiS "green style" #32

b23albst was assigned by c24elipe

2026-04-10 06:23:59 +00:00

c24elipe added the

frontEnd

label

2026-04-10 07:41:04 +00:00

b23albst referenced this pull request

2026-04-10 09:50:59 +00:00

Added styling for the StyleSelect component #223

b23albst added the

needs review

label

2026-04-10 10:07:57 +00:00

b23albst referenced this pull request

2026-04-10 10:14:24 +00:00

Implementation of colors and light/darkmode #195

c24elipe requested review from c24carso

2026-04-13 09:52:55 +00:00

c24carso commented

2026-04-13 12:01:08 +00:00

Collaborator

Checks performed:
Verified colors compared to wiki palette.
Checked the code for wiki standards.
Pulled the branch.

Issues:
A semicolon missing on Card.module.css line 13 color: var(--card-title-color)
No comment in styleselect.js (Wiki standard)
CSS declarations in card.module.css not in alphabetical order (Wiki standard)

Checks performed: Verified colors compared to wiki palette. Checked the code for wiki standards. Pulled the branch. Issues: A semicolon missing on Card.module.css line 13 color: var(--card-title-color) No comment in styleselect.js (Wiki standard) CSS declarations in card.module.css not in alphabetical order (Wiki standard)

b23albst added 1 commit

2026-04-13 22:45:11 +00:00

Fixed issues brough up in pull request review 4687844b06

c24elipe requested review from c22abdal

2026-04-14 09:15:51 +00:00