#31-support-for-different-styles #196
Labels
No labels
_CRITICAL_
API
app
backEnd
Blocked, waiting for further changes
bug
cleanup
close
design
duplicate
enhancement
feature request
frontEnd
help wanted
invalid
low priority
needs input
needs review
project documentation
question
research
reviewed
script
security
SQL
style
testing
topLevel
wontfix
No milestone
No project
No assignees
4 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
Andras/BoundlessFlowCampus2K!196
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "#31-support-for-different-styles"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
This is not a full solution to the issue. What this branch does is implement a standard to be followed for using styles, as well as dark and light mode. It also implements a hook used for changing styles and light/dark mode (issues #17 and #18) and a "skeleton" for the style select component that utilizes this hook.
Here are the things remaining to be done:
For the reviewer, read the Wiki page to understand the thought behind it.
Also, is the file useStyle.js in the right location?
Checks performed:
Verified colors compared to wiki palette.
Checked the code for wiki standards.
Pulled the branch.
Issues:
A semicolon missing on Card.module.css line 13 color: var(--card-title-color)
No comment in styleselect.js (Wiki standard)
CSS declarations in card.module.css not in alphabetical order (Wiki standard)
New updates are working perfectly and didn't cause any weird behaviors.
I have tested the code, and it compiles and works now.