Added styling for the StyleSelect component #223

Merged

c24elipe merged 2 commits from #171-change-styles-component into #31-support-for-different-styles 2026-04-14 13:00:26 +00:00

Conversation 4 Commits 2 Files changed 5 +80 -35

b23albst commented 2026-04-10 09:50:59 +00:00

Collaborator

Copy link

This pull request just adds styling to the styleSelect component that already exists in #196

This pull request just adds styling to the styleSelect component that already exists in #196

b23albst added 1 commit 2026-04-10 09:51:00 +00:00

Added styling for the StyleSelect component 762dcc5a6f

b23albst referenced this pull request 2026-04-10 09:52:28 +00:00

#31-support-for-different-styles #196

b23albst added the

needs review

label 2026-04-10 10:08:34 +00:00

b23albst referenced this pull request 2026-04-10 10:45:17 +00:00

Change styles component #171

b23albst was assigned by c24elipe 2026-04-10 11:14:02 +00:00

c24elipe requested review from b25marem 2026-04-10 11:18:51 +00:00

b25marem commented 2026-04-13 06:58:44 +00:00

Collaborator

Copy link

I was not able to verify the styling changes in the running application, since the StyleSelect component does not appear to be rendered anywhere at the moment (e.g. App.js only renders TemperatureView). This makes it difficult to review the visual result of this PR.

Overall, the direction looks good, but it would help if the component was rendered in the UI (even temporarily) so the styling can be properly tested.

I was not able to verify the styling changes in the running application, since the StyleSelect component does not appear to be rendered anywhere at the moment (e.g. App.js only renders TemperatureView). This makes it difficult to review the visual result of this PR. Overall, the direction looks good, but it would help if the component was rendered in the UI (even temporarily) so the styling can be properly tested.

b25marem commented 2026-04-13 06:59:28 +00:00

Collaborator

Copy link


image.png

50 KiB

b23albst commented 2026-04-13 08:14:31 +00:00

Author

Collaborator

Copy link

Yeah, I removed the component from App.js prior to making the pull request, since I don't want App to be cluttered by all of our tested components. Just add this to App.js to try it out:

Yeah, I removed the component from App.js prior to making the pull request, since I don't want App to be cluttered by all of our tested components. Just add this to App.js to try it out: 

image.png

36 KiB

b25marem added the

reviewed

label 2026-04-13 08:30:37 +00:00

a24vinla removed the

needs review

label 2026-04-14 12:06:55 +00:00

c24elipe added 1 commit 2026-04-14 12:59:11 +00:00

Removed unused imports of react 918dd9ee09

c24elipe commented 2026-04-14 13:00:02 +00:00

Collaborator

Copy link

Have double-checked the code, and it works as described/planned.
Merging it now.

Have double-checked the code, and it works as described/planned. Merging it now.

c24elipe merged commit 496d323d15 into #31-support-for-different-styles 2026-04-14 13:00:26 +00:00

c24elipe deleted branch #171-change-styles-component 2026-04-14 13:00:26 +00:00

c24elipe referenced this pull request from a commit 2026-04-14 13:00:28 +00:00

Merge pull request 'Added styling for the StyleSelect component' (#223) from #171-change-styles-component into #31-support-for-different-styles

b25marem referenced this pull request from a commit 2026-05-15 08:56:00 +00:00

Merge pull request 'Added styling for the StyleSelect component' (#223) from #171-change-styles-component into #31-support-for-different-styles

Sign in to join this conversation.

Reviewers

No reviewers

b25marem

Labels

Clear labels   

_CRITICAL_

Only use this label for critical tasks that are project-scope,and must be addressed ASAP.

  

API

  

app

  

backEnd

  

Blocked-waiting-for-further-changes

  

bug

Something is not working

  

bug-only-on-server-for-mobile-not-webpage

  

Bug-Report-After-Merge

  

cleanup

Issues to cleanup the codebase (restructure folders, remove deprecated or smelly code)

  

close

Issue to close

  

design

  

duplicate

This issue or pull request already exists

  

enhancement

New feature

  

feature request

  

frontEnd

  

further-changes-needed

  

future-problem-not-fixint-this-period

  

help wanted

Need some help

  

invalid

Something is wrong

  

last-week-issue-to-fix

  

library

  

low-priority

  

needs input

Issue needs input from product owner or customer

  

needs review

issue is in need of review

  

not-implemented.

  

project documentation

  

question

More information is needed

  

research

  

reviewed

This Issue has been reviewed

  

Script

  

security

use this for security-related issues

  

SQL

  

style

  

Team 1

Team 1 is responsible for this issue

  

Team 2

Team 2 is responsible for this issue

  

team leaders

  

test-creation

  

testing

  

topLevel

Reserved for top-level, project-wide issues.

  

unassigned

  

Under-review

  

wontfix

This won't be fixed

No labels

_CRITICAL_

API

app

backEnd

Blocked-waiting-for-further-changes

bug

bug-only-on-server-for-mobile-not-webpage

Bug-Report-After-Merge

cleanup

close

design

duplicate

enhancement

feature request

frontEnd

further-changes-needed

future-problem-not-fixint-this-period

help wanted

invalid

last-week-issue-to-fix

library

low-priority

needs input

needs review

not-implemented.

project documentation

question

research

reviewed

Script

security

SQL

style

Team 1

Team 2

team leaders

test-creation

testing

topLevel

unassigned

Under-review

wontfix

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

b23albst

3 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Andras/BoundlessFlowCampus2K!223

No description provided.