#28 Added-MapView #213
No reviewers
Labels
No labels
_CRITICAL_
API
app
backEnd
Blocked-waiting-for-further-changes
bug
bug-only-on-server-for-mobile-not-webpage
Bug-Report-After-Merge
cleanup
close
design
duplicate
enhancement
feature request
frontEnd
further-changes-needed
future-problem-not-fixint-this-period
help wanted
invalid
last-week-issue-to-fix
library
low-priority
needs input
needs review
not-implemented.
project documentation
question
research
reviewed
Script
security
SQL
style
Team 1
Team 2
team leaders
test-creation
testing
topLevel
unassigned
Under-review
wontfix
No milestone
No project
3 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
Andras/BoundlessFlowCampus2K!213
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "#28-Support-for-displaying-maps"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Add MapView component with floor images
Added MapViewto #28 Added MapView#28 Added MapViewto #28 Added-MapViewWhat I reviewed:
I have reviewed all the changed files related to this issue, including MapView.js, App.js, and the added SVG assets
Checked that the implementation follows the project structure and React coding standards
How I tested it:
Switched to the issue branch and pulled the latest changes
Started the frontend locally using npm start
Verified that the MapView is rendered in the application
Tested that the buttons “Våning 1” and “Våning 2” are visible and working
Confirmed that switching between floors updates the displayed map correctly
What works:
The MapView component is correctly placed under frontend/src/features/map
The component is properly imported and used in App.js
The SVG floor images are loaded and displayed correctly
The functionality for switching between floors works as expected
Code review / standards:
Component naming follows PascalCase (MapView)
Folder naming follows camelCase (map)
The implementation is simple and readable
The shared Card component is used correctly
Conclusion:
The feature works correctly and is implemented properly.
Have taken a light look as well, and it looks good. Merging now
