Check for bugs after merge #491
Labels
No labels
_CRITICAL_
API
app
backEnd
Blocked, waiting for further changes
bug
cleanup
close
design
duplicate
enhancement
feature request
frontEnd
help wanted
invalid
low priority
needs input
needs review
project documentation
question
research
reviewed
script
security
SQL
style
testing
topLevel
wontfix
No milestone
No project
No assignees
14 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
Andras/BoundlessFlowCampus2K#491
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Merge seems to have broken a lot of features. Please check features you have domain knowledge over. If you find a bug/missing feature please comment what is wrong and which branch the feature belongs to.
Do not make a new issue, we want to avoid duplicate issues.
The feature that I implemented that ensured that cards did not spawn over each other is gone. In that implementation I also ensured that when a card is moved, the other cards move away to make space for the card the user is moving/resizing - this is also gone.
PR: #398
The default URL for schedule view is gone, I am not sure if this was on purpose or not, but it is gone.
PR: #416
Going to re-implement cards for errors as well as language/coding standards according to this pull-request.
Login styling is duplicated. Login CSS variables are in both theme.css and LoginModal.module.css. The merge brought back the variables to theme.css that were removed on line 43-54. Can just remove them again. #307
All temperature view outputs are broken except SMHI. Don't know exact branch. All have HTTP ERROR 400 except the TemperatureGraphView and TemperatureView that have HTTP ERROR 500.
I think it's mostly frontend syntax so easy to fix.
MapView does not scale correctly. I don't know if it did scale correctly before the merge either but just pointing it out:
PR: #213
The outline fix in theme.css is commented out, so the default red placeholder shows when dragging/resizing cards. Can just uncomment it. #245
@b24hugst wrote in #491 (comment):
@b24hugst this was a known issue when we did update the middleware. Roombooking is the only micro service that works and the below issues were created for this.
Changes in TemperatureView.js are gone. dynamic population of sensors and buttons to chage sensor with.
PR #423
@a24julot wrote in #491 (comment):
This was done on purpose, since we can add our own URL now. If we want to add a standard URL for the sake of development we could re-add it.
@c24carso wrote in #491 (comment):
Fixed!
A Work-In-Progress version of an update to the tempSensorMockup unit test, seems to have been merged, which is broken and incomplete. Several variabels are completely missing.
@a24julot wrote in #491 (comment):
This is partly a deliberate change since we are working on a solution that allows us to remove the vertical compacting while not adding cards to the top left corner. Other cards not moving when expanding cards is not fixed with this, will create a separate issue for this. It might not be possible to do without vertical compcating however.
@b24hugst wrote in #491 (comment):
Apparently a known issue. Will create a separate issue for this.
A lot of things is missing in the tempSensor Mockup test since the merge
@f21marfo wrote in #491 (comment):
Seems like it. Do you have access to a complete variant in a branch or PR? If that is the case we can re-implement it ASAP.
@a24timsv wrote in #491 (comment):
I believe @a24nedka was assigned to updating those tests which i raised as a bug last week in #406
It's a minor thing, but the updated SMHIForecastView does not use the api's weather symbol codes for displaying the weather situation
@b23albst is there a branch/issue you could link?
@a24timsv the version with PR was branch 406 , there is the full version I think.
@f21marfo wrote in #491 (comment):
I found the new code for the test in its branch. It doesn't give errors in VSC now but the test fails (1 out of 4 fails). We have reimplemented it into our temp branch and @a24nedka can look at it later. I will keep the issue open and we will work from there.
@a24vinla wrote in #491 (comment):
The branch has been deleted, but the pull request was #432 and the issue is #408
The textview looks nothing like the changes that were made last (I don't know if someone else changed it after I did?).
and the input field is not working (i,e,. it takes not input)
Grid layout in Edit mode is missing in the new branch since merge.
Parking view is showing an error now
@c22abdal wrote in #491 (comment):
This is known, see this comment
The test project doesn’t build. JsonData.test.cs throws three CS0103 errors:
line 69: propertyName does not exist in the current context
line 99: property does not exist in the current context
line 105: dec does not exist in the current context
The project is expected to compile and all tests should pass.
It looks like JsonData.test.cs wasn’t fully updated after the /temperature`endpoint changed from returning a single object to returning an array.
@c22abdal wrote in #491 (comment):
I think both teams worked in this View, and it seems that Team 1's branch overwrote team 2's. If you have a PR or branch with your code we can discuss which one to use. In the future we should try to keep teams from changing stuff in the same files.
@b25marem wrote in #491 (comment):
See this comment for context: #491 (comment):
It was an old test that wasn't complete, we have it working in our temp branch. We will notify everyone once all bugs are fixed and we the new team branches are live.
@c22abdal wrote in #491 (comment):
I implemented this textview on team1 branch this week, input-tag type-text is mainly for single-line text and instead I changed to textarea-tag. To write anything in the textview you need to press the edit button.
Seems like we worked on the same functionallity and mine was the one merged.
@b24erika wrote in #491 (comment):
Ok that explains it, the edit button and the erase all button are too close to each other I thought they were the same button.
I implemented a feature to have a title and a body text with just presseing on the text to edit it, and anywhere else to save it
#407
This was a problem before the merge, so just a general issue-idea (sorry if this was a bad place to post this in):
Card minimum size is too small for content to follow accurately, which makes it look very unpleasant.
@b24hugst wrote in #491 (comment):
We group leaders currently discuss how big a grid space should be, and hopefully it will solve this ugliness.
I do not know if this is an issue but currently it is possible to drag cards under the address bar.
It should be confined to the grind?
PR #457
The feature where the horizontal scrollbar is removed is not currently here.
a24danwe referenced this issue2026-04-24 12:57:41 +00:00