Check for bugs after merge

a24vinla commented

2026-04-22 13:46:31 +00:00

Collaborator

Merge seems to have broken a lot of features. Please check features you have domain knowledge over. If you find a bug/missing feature please comment what is wrong and which branch the feature belongs to.

Do not make a new issue, we want to avoid duplicate issues.

Merge seems to have broken a lot of features. Please check features you have domain knowledge over. If you find a bug/missing feature please comment what is wrong and which branch the feature belongs to. Do not make a new issue, we want to avoid duplicate issues.

a24vinla added the

bug

_CRITICAL_

topLevel

labels

2026-04-22 13:46:31 +00:00

a24julot commented

2026-04-22 13:57:28 +00:00

Collaborator

The feature that I implemented that ensured that cards did not spawn over each other is gone. In that implementation I also ensured that when a card is moved, the other cards move away to make space for the card the user is moving/resizing - this is also gone.

PR: #398

The feature that I implemented that ensured that cards did not spawn over each other is gone. In that implementation I also ensured that when a card is moved, the other cards move away to make space for the card the user is moving/resizing - this is also gone. PR: https://git.webug.se/Andras/BoundlessFlowCampus2K/pulls/398

cards.png

26 KiB

a24julot commented

2026-04-22 13:58:49 +00:00

Collaborator

The default URL for schedule view is gone, I am not sure if this was on purpose or not, but it is gone.

PR: #416

The default URL for schedule view is gone, I am not sure if this was on purpose or not, but it is gone. PR: https://git.webug.se/Andras/BoundlessFlowCampus2K/pulls/416

schedule.png

10 KiB

b24erika commented

2026-04-22 13:59:09 +00:00

Collaborator

Going to re-implement cards for errors as well as language/coding standards according to this pull-request.

Going to re-implement cards for errors as well as language/coding standards according to this [pull-request](https://git.webug.se/Andras/BoundlessFlowCampus2K/pulls/419).

c24carso commented

2026-04-22 14:31:10 +00:00

Collaborator

Login styling is duplicated. Login CSS variables are in both theme.css and LoginModal.module.css. The merge brought back the variables to theme.css that were removed on line 43-54. Can just remove them again. #307

Screenshot 2026-04-22 163021.png

25 KiB

b24hugst commented

2026-04-22 14:32:41 +00:00

Collaborator

All temperature view outputs are broken except SMHI. Don't know exact branch. All have HTTP ERROR 400 except the TemperatureGraphView and TemperatureView that have HTTP ERROR 500.

I think it's mostly frontend syntax so easy to fix.

All temperature view outputs are broken except SMHI. Don't know exact branch. All have HTTP ERROR 400 except the TemperatureGraphView and TemperatureView that have HTTP ERROR 500. I think it's mostly frontend syntax so easy to fix. ![image](/attachments/074132ec-3739-479a-9b52-db5c3c97115a)

image.png

35 KiB

b24hugst commented

2026-04-22 14:37:50 +00:00

Collaborator

MapView does not scale correctly. I don't know if it did scale correctly before the merge either but just pointing it out:

PR: #213

MapView does not scale correctly. I don't know if it did scale correctly before the merge either but just pointing it out: PR: #213 ![image](/attachments/75a3944f-c1ff-4119-85ce-b4a4d9dc6ae4)

image.png

45 KiB

c24carso commented

2026-04-22 14:46:23 +00:00

Collaborator

The outline fix in theme.css is commented out, so the default red placeholder shows when dragging/resizing cards. Can just uncomment it. #245

Screenshot 2026-04-22 164259.png

9.5 KiB

Screenshot 2026-04-22 164500.png

8.1 KiB

a24sakma commented

2026-04-22 19:15:39 +00:00

Collaborator

@b24hugst wrote in #491 (comment):

All temperature view outputs are broken except SMHI. Don't know exact branch. All have HTTP ERROR 400 except the TemperatureGraphView and TemperatureView that have HTTP ERROR 500.

I think it's mostly frontend syntax so easy to fix.

@b24hugst this was a known issue when we did update the middleware. Roombooking is the only micro service that works and the below issues were created for this.

@b24hugst wrote in https://git.webug.se/Andras/BoundlessFlowCampus2K/issues/491#issuecomment-4984: > All temperature view outputs are broken except SMHI. Don't know exact branch. All have HTTP ERROR 400 except the TemperatureGraphView and TemperatureView that have HTTP ERROR 500. > > I think it's mostly frontend syntax so easy to fix. > > [![image](/attachments/074132ec-3739-479a-9b52-db5c3c97115a)](/Andras/BoundlessFlowCampus2K/attachments/074132ec-3739-479a-9b52-db5c3c97115a) @b24hugst this was a known issue when we did update the middleware. Roombooking is the only micro service that works and the below issues were created for this.

Screenshot from 2026-04-22 21-15-11.png

110 KiB

👍 1

c24danli commented

2026-04-23 06:14:18 +00:00

Collaborator

Changes in TemperatureView.js are gone. dynamic population of sensors and buttons to chage sensor with.
PR #423

Changes in TemperatureView.js are gone. dynamic population of sensors and buttons to chage sensor with. PR #423

a24vinla commented

2026-04-23 06:22:48 +00:00

Author

Collaborator

@a24julot wrote in #491 (comment):

The default URL for schedule view is gone, I am not sure if this was on purpose or not, but it is gone.

PR: #416

This was done on purpose, since we can add our own URL now. If we want to add a standard URL for the sake of development we could re-add it.

@a24julot wrote in https://git.webug.se/Andras/BoundlessFlowCampus2K/issues/491#issuecomment-4978: > The default URL for schedule view is gone, I am not sure if this was on purpose or not, but it is gone. > > PR: #416 This was done on purpose, since we can add our own URL now. If we want to add a standard URL for the sake of development we could re-add it.

a24vinla commented

2026-04-23 06:36:37 +00:00

Author

Collaborator

@c24carso wrote in #491 (comment):

The outline fix in theme.css is commented out, so the default red placeholder shows when dragging/resizing cards. Can just uncomment it. #245

Fixed!

@c24carso wrote in https://git.webug.se/Andras/BoundlessFlowCampus2K/issues/491#issuecomment-4987: > The outline fix in theme.css is commented out, so the default red placeholder shows when dragging/resizing cards. Can just uncomment it. #245 Fixed!

f21marfo commented

2026-04-23 06:50:53 +00:00

Collaborator

A Work-In-Progress version of an update to the tempSensorMockup unit test, seems to have been merged, which is broken and incomplete. Several variabels are completely missing.

A Work-In-Progress version of an update to the tempSensorMockup unit test, seems to have been merged, which is broken and incomplete. Several variabels are completely missing. ![image](/attachments/e95c4006-de06-4d99-9a8a-0e7b24e7b706)![image](/attachments/8f95861d-1f1a-4de8-8b8c-f5de2c9ae43e)![image](/attachments/52adc3c4-0ad6-483a-a0c9-34717ed7f5ba)

image.png

31 KiB

image.png

30 KiB

a24vinla commented

2026-04-23 07:18:50 +00:00

Author

Collaborator

@a24julot wrote in #491 (comment):

The feature that I implemented that ensured that cards did not spawn over each other is gone. In that implementation I also ensured that when a card is moved, the other cards move away to make space for the card the user is moving/resizing - this is also gone.

PR: #398

This is partly a deliberate change since we are working on a solution that allows us to remove the vertical compacting while not adding cards to the top left corner. Other cards not moving when expanding cards is not fixed with this, will create a separate issue for this. It might not be possible to do without vertical compcating however.

@a24julot wrote in https://git.webug.se/Andras/BoundlessFlowCampus2K/issues/491#issuecomment-4977: > The feature that I implemented that ensured that cards did not spawn over each other is gone. In that implementation I also ensured that when a card is moved, the other cards move away to make space for the card the user is moving/resizing - this is also gone. > > PR: #398 This is partly a deliberate change since we are working on a solution that allows us to remove the vertical compacting while not adding cards to the top left corner. Other cards not moving when expanding cards is not fixed with this, will create a separate issue for this. It might not be possible to do without vertical compcating however.

a24vinla commented

2026-04-23 07:20:43 +00:00

Author

Collaborator

@b24hugst wrote in #491 (comment):

MapView does not scale correctly. I don't know if it did scale correctly before the merge either but just pointing it out:

PR: #213

Apparently a known issue. Will create a separate issue for this.

@b24hugst wrote in https://git.webug.se/Andras/BoundlessFlowCampus2K/issues/491#issuecomment-4985: > MapView does not scale correctly. I don't know if it did scale correctly before the merge either but just pointing it out: > > PR: #213 > > [![image](/attachments/75a3944f-c1ff-4119-85ce-b4a4d9dc6ae4)](/Andras/BoundlessFlowCampus2K/attachments/75a3944f-c1ff-4119-85ce-b4a4d9dc6ae4) Apparently a known issue. Will create a separate issue for this.

a24nedka commented

2026-04-23 07:32:22 +00:00

Collaborator

A lot of things is missing in the tempSensor Mockup test since the merge

a24timsv commented

2026-04-23 07:34:09 +00:00

Collaborator

@f21marfo wrote in #491 (comment):

A Work-In-Progress version of an update to the tempSensorMockup unit test, seems to have been merged, which is broken and incomplete. Several variabels are completely missing.

Seems like it. Do you have access to a complete variant in a branch or PR? If that is the case we can re-implement it ASAP.

@f21marfo wrote in https://git.webug.se/Andras/BoundlessFlowCampus2K/issues/491#issuecomment-5008: > A Work-In-Progress version of an update to the tempSensorMockup unit test, seems to have been merged, which is broken and incomplete. Several variabels are completely missing. Seems like it. Do you have access to a complete variant in a branch or PR? If that is the case we can re-implement it ASAP.

f21marfo commented

2026-04-23 07:39:39 +00:00

Collaborator

@a24timsv wrote in #491 (comment):

@f21marfo wrote in #491 (comment):

A Work-In-Progress version of an update to the tempSensorMockup unit test, seems to have been merged, which is broken and incomplete. Several variabels are completely missing.

Seems like it. Do you have access to a complete variant in a branch or PR? If that is the case we can re-implement it ASAP.

I believe @a24nedka was assigned to updating those tests which i raised as a bug last week in #406

@a24timsv wrote in https://git.webug.se/Andras/BoundlessFlowCampus2K/issues/491#issuecomment-5018: > @f21marfo wrote in #491 (comment): > > > A Work-In-Progress version of an update to the tempSensorMockup unit test, seems to have been merged, which is broken and incomplete. Several variabels are completely missing. > > Seems like it. Do you have access to a complete variant in a branch or PR? If that is the case we can re-implement it ASAP. I believe @a24nedka was assigned to updating those tests which i raised as a bug last week in #406

b23albst commented

2026-04-23 07:41:14 +00:00

Collaborator

It's a minor thing, but the updated SMHIForecastView does not use the api's weather symbol codes for displaying the weather situation

a24vinla commented

2026-04-23 07:47:08 +00:00

Author

Collaborator

@b23albst is there a branch/issue you could link?

a24nedka commented

2026-04-23 07:49:40 +00:00

Collaborator

@a24timsv the version with PR was branch 406 , there is the full version I think.

a24timsv commented

2026-04-23 07:51:36 +00:00

Collaborator

@f21marfo wrote in #491 (comment):

@a24timsv wrote in #491 (comment):

@f21marfo wrote in #491 (comment):

A Work-In-Progress version of an update to the tempSensorMockup unit test, seems to have been merged, which is broken and incomplete. Several variabels are completely missing.

Seems like it. Do you have access to a complete variant in a branch or PR? If that is the case we can re-implement it ASAP.

I believe @a24nedka was assigned to updating those tests which i raised as a bug last week in #406

I found the new code for the test in its branch. It doesn't give errors in VSC now but the test fails (1 out of 4 fails). We have reimplemented it into our temp branch and @a24nedka can look at it later. I will keep the issue open and we will work from there.

@f21marfo wrote in https://git.webug.se/Andras/BoundlessFlowCampus2K/issues/491#issuecomment-5019: > @a24timsv wrote in #491 (comment): > > > @f21marfo wrote in #491 (comment): > > > A Work-In-Progress version of an update to the tempSensorMockup unit test, seems to have been merged, which is broken and incomplete. Several variabels are completely missing. > > > > > > Seems like it. Do you have access to a complete variant in a branch or PR? If that is the case we can re-implement it ASAP. > > I believe @a24nedka was assigned to updating those tests which i raised as a bug last week in #406 I found the new code for the test in its branch. It doesn't give errors in VSC now but the test fails (1 out of 4 fails). We have reimplemented it into our temp branch and @a24nedka can look at it later. I will keep the issue open and we will work from there.

b23albst commented

2026-04-23 07:57:12 +00:00

Collaborator

@a24vinla wrote in #491 (comment):

@b23albst is there a branch/issue you could link?

The branch has been deleted, but the pull request was #432 and the issue is #408

@a24vinla wrote in https://git.webug.se/Andras/BoundlessFlowCampus2K/issues/491#issuecomment-5025: > @b23albst is there a branch/issue you could link? The branch has been deleted, but the pull request was #432 and the issue is #408

c22abdal commented

2026-04-23 08:02:24 +00:00

Collaborator

The textview looks nothing like the changes that were made last (I don't know if someone else changed it after I did?).
and the input field is not working (i,e,. it takes not input)

The textview looks nothing like the changes that were made last (I don't know if someone else changed it after I did?). and the input field is not working (i,e,. it takes not input) ![image](/attachments/4ed3390a-505e-49ba-b634-769eba8a1ab6)

image.png

7.1 KiB

a24nedka commented

2026-04-23 08:02:59 +00:00

Collaborator

Grid layout in Edit mode is missing in the new branch since merge.

c22abdal commented

2026-04-23 08:06:48 +00:00

Collaborator

Parking view is showing an error now

Parking view is showing an error now ![image](/attachments/3fa5460d-26b4-4ceb-b63f-7b4f5c8818c1) ![image](/attachments/1e5ab1cb-69f4-4107-919f-024706a2eb34)

image.png

4.9 KiB

a24timsv commented

2026-04-23 08:14:32 +00:00

Collaborator

@c22abdal wrote in #491 (comment):

Parking view is showing an error now

This is known, see this comment

@c22abdal wrote in https://git.webug.se/Andras/BoundlessFlowCampus2K/issues/491#issuecomment-5049: > Parking view is showing an error now This is known, see [this](https://git.webug.se/Andras/BoundlessFlowCampus2K/issues/491#issuecomment-4990 ) comment

👍 1

b25marem commented

2026-04-23 08:18:37 +00:00

Collaborator

The test project doesn’t build. JsonData.test.cs throws three CS0103 errors:

line 69: propertyName does not exist in the current context
line 99: property does not exist in the current context
line 105: dec does not exist in the current context

The project is expected to compile and all tests should pass.

It looks like JsonData.test.cs wasn’t fully updated after the /temperature`endpoint changed from returning a single object to returning an array.

The test project doesn’t build. JsonData.test.cs throws three CS0103 errors: line 69: propertyName does not exist in the current context line 99: property does not exist in the current context line 105: dec does not exist in the current context The project is expected to compile and all tests should pass. It looks like JsonData.test.cs wasn’t fully updated after the /temperature`endpoint changed from returning a single object to returning an array.

image.png

67 KiB

a24timsv commented

2026-04-23 08:18:52 +00:00

Collaborator

@c22abdal wrote in #491 (comment):

The textview looks nothing like the changes that were made last (I don't know if someone else changed it after I did?). and the input field is not working (i,e,. it takes not input)

I think both teams worked in this View, and it seems that Team 1's branch overwrote team 2's. If you have a PR or branch with your code we can discuss which one to use. In the future we should try to keep teams from changing stuff in the same files.

@c22abdal wrote in https://git.webug.se/Andras/BoundlessFlowCampus2K/issues/491#issuecomment-5037: > The textview looks nothing like the changes that were made last (I don't know if someone else changed it after I did?). and the input field is not working (i,e,. it takes not input) I think both teams worked in this View, and it seems that Team 1's branch overwrote team 2's. If you have a PR or branch with your code we can discuss which one to use. In the future we should try to keep teams from changing stuff in the same files.

a24timsv commented

2026-04-23 08:23:01 +00:00

Collaborator

@b25marem wrote in #491 (comment):

The test project doesn’t build. JsonData.test.cs throws three CS0103 errors:

line 69: propertyName does not exist in the current context line 99: property does not exist in the current context line 105: dec does not exist in the current context

The project is expected to compile and all tests should pass.

It looks like JsonData.test.cs wasn’t fully updated after the /temperature`endpoint changed from returning a single object to returning an array.

See this comment for context: #491 (comment):

It was an old test that wasn't complete, we have it working in our temp branch. We will notify everyone once all bugs are fixed and we the new team branches are live.

@b25marem wrote in https://git.webug.se/Andras/BoundlessFlowCampus2K/issues/491#issuecomment-5054: > The test project doesn’t build. JsonData.test.cs throws three CS0103 errors: > > line 69: propertyName does not exist in the current context line 99: property does not exist in the current context line 105: dec does not exist in the current context > > The project is expected to compile and all tests should pass. > > It looks like JsonData.test.cs wasn’t fully updated after the /temperature`endpoint changed from returning a single object to returning an array. See this comment for context: https://git.webug.se/Andras/BoundlessFlowCampus2K/issues/491#issuecomment-5028: It was an old test that wasn't complete, we have it working in our temp branch. We will notify everyone once all bugs are fixed and we the new team branches are live.

👍 1

b24erika commented

2026-04-23 08:40:31 +00:00

Collaborator

@c22abdal wrote in #491 (comment):

The textview looks nothing like the changes that were made last (I don't know if someone else changed it after I did?). and the input field is not working (i,e,. it takes not input)

I implemented this textview on team1 branch this week, input-tag type-text is mainly for single-line text and instead I changed to textarea-tag. To write anything in the textview you need to press the edit button.

Seems like we worked on the same functionallity and mine was the one merged.

@c22abdal wrote in https://git.webug.se/Andras/BoundlessFlowCampus2K/issues/491#issuecomment-5037: > The textview looks nothing like the changes that were made last (I don't know if someone else changed it after I did?). and the input field is not working (i,e,. it takes not input) [![image](/attachments/4ed3390a-505e-49ba-b634-769eba8a1ab6)](/Andras/BoundlessFlowCampus2K/attachments/4ed3390a-505e-49ba-b634-769eba8a1ab6) I implemented this textview on team1 branch this week, input-tag type-text is mainly for single-line text and instead I changed to textarea-tag. To write anything in the textview you need to press the edit button. Seems like we worked on the same functionallity and mine was the one merged.

c22abdal commented

2026-04-23 08:49:18 +00:00

Collaborator

@b24erika wrote in #491 (comment):

@c22abdal wrote in #491 (comment):

The textview looks nothing like the changes that were made last (I don't know if someone else changed it after I did?). and the input field is not working (i,e,. it takes not input)

I implemented this textview on team1 branch this week, input-tag type-text is mainly for single-line text and instead I changed to textarea-tag. To write anything in the textview you need to press the edit button.

Seems like we worked on the same functionallity and mine was the one merged.

Ok that explains it, the edit button and the erase all button are too close to each other I thought they were the same button.
I implemented a feature to have a title and a body text with just presseing on the text to edit it, and anywhere else to save it

#407

@b24erika wrote in https://git.webug.se/Andras/BoundlessFlowCampus2K/issues/491#issuecomment-5071: > @c22abdal wrote in #491 (comment): > > > The textview looks nothing like the changes that were made last (I don't know if someone else changed it after I did?). and the input field is not working (i,e,. it takes not input) [![image](/attachments/4ed3390a-505e-49ba-b634-769eba8a1ab6)](/Andras/BoundlessFlowCampus2K/attachments/4ed3390a-505e-49ba-b634-769eba8a1ab6) > > I implemented this textview on team1 branch this week, input-tag type-text is mainly for single-line text and instead I changed to textarea-tag. To write anything in the textview you need to press the edit button. > > Seems like we worked on the same functionallity and mine was the one merged. Ok that explains it, the edit button and the erase all button are too close to each other I thought they were the same button. I implemented a feature to have a title and a body text with just presseing on the text to edit it, and anywhere else to save it https://git.webug.se/Andras/BoundlessFlowCampus2K/pulls/407

b24hugst commented

2026-04-23 09:21:35 +00:00

Collaborator

This was a problem before the merge, so just a general issue-idea (sorry if this was a bad place to post this in):

Card minimum size is too small for content to follow accurately, which makes it look very unpleasant.

This was a problem before the merge, so just a general issue-idea (sorry if this was a bad place to post this in): Card minimum size is too small for content to follow accurately, which makes it look very unpleasant. ![image](/attachments/4695cfaf-9374-4abd-ad6c-6921286aa2f7)

image.png

74 KiB

a24timsv commented

2026-04-23 09:46:00 +00:00

Collaborator

@b24hugst wrote in #491 (comment):

This was a problem before the merge, so just a general issue-idea (sorry if this was a bad place to post this in):

Card minimum size is too small for content to follow accurately, which makes it look very unpleasant.

We group leaders currently discuss how big a grid space should be, and hopefully it will solve this ugliness.

@b24hugst wrote in https://git.webug.se/Andras/BoundlessFlowCampus2K/issues/491#issuecomment-5118: > This was a problem before the merge, so just a general issue-idea (sorry if this was a bad place to post this in): > > Card minimum size is too small for content to follow accurately, which makes it look very unpleasant. We group leaders currently discuss how big a grid space should be, and hopefully it will solve this ugliness.