Andras/BoundlessFlowCampus2K

Fork 0

Change card outline colour when resizing #245

New issue

Closed

opened 2026-04-13 07:47:51 +00:00 by a24vinla · 7 comments

a24vinla commented

2026-04-13 07:47:51 +00:00

Collaborator

React-grid-layout uses red to outline the new size of cards when resizing cards, and we need to either remove it altogether or change it to a more appropriate colour. Please provide examples of both.

a24vinla added the

design

frontEnd

labels

2026-04-13 07:47:51 +00:00

c24carso was assigned by c24elipe

2026-04-13 08:13:32 +00:00

c24carso referenced this issue from a commit

2026-04-13 09:28:48 +00:00

#245 change resize outline color to none/blue

c24carso added reference #245-change-card-outline-color

2026-04-13 09:29:52 +00:00

c24carso referenced this issue

2026-04-13 09:37:34 +00:00

#245 change resize outline color to none/blue #254

c24carso commented

2026-04-13 09:46:55 +00:00

Collaborator

Here's the before(red), after(none) and after(blue)

Screenshot 2026-04-13 112107.png

7.4 KiB

Screenshot 2026-04-13 105414.png

8.9 KiB

Screenshot 2026-04-13 112139.png

8.4 KiB

c24elipe commented

2026-04-13 09:50:43 +00:00

Collaborator

A PR has been opened.

c24elipe added the

needs review

label

2026-04-13 09:51:08 +00:00

b24idalu was assigned by c24elipe

2026-04-13 10:01:32 +00:00

b24idalu commented

2026-04-13 10:13:17 +00:00

Collaborator

Is this supposed to be a user setting? Or a decision on what should be?

Either way, code shows examples of both cases and how one can easily change the color to other as well.

Is this supposed to be a user setting? Or a decision on what should be? Either way, code shows examples of both cases and how one can easily change the color to other as well.

hGustavs commented

2026-04-13 13:34:34 +00:00

Owner

Is this while resizing?

I would prefer to show resizing using more than just color, as some people have a hard time to identify what is going on if we only show things using colors, rather than color and luminosity for instance (or outlines / shadows / other ways).

Is this while resizing? I would prefer to show resizing using more than just color, as some people have a hard time to identify what is going on if we only show things using colors, rather than color and luminosity for instance (or outlines / shadows / other ways).

b24idalu removed the

needs review

label

2026-04-13 13:35:49 +00:00

a24vinla commented

2026-04-14 12:01:44 +00:00

Author

Collaborator

I don't however think that the placeholder outline is necessary, since the only restriction to moving or resizing is other cards (i.e. we can't put cards on top of other cards or enlarge a card so that it would take up another cards spot). This together with the grid layout being shown while in edit mode should be enough, therefore allowing us to simply remove the card layout.

Since we change the background in css to a specific colour we should be able to change it to an svg instead, allowing us to have more accessible-friendly feedback. We should also be able to add a border to the grid placeholder. I don't however think that the placeholder outline is necessary, since the only restriction to moving or resizing is other cards (i.e. we can't put cards on top of other cards or enlarge a card so that it would take up another cards spot). This together with the grid layout being shown while in edit mode should be enough, therefore allowing us to simply remove the card layout.

c24carso referenced this issue

2026-04-22 14:51:31 +00:00

Check for bugs after merge #491

a24vinla referenced this issue

2026-04-23 07:52:18 +00:00

Check for bugs after merge #491