Change card outline colour when resizing #245
Labels
No labels
_CRITICAL_
API
app
backEnd
Blocked, waiting for further changes
bug
cleanup
close
design
duplicate
enhancement
feature request
frontEnd
help wanted
invalid
low priority
needs input
needs review
project documentation
question
research
reviewed
script
security
SQL
style
testing
topLevel
wontfix
No milestone
No project
6 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
Andras/BoundlessFlowCampus2K#245
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
React-grid-layout uses red to outline the new size of cards when resizing cards, and we need to either remove it altogether or change it to a more appropriate colour. Please provide examples of both.
Here's the before(red), after(none) and after(blue)
A PR has been opened.
Is this supposed to be a user setting? Or a decision on what should be?
Either way, code shows examples of both cases and how one can easily change the color to other as well.
Is this while resizing?
I would prefer to show resizing using more than just color, as some people have a hard time to identify what is going on if we only show things using colors, rather than color and luminosity for instance (or outlines / shadows / other ways).
Since we change the background in css to a specific colour we should be able to change it to an svg instead, allowing us to have more accessible-friendly feedback. We should also be able to add a border to the grid placeholder.
I don't however think that the placeholder outline is necessary, since the only restriction to moving or resizing is other cards (i.e. we can't put cards on top of other cards or enlarge a card so that it would take up another cards spot). This together with the grid layout being shown while in edit mode should be enough, therefore allowing us to simply remove the card layout.
@a24vinla what is the status of this issue?
This has been fixed.
Andras/BoundlessFlowCampus2K@099a394e86I close this issue