Added a function for translating SMHI symbol codes to text and added it to SMHIForecastView #432

Merged

c24elipe merged 2 commits from 408-expand-smhi-view into team_2_week_2

2026-04-20 13:51:41 +00:00

b23albst commented

2026-04-20 08:39:42 +00:00

Collaborator

Created a function for translating the SMHI symbol code to text and added it to the forecastview.

A future expansion on this could be to display an image for each (or some of) the codes to reflect the weather

Created a function for translating the SMHI symbol code to text and added it to the forecastview. A future expansion on this could be to display an image for each (or some of) the codes to reflect the weather

b23albst added 1 commit

2026-04-20 08:39:43 +00:00

Added a function for translating SMHI symbol codes to text and added it to SMHIForecastView 8814b36abd

b23albst added the

frontEnd

needs review

labels

2026-04-20 08:41:19 +00:00

c24elipe requested review from c22abdal

2026-04-20 09:11:43 +00:00

b23albst was assigned by c24elipe

2026-04-20 09:19:12 +00:00

c22abdal commented

2026-04-20 09:40:15 +00:00

Collaborator

Overall everything is working. But there are a couple of minor issues and recommendations to be addressed.
Minor adjustment: consider using const instead of var to align with modern JS practices and avoid scope-related issues.

var time = new Date(Date.parse(timestamp.time));
//Date formatting options
var options = {
			month: 'short',
			day: 'numeric',
			hour: 'numeric',
			minute: 'numeric',
		};

The commenting style: (i know, sorry!) you are using "//" for multiple lines, whereas on the wiki site it states to use "/* */" with multiple lines: the lines to fix are 10 and 11.

Another issue, I think it belongs to the whole team. The language inconsistency, we are using both English and Swedish, such as "Fel:" or "Laddar ...", "Högskolan i Skövde" while also using "Clear sky" "Forecast" etc. This is an issue that should be discussed within the whole team, in my opinion.

other than that, i agree with your input that "A future expansion on this could be to display an image for each (or some of) the codes to reflect the weather." - You

Overall everything is working. But there are a couple of minor issues and recommendations to be addressed. Minor adjustment: consider using **_const_** instead of **_var_** to align with modern JS practices and avoid scope-related issues. ``` var time = new Date(Date.parse(timestamp.time)); //Date formatting options var options = { month: 'short', day: 'numeric', hour: 'numeric', minute: 'numeric', }; ``` The commenting style: (i know, sorry!) you are using "//" for multiple lines, whereas on the wiki site it states to use "/* */" with multiple lines: the lines to fix are 10 and 11. Another issue, I think it belongs to the whole team. The language inconsistency, we are using both English and Swedish, such as "Fel:" or "Laddar ...", "Högskolan i Skövde" while also using "Clear sky" "Forecast" etc. This is an issue that should be discussed within the whole team, in my opinion. other than that, i agree with your input that "A future expansion on this could be to display an image for each (or some of) the codes to reflect the weather." - You