Andras/BoundlessFlowCampus2K

Fork 0

Remove card button should be enabled/disabled by "enter edit mode" button #340

New issue

Closed

opened 2026-04-16 07:46:34 +00:00 by a24vinla · 4 comments

a24vinla commented

2026-04-16 07:46:34 +00:00

Collaborator

Currently the button is always active, but we want it to only be active when in edit mode

a24vinla added the

frontEnd

label

2026-04-16 07:46:34 +00:00

a24danwe was assigned by c24elipe

2026-04-16 08:11:08 +00:00

a24danwe was unassigned by c24elipe

2026-04-16 08:15:02 +00:00

b24erika self-assigned this

2026-04-16 08:15:09 +00:00

b24erika added the

Team 1

label

2026-04-16 08:21:12 +00:00

b24erika added reference #285-remove-cards-dashboard

2026-04-16 11:23:52 +00:00

b24erika commented

2026-04-16 11:27:32 +00:00

Collaborator

Implemented to only be "allowed" to remove in edit-mode. Did this on the same branch as issue #285 since I needed the actual remove function, made a new branch for this issue but it will be deleted instead since it was a simple and small issue.
Pull-request.

bild.png

123 KiB

bild.png

122 KiB

b24erika added the

needs review

label

2026-04-16 11:31:56 +00:00

e24aleli was assigned by b24johka

2026-04-16 11:36:01 +00:00

e24aleli commented

2026-04-16 12:15:03 +00:00

Collaborator

Review on #340

Whats done

Reviewed issue #340

Tested on Windows 11 using Firefox

Feature works as intended the button is disabled and hidden upon locking the layout and vice versa.
App starts
- Did see HTTP errors on Schedule, Temp and booking view.
- Tested all different views which works, you can remove while in edit mode and you are not able to remove them in locked mode.

Bug Found

There seems to be a bug when you add a view then add a second view, making them stack. The view thats "under" the first view is non-removeable, this could be a react problem but i will do more research regarding it, i dont think it is related to this issue in specific and should therefore be broken out to a separate issue.

Conclusion

Other than that I believe that the code is well commented and written, and the feature works. Good job!

# Review on #340 ## Whats done Reviewed issue #340 ### Tested on Windows 11 using Firefox + Feature works as intended the button is disabled and hidden upon locking the layout and vice versa. + App starts + Did see HTTP errors on Schedule, Temp and booking view. + Tested all different views which works, you can remove while in edit mode and you are not able to remove them in locked mode. ## Bug Found + There seems to be a bug when you add a view then add a second view, making them stack. The view thats "under" the first view is non-removeable, this could be a react problem but i will do more research regarding it, i dont think it is related to this issue in specific and should therefore be broken out to a separate issue. ## Conclusion + Other than that I believe that the code is well commented and written, and the feature works. Good job!

b24erika commented

2026-04-16 12:33:25 +00:00

Collaborator

@e24aleli Thanks for the review!
Stacking cards when adding is another issue and will be resolved (probably), the errors of cards is not related to this frontend issue but good that you point it out.

If you think that there is no further work to be done regarding this issue I suggest you change the label to "reviewed" and remove "needs review".

@e24aleli Thanks for the review! Stacking cards when adding is another issue and will be resolved (probably), the errors of cards is not related to this frontend issue but good that you point it out. If you think that there is no further work to be done regarding this issue I suggest you change the label to "reviewed" and remove "needs review".

e24aleli added

reviewed

and removed

needs review

labels

2026-04-16 12:50:12 +00:00

a24vinla changed title from ~~Remove card button should be enabled/disable by "enter edit mode" button~~ to Remove card button should be enabled/disabled by "enter edit mode" button

2026-04-20 11:09:46 +00:00