Andras/BoundlessFlowCampus2K

Fork 0

#396-AddBodyTextTxtCard #407

Merged

c24elipe merged 3 commits from #396-AddBodyTextTxtCard into team_2_week_2

2026-04-21 10:47:30 +00:00

c22abdal commented

2026-04-17 10:02:57 +00:00

Collaborator

Changed the TextView.js file to add a TextArea.
The text area is resizable vertically and allows new lines.
It uses separate editing than the title to avoid mix-ups and UX confusion

Changed the **TextView.js** file to add a TextArea. The text area is resizable vertically and allows new lines. It uses separate editing than the title to avoid mix-ups and UX confusion

c22abdal added 2 commits

2026-04-17 10:02:57 +00:00

Created a textView field for body 59cfd385fd

Added Breaking lines in textArea bdbc36e23c

c22abdal added the

needs review

label

2026-04-17 10:03:10 +00:00

c22abdal added a new dependency

2026-04-17 10:04:48 +00:00

#396 Add body and title text to text card

c22abdal removed a dependency

2026-04-17 10:05:03 +00:00

#396 Add body and title text to text card

c24elipe requested review from a24danwe

2026-04-17 10:26:56 +00:00

a24danwe commented

2026-04-17 13:42:00 +00:00

Collaborator

"const [editingField, setIsEditing] = useState(null);" should be const [editingField, setEditing] = useState(null); since it is no longer an boolean.

Also you set "useState(null);" so it expects a null value but later you use "setIsEditing(false);". You should change it for setIsEditing(null);

Other than these 2 inconsistencies everything is working as intended.

I have reviewed the files concerning this issue(textView.js) and also the application to see if everything working as intended and have come to the conclusion that overall everything is working fine. Just some small inconsistencies. "const [editingField, setIsEditing] = useState(null);" should be const [editingField, setEditing] = useState(null); since it is no longer an boolean. Also you set "useState(null);" so it expects a null value but later you use "setIsEditing(false);". You should change it for setIsEditing(null); Other than these 2 inconsistencies everything is working as intended.

a24danwe added

reviewed

and removed

needs review

labels

2026-04-17 13:43:29 +00:00

c22abdal added 1 commit

2026-04-20 08:36:05 +00:00

Fixed inconsistencies 19430f4c1c

c22abdal commented

2026-04-20 08:36:28 +00:00

Author

Collaborator

Done!

c22abdal added

needs review

and removed

reviewed

labels

2026-04-20 08:36:37 +00:00

c22abdal was assigned by c24elipe

2026-04-20 08:47:14 +00:00

c24elipe requested review from c24carso

2026-04-21 08:35:07 +00:00

c24carso commented

2026-04-21 09:31:44 +00:00

Collaborator

Review on #396

Whats done

Tested on Windows using Firefox

App starts
- Title editing works, clicking shows input field, pressing Enter or clicking outside saves and closes
- Body editing works, same as above

Inspected following files

frontend/src/features/text/TextView.js
- Indentation/code styling
  - Follows Prettier
- Naming convention
  - Follows wiki standards
  - Previous review issues fixed: setIsEditing renamed to setEditing, false changed to null
- Comments
  - No comments
- General code quality
  - looks good
frontend/package.json
- No new dependencies added

Conclusion

Text boxes works as intended. Previous review issues have been fixed.

# Review on #396 ## Whats done ### Tested on Windows using Firefox + App starts + Title editing works, clicking shows input field, pressing Enter or clicking outside saves and closes + Body editing works, same as above ### Inspected following files + frontend/src/features/text/TextView.js + Indentation/code styling + Follows Prettier + Naming convention + Follows wiki standards + Previous review issues fixed: setIsEditing renamed to setEditing, false changed to null + Comments + No comments + General code quality + looks good + frontend/package.json + No new dependencies added ## Conclusion + Text boxes works as intended. Previous review issues have been fixed.