implement-toolbar-design #463
Labels
No labels
_CRITICAL_
API
app
backEnd
Blocked, waiting for further changes
bug
cleanup
close
design
duplicate
enhancement
feature request
frontEnd
help wanted
invalid
low priority
needs input
needs review
project documentation
question
research
reviewed
script
security
SQL
style
testing
topLevel
wontfix
No milestone
No project
No assignees
3 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
Andras/BoundlessFlowCampus2K!463
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "implement-toolbar-design"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Code looks good and dashboard functions and toolbar settings work when testing in Linux. Ready to be merged
New issue: Cards generated disappear when going to settings and back. Cards generated should be saved and not removed.
This is not an problem for this issue in particular as it only tackles the implementation of design and not functionality
I think this ^ is in the works as we speak
Review on ##427
Has been reviewed by @a24hirsa, I just wanted to add that in the Wiki, we specified "All declarations within the rule set should be ordered alphabetically". For example this rule set:
.switch{
position: relative;
display: inline-block;
width: 60px;
height: 34px;
background-color: white, green;
}
should look like:
.switch{
background-color: white, green;
display: inline-block;
height: 34px;
position: relative;
width: 60px;
}
Additionally, we specified in the Wiki that "Use hex codes for colors, check the design document (issue #16) for the correct hex code. https://git.webug.se/Andras/BoundlessFlowCampus2K/wiki/Webpage-Design". The green color for the edit button should probably have the green we were provided from the school. But I believe that for some of the colors, using the colors for different themes maybe would be the way to go, rather than the colors being hardcoded.
This is just an idea, everything else looks good and the frontend is very impressive! Good job!
Really good review, i will fix these things before merging.
Although i dont think its suitable to change a toggle button to change depending on the theme that is set, since green is the sign for "Active" and grey is "Inactive". The dashboard container is changing along with themes.
This has been merged manually. Very sufficient review.
Pull request closed