Andras/BoundlessFlowCampus2K

Fork 0

implement-toolbar-design #463

Closed

b24johka wants to merge 0 commits from implement-toolbar-design into team_1_week_2

b24johka commented

2026-04-21 08:00:10 +00:00

Collaborator

Created toggle button for Edit mode
Removed unused imports for previous button
Created styling for the dropdown
Created and implemented the dashboard.css file
Created the toolbar div and also go well with switching of themes

- Created toggle button for Edit mode - Removed unused imports for previous button - Created styling for the dropdown - Created and implemented the dashboard.css file - Created the toolbar div and also go well with switching of themes

b24johka added 6 commits

2026-04-21 08:00:11 +00:00

Initial start of the implementation of toolbar for dashboard 6d56ee02a6

Implemented toolbar design b79db45451

Added style to dropdown menu, header and paragraph to the left side of the taskbar.

Created a button to toggle between on and off in edit mode 6020e5ea12

Merge branch 'implement-toolbar-design' of https://git.webug.se/Andras/BoundlessFlowCampus2K into implement-toolbar-design 4614a63a70

Created the dashboard div design ae7c10ec7e

CSS instead of inline, works better with switching color schemes 5fab53f633

b24johka commented

2026-04-21 08:02:44 +00:00

Author

Collaborator

![image](/attachments/d3051986-a93c-4d8b-a802-c75fe6afcd7d) ![image](/attachments/2b52b24e-1522-4459-94ed-94a9672219fc)

image.png

92 KiB

image.png

59 KiB

b24johka

2026-04-21 08:19:03 +00:00

added the
Team 1
label
requested review from a24julot

a24hirsa commented

2026-04-21 08:33:41 +00:00

Collaborator

Code looks good and dashboard functions and toolbar settings work when testing in Linux. Ready to be merged

New issue: Cards generated disappear when going to settings and back. Cards generated should be saved and not removed.
This is not an problem for this issue in particular as it only tackles the implementation of design and not functionality

Code looks good and dashboard functions and toolbar settings work when testing in Linux. Ready to be merged New issue: Cards generated disappear when going to settings and back. Cards generated should be saved and not removed. This is not an problem for this issue in particular as it only tackles the implementation of design and not functionality

a24hirsa added the

reviewed

label

2026-04-21 08:33:59 +00:00

b24johka requested review from a24hirsa

2026-04-21 08:35:38 +00:00

b24johka commented

2026-04-21 08:36:42 +00:00

Author

Collaborator

I think this ^ is in the works as we speak

a24julot commented

2026-04-21 08:45:43 +00:00

Collaborator

Review on ##427

Has been reviewed by @a24hirsa, I just wanted to add that in the Wiki, we specified "All declarations within the rule set should be ordered alphabetically". For example this rule set:
.switch{
position: relative;
display: inline-block;
width: 60px;
height: 34px;
background-color: white, green;
}

should look like:
.switch{
background-color: white, green;
display: inline-block;
height: 34px;
position: relative;
width: 60px;
}

Additionally, we specified in the Wiki that "Use hex codes for colors, check the design document (issue #16) for the correct hex code. https://git.webug.se/Andras/BoundlessFlowCampus2K/wiki/Webpage-Design". The green color for the edit button should probably have the green we were provided from the school. But I believe that for some of the colors, using the colors for different themes maybe would be the way to go, rather than the colors being hardcoded.
This is just an idea, everything else looks good and the frontend is very impressive! Good job!

# Review on #https://git.webug.se/Andras/BoundlessFlowCampus2K/issues/427 Has been reviewed by @a24hirsa, I just wanted to add that in the Wiki, we specified "All declarations within the rule set should be ordered alphabetically". For example this rule set: .switch{ position: relative; display: inline-block; width: 60px; height: 34px; background-color: white, green; } should look like: .switch{ background-color: white, green; display: inline-block; height: 34px; position: relative; width: 60px; } Additionally, we specified in the Wiki that "Use hex codes for colors, check the design document (issue #16) for the correct hex code. https://git.webug.se/Andras/BoundlessFlowCampus2K/wiki/Webpage-Design". The green color for the edit button should probably have the green we were provided from the school. But I believe that for some of the colors, using the colors for different themes maybe would be the way to go, rather than the colors being hardcoded. This is just an idea, everything else looks good and the frontend is very impressive! Good job!

b24johka commented

2026-04-21 09:08:02 +00:00

Author

Collaborator

Really good review, i will fix these things before merging.

a24vinla referenced this pull request

2026-04-21 09:08:36 +00:00

Load content from layout config to views #462

b24johka commented

2026-04-21 09:11:11 +00:00

Author

Collaborator

Although i dont think its suitable to change a toggle button to change depending on the theme that is set, since green is the sign for "Active" and grey is "Inactive". The dashboard container is changing along with themes.

👍 1

b24johka added 1 commit

2026-04-21 09:23:33 +00:00

Switched to HEX instead of RGB and colors febf2451f3

b24johka commented

2026-04-21 11:34:04 +00:00

Author

Collaborator

This has been merged manually. Very sufficient review.

b24johka closed this pull request

2026-04-21 11:34:08 +00:00

b24johka deleted branch implement-toolbar-design