#508 Re-Usable dashboard toggle button #518

Merged

b24johka merged 1 commit from #508-break-out-toggle-from-dashboard-with-css into team_1_week_3

2026-04-24 07:05:31 +00:00

f21marfo commented

2026-04-23 12:08:00 +00:00

Collaborator

Broke out the toggle switch into its own component with style sheet.
Button supports custom state names (e.g. ON and OFF) and callback assignment, via parameters.
Created ToggleButton folder containing ToggleButton.js and ToggleButton.module.css.
Updated /components/index.js to expose new ToggleButton for import.
Integrated it with Dashboard.js.
Removed toggle switch entries from Dashboard.module.css. (!Please double-check that this change does not unintentionally break anything!).

- Broke out the toggle switch into its own component with style sheet. Button supports custom state names (e.g. ON and OFF) and callback assignment, via parameters. - Created ToggleButton folder containing ToggleButton.js and ToggleButton.module.css. - Updated /components/index.js to expose new ToggleButton for import. - Integrated it with Dashboard.js. - Removed toggle switch entries from Dashboard.module.css. (!Please double-check that this change does not unintentionally break anything!).

f21marfo added the

frontEnd

needs review

labels

2026-04-23 12:08:00 +00:00

f21marfo added 1 commit

2026-04-23 12:08:01 +00:00

Created ToggleButton component and updated Dashboard 5b0cd21826

- Broke out the toggle switch into its own component and style sheet.'
+ Created ToggleButton folder containing ToggleButton.js and ToggleButton.module.css.
+ Updated /components/index.js to export new ToggleButton
- Integrated it with Dashboard.js.
- Removed toggle switch entries from Dashboard.module.css.

b24johka requested review from a24hamrh

2026-04-23 12:14:56 +00:00

a24hamrh commented

2026-04-23 12:44:30 +00:00

Collaborator

Review on #518

Whats done

Reviewed #518

Tested on Windows 11 using Firefox

App starts
- The toggle button works as intended. I tried toggling edit mode on and off whit and without views.

Inspected following files: Dashboard.js, Dasboard.module.js, ToggleButton.js, ToggleButton.module.js.

All inspected files.
- Indentation/code styling
  - Indentation is ok.
- Naming convention
  - The naming convention is followed.
- Comments
  - Overall good but could be more in ToggleButton.js.
- General code quality
  - The general code quality is good.

Conclusion

Everything works as expected and the code looks good. The toggle button for edit mode is its own component whit its own css-file.

# Review on #518 ## Whats done Reviewed #518 ### Tested on Windows 11 using Firefox + App starts + The toggle button works as intended. I tried toggling edit mode on and off whit and without views. ### Inspected following files: Dashboard.js, Dasboard.module.js, ToggleButton.js, ToggleButton.module.js. + All inspected files. + Indentation/code styling + Indentation is ok. + Naming convention + The naming convention is followed. + Comments + Overall good but could be more in ToggleButton.js. + General code quality + The general code quality is good. ## Conclusion + Everything works as expected and the code looks good. The toggle button for edit mode is its own component whit its own css-file.